Skip to contentSkip to conversation

habanalabs fixes for 5.2-rc2/3

GIT PULL Oded Gabbay 2 participants 4 messages May 24, 2019 – May 31, 2019

lore
Share & tools
lore
#0 lore raw

Hi Greg,

This is the pull request containing fixes for 5.2-rc2/3. It is now correctly rebased on your char-misc-linux branch.

It supersedes the pull request from 12/5, so you can discard that pull request, as I see you didn't merge it anyway.

It contains 3 fixes and 1 change to a new IOCTL that was introduced to kernel 5.2 in the previous pull requests.

See the tag comment for more details.

Thanks,
Oded

The following changes since commit a188339ca5a396acc588e5851ed7e19f66b0ebd9:

Linux 5.2-rc1 (2019-05-19 15:47:09 -0700)

are available in the Git repository at:

git://people.freedesktop.org/~gabbayo/linux tags/misc-habanalabs-fixes-2019-05-24

for you to fetch changes up to 8d45f1de3994c566cb5ce9b3cb07ff1518e68ddb:

habanalabs: Avoid using a non-initialized MMU cache mutex (2019-05-24 22:46:15 +0300)

----------------------------------------------------------------
This tag contains the following fixes:

- Halt debug engines when user process closes the FD. We can't allow the device to issue transactions for a user which doesn't exists anymore.

- Fix various security holes in debugfs API.

- Add a new opcode to the DEBUG IOCTL API. The opcode is designed for setting the device into and out of debug mode. Although not a fix per-se, because this is a new IOCTL which is upstreamed in kernel 5.2, I think this is justified at this point because we won't be able to change the API later.

- Fix a bug where the code used an uninitialized mutex

----------------------------------------------------------------
Jann Horn (1):
habanalabs: fix debugfs code

Oded Gabbay (1):
uapi/habanalabs: add opcode for enable/disable device debug mode

Omer Shpigelman (1):
habanalabs: halt debug engines on user process close

Tomer Tayar (1):
habanalabs: Avoid using a non-initialized MMU cache mutex

 drivers/misc/habanalabs/context.c             |  6 +++
 drivers/misc/habanalabs/debugfs.c             | 60 ++++++++-------------------
 drivers/misc/habanalabs/device.c              |  2 +
 drivers/misc/habanalabs/goya/goya.c           |  3 +-
 drivers/misc/habanalabs/goya/goyaP.h          |  1 +
 drivers/misc/habanalabs/goya/goya_coresight.c | 17 ++++++++
 drivers/misc/habanalabs/habanalabs.h          |  2 +
 drivers/misc/habanalabs/mmu.c                 |  8 +---
 include/uapi/misc/habanalabs.h                | 22 +++++++++-
 9 files changed, 69 insertions(+), 52 deletions(-)
#1 lore raw
Quoted 9 lines · Oded Gabbay

Hi Greg,

This is the pull request containing fixes for 5.2-rc2/3. It is now correctly rebased on your char-misc-linux branch.

It supersedes the pull request from 12/5, so you can discard that pull request, as I see you didn't merge it anyway.

Quoted 8 lines

It contains 3 fixes and 1 change to a new IOCTL that was introduced to kernel 5.2 in the previous pull requests.

See the tag comment for more details.

Thanks,
Oded

Hi Greg,
Pinging you in case this got lost in the mail.

Thanks,
Oded

#2 lore raw
Quoted 13 lines · Oded Gabbay
Quoted 12 lines · Oded Gabbay

Hi Greg,

This is the pull request containing fixes for 5.2-rc2/3. It is now correctly rebased on your char-misc-linux branch.

It supersedes the pull request from 12/5, so you can discard that pull request, as I see you didn't merge it anyway.

It contains 3 fixes and 1 change to a new IOCTL that was introduced to kernel 5.2 in the previous pull requests.

Quoted 7 lines
Quoted 5 lines

See the tag comment for more details.

Thanks,
Oded

Hi Greg,
Pinging you in case this got lost in the mail.

Not lost, just delayed, am traveling at the moment. Will go do this now so I don't forget...

thanks,

greg k-h

#3 lore raw
In reply to Oded Gabbay
Quoted 10 lines · Oded Gabbay

Hi Greg,

This is the pull request containing fixes for 5.2-rc2/3. It is now correctly rebased on your char-misc-linux branch.

It supersedes the pull request from 12/5, so you can discard that pull request, as I see you didn't merge it anyway.

It contains 3 fixes and 1 change to a new IOCTL that was introduced to kernel 5.2 in the previous pull requests.

Pulled and pushed out, thanks.

greg k-h