package/kvm-unit-tests: fix build without ssp on x86_64
PATCH v2 1/1 package/kvm-unit-tests: fix build without ssp on x86_64
Makefile tries to detect stack-protector which will result in build failure on x86_64 if ssp is not available on host compiler so disable stack protector through EXTRA_CFLAGS
Fixes:
- http://autobuild.buildroot.org/results/e6f767755ffdb5ecc014eb5ad7519814f075a60e
---
Changes v1 -> v2 (after review of Peter Korsgaard):
- Always disable stack-protector on x86_64 as we're using host compiler
package/kvm-unit-tests/kvm-unit-tests.mk | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
package/kvm-unit-tests/kvm-unit-tests.mk +5 -2
@@ -37,6 +37,8 @@ KVM_UNIT_TESTS_CONF_OPTS =\ # x86-64 cannot do. ifneq ($(BR2_x86_64),y) KVM_UNIT_TESTS_CONF_OPTS += --cross-prefix="$(TARGET_CROSS)" +# Don't force -fstack-protector as we don't know if host compiler supports ssp +KVM_UNIT_TESTS_MAKE_OPTS += EXTRA_CFLAGS=-fno-stack-protector endif define KVM_UNIT_TESTS_CONFIGURE_CMDS
@@ -44,11 +46,12 @@ define KVM_UNIT_TESTS_CONFIGURE_CMDS endef define KVM_UNIT_TESTS_BUILD_CMDS - $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) standalone + $(TARGET_MAKE_ENV) $(MAKE) $(KVM_UNIT_TESTS_MAKE_OPTS) -C $(@D) \ + standalone endef define KVM_UNIT_TESTS_INSTALL_TARGET_CMDS - $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \ + $(TARGET_MAKE_ENV) $(MAKE) $(KVM_UNIT_TESTS_MAKE_OPTS) -C $(@D) \ DESTDIR=$(TARGET_DIR)/usr/share/kvm-unit-tests/ \ install endef
Signature · 1 line
2.20.1
PATCH v2 1/1 package/kvm-unit-tests: fix build without ssp on x86_64
Quoted 3 lines · Fabrice Fontaine
Makefiletries to detect stack-protector which will result in build failure onx86_64if ssp is not available on host compiler so disable stack protector throughEXTRA_CFLAGS
I would like to actually understand the failure though... The error is:
/usr/bin/ld: x86/realmode.o: in function `print_serial_u32':.../x86/realmode.c:104: undefined reference to `__stack_chk_fail'
However, realmode.c is built with
gcc -mno-red-zone -m32 -O1 -g -MMD -MF x86/.realmode.d -Wall -Wwrite-strings -Wclobbered -Wempty-body -Wuninitialized -Wignored-qualifiers
-Wunused-but-set-parameter -fno-omit-frame-pointer -Wno-frame-address
-fno-pic -no-pie -Wmissing-parameter-type -Wold-style-declaration
-Woverride-init -std=gnu99 -ffreestanding -I /data/buildroot/buildroot-test/instance-1/output/build/kvm-unit-tests-kvm-unit-tests-20171020/lib -I /data/buildroot/buildroot-test/instance-1/output/build/kvm-unit-tests-kvm-unit-tests-20171020/lib/x86
-I lib -c -o x86/realmode.o x86/realmode.c
So, stack-protector is *not* enabled... So what the hell is going on here?
It seems to only happen on Xogium's Arch Linux server. Maybe there's something
weird going on with that server?
Regards,
Arnout
Quoted 41 lines
Fixes:
- http://autobuild.buildroot.org/results/e6f767755ffdb5ecc014eb5ad7519814f075a60eSigned-off-by Fabrice Fontaine <[email protected]>---
Changes v1 -> v2 (after review of Peter Korsgaard):
- Always disable stack-protector onx86_64as we're using host compilerpackage/kvm-unit-tests/kvm-unit-tests.mk | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)package/kvm-unit-tests/kvm-unit-tests.mk +5
-2@@ -37,6 +37,8 @@ KVM_UNIT_TESTS_CONF_OPTS =\ # x86-64 cannot do. ifneq ($(BR2_x86_64),y) KVM_UNIT_TESTS_CONF_OPTS += --cross-prefix="$(TARGET_CROSS)" +# Don't force -fstack-protector as we don't know if host compiler supports ssp +KVM_UNIT_TESTS_MAKE_OPTS += EXTRA_CFLAGS=-fno-stack-protector endif define KVM_UNIT_TESTS_CONFIGURE_CMDS@@ -44,11 +46,12 @@ define KVM_UNIT_TESTS_CONFIGURE_CMDS endef define KVM_UNIT_TESTS_BUILD_CMDS - $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) standalone + $(TARGET_MAKE_ENV) $(MAKE) $(KVM_UNIT_TESTS_MAKE_OPTS) -C $(@D) \ + standalone endef define KVM_UNIT_TESTS_INSTALL_TARGET_CMDS - $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \ + $(TARGET_MAKE_ENV) $(MAKE) $(KVM_UNIT_TESTS_MAKE_OPTS) -C $(@D) \ DESTDIR=$(TARGET_DIR)/usr/share/kvm-unit-tests/ \ install endef
PATCH v2 1/1 package/kvm-unit-tests: fix build without ssp on x86_64
Arnout, All,
On 2019-05-26 20:20 +0200, Arnout Vandecappelle spake thusly:
Quoted 22 lines · Fabrice Fontaine
Quoted 3 lines
Makefiletries to detect stack-protector which will result in build failure onx86_64if ssp is not available on host compiler so disable stack protector throughEXTRA_CFLAGSI would like to actually understand the failure though... The error is:
/usr/bin/ld:x86/realmode.o: in function `print_serial_u32':.../x86/realmode.c:104: undefined reference to `__stack_chk_fail'However,
realmode.cis built withgcc -mno-red-zone -m32 -O1 -g -MMD -MF x86/.realmode.d -Wall -Wwrite-strings
(quoted diff) +0
-4-Wclobbered -Wempty-body -Wuninitialized -Wignored-qualifiers -Wunused-but-set-parameter -fno-omit-frame-pointer -Wno-frame-address -fno-pic -no-pie -Wmissing-parameter-type -Wold-style-declaration -Woverride-init -std=gnu99 -ffreestanding -I/data/buildroot/buildroot-test/instance-1/output/build/kvm-unit-tests-kvm-unit-tests-20171020/lib -I /data/buildroot/buildroot-test/instance-1/output/build/kvm-unit-tests-kvm-unit-tests-20171020/lib/x86
-I lib -c -ox86/realmode.ox86/realmode.c
Quoted 4 lines
So, stack-protector is *not* enabled... So what the hell is going on here?
It seems to only happen on Xogium's Arch Linux server. Maybe there's something
weird going on with that server?
That's because:
- kvm-unit-tests, on x86_64 target, uses the host compiler to build:
https://git.buildroot.org/buildroot/tree/package/kvm-unit-tests/kvm-unit-tests.mk#n34
- Xogium's autobuilder is running Arch Linux, which enables SSP by default, yes.
Regards,
Yann E. MORIN.
Quoted 48 lines
Regards,
ArnoutQuoted 31 lines
Fixes:
- http://autobuild.buildroot.org/results/e6f767755ffdb5ecc014eb5ad7519814f075a60eSigned-off-by Fabrice Fontaine <[email protected]>---
Changes v1 -> v2 (after review of Peter Korsgaard):
- Always disable stack-protector onx86_64as we're using host compilerpackage/kvm-unit-tests/kvm-unit-tests.mk | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)package/kvm-unit-tests/kvm-unit-tests.mk +2
-1@@ -37,6 +37,8 @@ KVM_UNIT_TESTS_CONF_OPTS =\ # x86-64 cannot do. ifneq ($(BR2_x86_64),y) KVM_UNIT_TESTS_CONF_OPTS += --cross-prefix="$(TARGET_CROSS)" +# Don't force -fstack-protector as we don't know if host compiler supports ssp +KVM_UNIT_TESTS_MAKE_OPTS += EXTRA_CFLAGS=-fno-stack-protector endif define KVM_UNIT_TESTS_CONFIGURE_CMDS@@ -44,11 +46,12 @@ define KVM_UNIT_TESTS_CONFIGURE_CMDS endef define KVM_UNIT_TESTS_BUILD_CMDS - $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) standalonepackage/kvm-unit-tests/kvm-unit-tests.mk define KVM_UNIT_TESTS_CONFIGURE_CMDS · line 57
Quoted 10 lines
package/kvm-unit-tests/kvm-unit-tests.mk +3
-1+ $(TARGET_MAKE_ENV) $(MAKE) $(KVM_UNIT_TESTS_MAKE_OPTS) -C $(@D) \ + standalone endef define KVM_UNIT_TESTS_INSTALL_TARGET_CMDS - $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \ + $(TARGET_MAKE_ENV) $(MAKE) $(KVM_UNIT_TESTS_MAKE_OPTS) -C $(@D) \ DESTDIR=$(TARGET_DIR)/usr/share/kvm-unit-tests/ \ install endef_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/1 package/kvm-unit-tests: fix build without ssp on x86_64
Quoted 32 lines · Yann E. MORIN
Arnout, All,
On 2019-05-26 20:20 +0200, Arnout Vandecappelle spake thusly:
Quoted 22 lines · Fabrice Fontaine
Quoted 3 lines
Makefiletries to detect stack-protector which will result in build failure onx86_64if ssp is not available on host compiler so disable stack protector throughEXTRA_CFLAGSI would like to actually understand the failure though... The error is:
/usr/bin/ld:x86/realmode.o: in function `print_serial_u32':.../x86/realmode.c:104: undefined reference to `__stack_chk_fail'However,
realmode.cis built withgcc -mno-red-zone -m32 -O1 -g -MMD -MF x86/.realmode.d -Wall -Wwrite-strings
(quoted diff) +0
-4-Wclobbered -Wempty-body -Wuninitialized -Wignored-qualifiers -Wunused-but-set-parameter -fno-omit-frame-pointer -Wno-frame-address -fno-pic -no-pie -Wmissing-parameter-type -Wold-style-declaration -Woverride-init -std=gnu99 -ffreestanding -I/data/buildroot/buildroot-test/instance-1/output/build/kvm-unit-tests-kvm-unit-tests-20171020/lib -I /data/buildroot/buildroot-test/instance-1/output/build/kvm-unit-tests-kvm-unit-tests-20171020/lib/x86
-I lib -c -ox86/realmode.ox86/realmode.cQuoted 4 lines
So, stack-protector is *not* enabled... So what the hell is going on here?
It seems to only happen on Xogium's Arch Linux server. Maybe there's something
weird going on with that server?That's because:
Quoted 5 lines
- kvm-unit-tests, on
x86_64target, uses the host compiler to build:
https://git.buildroot.org/buildroot/tree/package/kvm-unit-tests/kvm-unit-tests.mk#n34- Xogium's autobuilder is running Arch Linux, which enables SSP by default, yes.
... and it does that in a way that is incompatible with -nostdlib, apparently?
Ubuntu also enables stack-protector by default (since 12.10 I think), so why
doesn't it happen on Ubuntu?
Smells like a broken distro to me...
Xogium, could you investigate this? Or someone else with Arch?
Regards,
Arnout
PATCH v2 1/1 package/kvm-unit-tests: fix build without ssp on x86_64
In reply to Fabrice FontaineQuoted 8 lines · Fabrice Fontaine
Makefiletries to detect stack-protector which will result in build failure onx86_64if ssp is not available on host compiler so disable stack protector throughEXTRA_CFLAGSFixes:
- http://autobuild.buildroot.org/results/e6f767755ffdb5ecc014eb5ad7519814f075a60eSigned-off-by Fabrice Fontaine <[email protected]>
After more testing by Matt, applied to master with an updated commit message:
package/kvm-unit-tests: fix build on Arch Linux x86_64
On x86_64, we use the host compiler instead of the target compiler to build kvm-unit-tests, because it is built with -m32 and our target compiler doesn't support that.
However, the compiler on Arch Linux is broken: it *always* builds with -fstack-protector, even when -ffreestanding is passed. However, when -fnostdlib is passed at link time (which is normally the case when building with -ffreestanding), it is not linked with the stack-protector library. This leads to a link time error:
/usr/bin/ld: x86/realmode.o: in function `print_serial_u32':
.../x86/realmode.c:104: undefined reference to `__stack_chk_fail'
Since the entire package is built with -ffreestanding, it doesn't support stack-protector at all. Therefore, simply pass -fno-stack-protector explicitly on x86_64 to work around the bug in Arch Linux.
Bug reported upstream: https://bugs.archlinux.org/task/64270
Thanks everybody for investigating this.
Regards,
Arnout
Quoted 36 lines
---
Changes v1 -> v2 (after review of Peter Korsgaard):
- Always disable stack-protector onx86_64as we're using host compilerpackage/kvm-unit-tests/kvm-unit-tests.mk | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)package/kvm-unit-tests/kvm-unit-tests.mk +5
-2@@ -37,6 +37,8 @@ KVM_UNIT_TESTS_CONF_OPTS =\ # x86-64 cannot do. ifneq ($(BR2_x86_64),y) KVM_UNIT_TESTS_CONF_OPTS += --cross-prefix="$(TARGET_CROSS)" +# Don't force -fstack-protector as we don't know if host compiler supports ssp +KVM_UNIT_TESTS_MAKE_OPTS += EXTRA_CFLAGS=-fno-stack-protector endif define KVM_UNIT_TESTS_CONFIGURE_CMDS@@ -44,11 +46,12 @@ define KVM_UNIT_TESTS_CONFIGURE_CMDS endef define KVM_UNIT_TESTS_BUILD_CMDS - $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) standalone + $(TARGET_MAKE_ENV) $(MAKE) $(KVM_UNIT_TESTS_MAKE_OPTS) -C $(@D) \ + standalone endef define KVM_UNIT_TESTS_INSTALL_TARGET_CMDS - $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \ + $(TARGET_MAKE_ENV) $(MAKE) $(KVM_UNIT_TESTS_MAKE_OPTS) -C $(@D) \ DESTDIR=$(TARGET_DIR)/usr/share/kvm-unit-tests/ \ install endef
PATCH v2 1/1 package/kvm-unit-tests: fix build without ssp on x86_64
Quoted 29 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle <[email protected]> writes:
Quoted 8 lines · Fabrice Fontaine
Makefiletries to detect stack-protector which will result in build failure onx86_64if ssp is not available on host compiler so disable stack protector throughEXTRA_CFLAGSFixes:
- http://autobuild.buildroot.org/results/e6f767755ffdb5ecc014eb5ad7519814f075a60eSigned-off-by Fabrice Fontaine <[email protected]>After more testing by Matt, applied to master with an updated commit message:
package/kvm-unit-tests: fix build on Arch Linux
x86_64On
x86_64, we use the host compiler instead of the target compiler to build kvm-unit-tests, because it is built with -m32 and our target compiler doesn't support that.However, the compiler on Arch Linux is broken: it *always* builds with -fstack-protector, even when -ffreestanding is passed. However, when -fnostdlib is passed at link time (which is normally the case when building with -ffreestanding), it is not linked with the stack-protector library. This leads to a link time error:
/usr/bin/ld:x86/realmode.o: in function `print_serial_u32':
.../x86/realmode.c:104: undefined reference to `__stack_chk_fail'
Quoted 6 lines
Since the entire package is built with -ffreestanding, it doesn't support stack-protector at all. Therefore, simply pass -fno-stack-protector explicitly on
x86_64to work around the bug in Arch Linux.Bug reported upstream: https://bugs.archlinux.org/task/64270
Committed to 2019.02.x and 2019.08.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard