Skip to contentSkip to conversation

drm/nouveau/bios: downgrade absence of tmds table to info from an error

PATCH In review Rhys Kidd 2 participants 2 messages Jun 2, 2019 – Jun 4, 2019

Subsystems (3)
lore
Share & tools
lore

Rhys Kidd

author
#0 lore raw

PATCH 1/1 drm/nouveau/bios: downgrade absence of tmds table to info from an error

Absence of a TMDS Info Table is common on Optimus setups where the NVIDIA gpu is not connected directly to any outputs.

Reporting an error in this scenario is too harsh. Accordingly, change the error message to an info message.

By default the error message also causes a boot flicker for these sytems.

---
 drivers/gpu/drm/nouveau/nouveau_bios.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_bios.c +1 -1
index 66bf2aff4a3e..bdfadc63204a 100644
@@ -935,7 +935,7 @@ static int parse_bit_tmds_tbl_entry(struct drm_device *dev, struct nvbios *bios,
 
 	tmdstableptr = ROM16(bios->data[bitentry->offset]);
 	if (!tmdstableptr) {
-		NV_ERROR(drm, "Pointer to TMDS table invalid\n");
+		NV_INFO(drm, "Pointer to TMDS table not found\n");
 		return -EINVAL;
 	}
 
Signature · 1 line
2.20.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 28 lines · Rhys Kidd

Absence of a TMDS Info Table is common on Optimus setups where the NVIDIA gpu is not connected directly to any outputs.

Reporting an error in this scenario is too harsh. Accordingly, change the error message to an info message.

By default the error message also causes a boot flicker for these sytems.

---
 drivers/gpu/drm/nouveau/nouveau_bios.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/nouveau/nouveau_bios.c +1 -1
index 66bf2aff4a3e..bdfadc63204a 100644
@@ -935,7 +935,7 @@ static int parse_bit_tmds_tbl_entry(struct drm_device
 *dev, struct nvbios *bios,
 
 	tmdstableptr = ROM16(bios->data[bitentry->offset]);
 	if (!tmdstableptr) {
-		NV_ERROR(drm, "Pointer to TMDS table invalid\n");
+		NV_INFO(drm, "Pointer to TMDS table not found\n");
 		return -EINVAL;
 	}
Signature · 2 lines
Cheers,
	Lyude Paul