Skip to contentSkip to conversation

pci: ibmphp: add check of return value from pci_hp_register()

PATCH In review Emanuel Bennici 2 participants 2 messages Jun 2, 2019 – Jun 5, 2019 PCI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pci: ibmphp: add check of return value from pci_hp_register()

Check the return value of pci_hp_register() in Function ebda_rsrc_controller()

---
 drivers/pci/hotplug/ibmphp_ebda.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/pci/hotplug/ibmphp_ebda.c +9 -2
index 11a2661dc062..7e523ce071b3 100644
@@ -896,10 +896,17 @@ static int __init ebda_rsrc_controller(void)
 
 	}			/* each hpc  */
 
+	int result = 0;
 	list_for_each_entry(tmp_slot, &ibmphp_slot_head, ibm_slot_list) {
 		snprintf(name, SLOT_NAME_SIZE, "%s", create_file_name(tmp_slot));
-		pci_hp_register(&tmp_slot->hotplug_slot,
-			pci_find_bus(0, tmp_slot->bus), tmp_slot->device, name);
+		result = pci_hp_register(&tmp_slot->hotplug_slot,
+					 pci_find_bus(0, tmp_slot->bus),
+					 tmp_slot->device, name);
+
+		if (result) {
+			err("pci_hp_register failed with error %d\n", result);
+			goto error;
+		}
 	}
 
 	print_ebda_hpc();
Signature · 1 line
2.19.1
#1 lore raw
Quoted 4 lines · Emanuel Bennici

Check the return value of pci_hp_register() in Function ebda_rsrc_controller()

Maybe this is correct, maybe not.
You are changing behaviour of the function.
How did you test this?

Quoted 32 lines
---
 drivers/pci/hotplug/ibmphp_ebda.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/pci/hotplug/ibmphp_ebda.c +9 -3
index 11a2661dc062..7e523ce071b3 100644
@@ -896,10 +896,17 @@ static int __init ebda_rsrc_controller(void)
 
        }                       /* each hpc  */
 
+       int result = 0;
        list_for_each_entry(tmp_slot, &ibmphp_slot_head, ibm_slot_list) {
                snprintf(name, SLOT_NAME_SIZE, "%s", create_file_name(tmp_slot));
-               pci_hp_register(&tmp_slot->hotplug_slot,
-                       pci_find_bus(0, tmp_slot->bus), tmp_slot->device, name);
+               result = pci_hp_register(&tmp_slot->hotplug_slot,
+                                        pci_find_bus(0, tmp_slot->bus),
+                                        tmp_slot->device, name);
+
+               if (result) {
+                       err("pci_hp_register failed with error %d\n", result);
+                       goto error;
+               }
        }
 
        print_ebda_hpc();
--

2.19.1

Signature · 2 lines
With Best Regards,
Andy Shevchenko