Skip to contentSkip to conversation

erofs-utils: correct --with-lz4 example in README

PATCH New Yue Hu 2 participants 3 messages May 31, 2019 – Jun 3, 2019

lore
Share & tools
lore

Yue Hu

author
#0 lore raw

PATCH 1/1 erofs-utils: correct --with-lz4 example in README

From: Yue Hu <[email protected]>

Option --with-lz4 means LZ4 install directory rather than LZ4 lib directory. We will meet configuration error due to wrong path if setting --with-lz4 to /usr/local/lib. Also stay the same with LZ4 help in configure shell script.

Signed-off-by Yue Hu <huyue2 at yulong.com>
---
 README | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
README +2 -2
index 9014268..97eb228 100644
@@ -19,8 +19,8 @@ Dependencies
 
 How to build with lz4 static library
 	./configure --with-lz4=<lz4 install path>
-eg. if lz4 lib has been installed into fold of /usr/local/lib
-	./configure --with-lz4=/usr/local/lib && make
+eg. if lz4 has been installed into fold of /usr/local
+	./configure --with-lz4=/usr/local && make
 On Fedora, static lz4 can be installed using:
 	yum install lz4-static.x86_64
 To build you should run this first:
Signature · 1 line
1.9.1
Applied
#1 lore raw

PATCH 1/1 erofs-utils: correct --with-lz4 example in README

Quoted 8 lines · Yue Hu

From: Yue Hu <huyue2 at yulong.com>

Option --with-lz4 means LZ4 install directory rather than LZ4 lib directory. We will meet configuration error due to wrong path if setting --with-lz4 to /usr/local/lib. Also stay the same with LZ4 help in configure shell script.

Signed-off-by Yue Hu <huyue2 at yulong.com>

Applied to mkfs-dev. However, I'd suggest to take a look at new erofs-utils since I want to mark old mkfs.erofs as obsoleted...

Thanks,
Gao Xiang

Quoted 20 lines
---
 README | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
README +2 -2
index 9014268..97eb228 100644
@@ -19,8 +19,8 @@ Dependencies
 
 How to build with lz4 static library
 	./configure --with-lz4=<lz4 install path>
-eg. if lz4 lib has been installed into fold of /usr/local/lib
-	./configure --with-lz4=/usr/local/lib && make
+eg. if lz4 has been installed into fold of /usr/local
+	./configure --with-lz4=/usr/local && make
 On Fedora, static lz4 can be installed using:
 	yum install lz4-static.x86_64
 To build you should run this first:
author
#2 lore raw

PATCH 1/1 erofs-utils: correct --with-lz4 example in README

Quoted 8 lines · On Sat, 1 Jun 2019 13:38:09 +0800 Gao Xiang <[email protected]> wrote:
Quoted 7 lines · Yue Hu

From: Yue Hu <huyue2 at yulong.com>

Option --with-lz4 means LZ4 install directory rather than LZ4 lib directory. We will meet configuration error due to wrong path if setting --with-lz4 to /usr/local/lib. Also stay the same with LZ4 help in configure shell script.

Quoted 4 lines
Quoted 1 line
Signed-off-by Yue Hu <huyue2 at yulong.com>

Applied to mkfs-dev. However, I'd suggest to take a look at new erofs-utils since I want to mark old mkfs.erofs as obsoleted...

Ok, got it.

Thx.

Quoted 24 lines

Thanks,
Gao Xiang

Quoted 20 lines
---
 README | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
README +2 -2
index 9014268..97eb228 100644
@@ -19,8 +19,8 @@ Dependencies
 
 How to build with lz4 static library
 	./configure --with-lz4=<lz4 install path>
-eg. if lz4 lib has been installed into fold of /usr/local/lib
-	./configure --with-lz4=/usr/local/lib && make
+eg. if lz4 has been installed into fold of /usr/local
+	./configure --with-lz4=/usr/local && make
 On Fedora, static lz4 can be installed using:
 	yum install lz4-static.x86_64
 To build you should run this first: