Skip to contentSkip to conversation

mfd: menelaus: Remove superfluous error message

PATCH Applied Alexandre Belloni 2 participants 2 messages May 21, 2019 – Jun 3, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: menelaus: Remove superfluous error message

The RTC core already has error messages in case of failure, there is no need to have another message in the driver.

---
 drivers/mfd/menelaus.c | 2 --
 1 file changed, 2 deletions(-)
drivers/mfd/menelaus.c +0 -2
index d28ebe7ecd21..91c568ef5857 100644
@@ -1138,8 +1138,6 @@ static inline void menelaus_rtc_init(struct menelaus_chip *m)
 			menelaus_remove_irq_work(MENELAUS_RTCALM_IRQ);
 			device_init_wakeup(&m->client->dev, 0);
 		}
-		dev_err(&m->client->dev, "can't register RTC: %d\n",
-				(int) PTR_ERR(m->rtc));
 		the_menelaus->rtc = NULL;
 	}
 }
Signature · 1 line
2.21.0
Applied
#1 lore raw
Quoted 7 lines · Alexandre Belloni

The RTC core already has error messages in case of failure, there is no need to have another message in the driver.

---
 drivers/mfd/menelaus.c | 2 --
 1 file changed, 2 deletions(-)

Applied, thanks.

Signature · 4 lines
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog