Skip to contentSkip to conversation

ASoC: soc-core: fix ifnullfree.cocci warnings

PATCH In review Julia Lawall 2 participants 2 messages May 30, 2019 – Jun 3, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: soc-core: fix ifnullfree.cocci warnings

From: kbuild test robot <[email protected]>

sound/soc/soc-core.c:391:2-7: WARNING: NULL check before some freeing functions is not needed.

NULL check before some freeing functions is not needed.

Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes 8e144273005d ("ASoC: soc-core: merge soc_new_pcm_runtime() and soc_rtd_init()")

---

tree:   https://github.com/morimoto/linux fw-cleanup-2019-05-30-v3
head:   7f2c61a9097fcf25dac44865db31e7eab5c8fc9d
commit: 8e144273005d3caf8b9978e407e3d00b6180dd49 [96/103] ASoC: soc-core: merge soc_new_pcm_runtime() and soc_rtd_init()

:::::: branch date: 12 hours ago
:::::: commit date: 12 hours ago

Please take the patch only if it's a positive warning. Thanks!

 soc-core.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
sound/soc/soc-core.c +1 -2
@@ -387,8 +387,7 @@ static void soc_free_pcm_runtime(struct
 
 	snd_soc_rtdcom_del_all(rtd);
 
-	if (rtd->codec_dais)
-		kfree(rtd->codec_dais);
+	kfree(rtd->codec_dais);
 
 	list_del(&rtd->list);
 	kfree(rtd);
maintainer
#1 lore raw
Quoted 5 lines · Julia Lawall

From: kbuild test robot <[email protected]>

sound/soc/soc-core.c:391:2-7: WARNING: NULL check before some freeing functions is not needed.

NULL check before some freeing functions is not needed.

This doesn't apply against current code, please check and resend.