remoteproc: imx: Broaden the Kconfig selection logic
Subsystems (2)
Fabio Estevam
reviewerPATCH 1/2 remoteproc: imx: Broaden the Kconfig selection logic
Besides i.MX6SX and i.MX7D, there are other i.MX devices that contain Cortex M4 and could make use of the imx remoteproc driver, such as i.MX7ULP, i.MX8M, etc.
Instead of adding new SoC entries in the Kconfig logic, make it broader by using the more generic ARCH_MXC, which encompasses all the 32-bit and 64-bit i.MX devices.
--- drivers/remoteproc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/remoteproc/Kconfig +1 -1
@@ -16,7 +16,7 @@ if REMOTEPROC config IMX_REMOTEPROC tristate "IMX6/7 remoteproc support" - depends on SOC_IMX6SX || SOC_IMX7D + depends on ARCH_MXC help Say y here to support iMX's remote processors (Cortex M4 on iMX7D) via the remote processor framework.
Signature · 1 line
2.17.1
Fabio Estevam
reviewerPATCH 2/2 remoteproc: imx: Fix typo in "failed"
There are several places where "failed" is spelled incorrectly.
Fix them all.
--- drivers/remoteproc/imx_rproc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/remoteproc/imx_rproc.c +4 -4
@@ -168,7 +168,7 @@ static int imx_rproc_start(struct rproc *rproc) ret =regmap_update_bits (priv->regmap, dcfg->src_reg, dcfg->src_mask, dcfg->src_start);if (ret) -dev_err (dev,"Filed to enable M4!\n" ); +dev_err (dev,"Failed to enable M4!\n" );return ret; }
@@ -183,7 +183,7 @@ static int imx_rproc_stop(struct rproc *rproc) ret =regmap_update_bits (priv->regmap, dcfg->src_reg, dcfg->src_mask, dcfg->src_stop);if (ret) -dev_err (dev,"Filed to stop M4!\n" ); +dev_err (dev,"Failed to stop M4!\n" );return ret; }
@@ -206,7 +206,7 @@ static int imx_rproc_da_to_sys(struct imx_rproc *priv, u64 da, } } -dev_warn (priv->dev,"Translation filed: da = 0x%llx len = 0x%x\n" , +dev_warn (priv->dev,"Translation failed: da = 0x%llx len = 0x%x\n" , da, len);return -ENOENT ; }
@@ -352,7 +352,7 @@ static int imx_rproc_probe(struct platform_device *pdev) ret =imx_rproc_addr_init (priv, pdev);if (ret) { -dev_err (dev,"filed on imx_rproc_addr_init\n" ); +dev_err (dev,"failed on imx_rproc_addr_init\n" ); goto err_put_rproc; }
Signature · 1 line
2.17.1
Re: [PATCH 2/2] remoteproc: imx: Fix typo in "failed"
Quoted 3 lines · Fabio Estevam
There are several places where "failed" is spelled incorrectly.
Fix them all.
Thank you!
Quoted 49 lines
Signed-off-by Fabio Estevam <[email protected]>--- drivers/remoteproc/imx_rproc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/remoteproc/imx_rproc.c +4
-4@@ -168,7 +168,7 @@ static int imx_rproc_start(struct rproc *rproc) ret =regmap_update_bits (priv->regmap, dcfg->src_reg, dcfg->src_mask, dcfg->src_start);if (ret) -dev_err (dev,"Filed to enable M4!\n" ); +dev_err (dev,"Failed to enable M4!\n" );return ret; }@@ -183,7 +183,7 @@ static int imx_rproc_stop(struct rproc *rproc) ret =regmap_update_bits (priv->regmap, dcfg->src_reg, dcfg->src_mask, dcfg->src_stop);if (ret) -dev_err (dev,"Filed to stop M4!\n" ); +dev_err (dev,"Failed to stop M4!\n" );return ret; }@@ -206,7 +206,7 @@ static int imx_rproc_da_to_sys(struct imx_rproc *priv, u64 da, } } -dev_warn (priv->dev,"Translation filed: da = 0x%llx len = 0x%x\n" , +dev_warn (priv->dev,"Translation failed: da = 0x%llx len = 0x%x\n" , da, len);return -ENOENT ; }@@ -352,7 +352,7 @@ static int imx_rproc_probe(struct platform_device *pdev) ret =imx_rproc_addr_init (priv, pdev);if (ret) { -dev_err (dev,"filed on imx_rproc_addr_init\n" ); +dev_err (dev,"failed on imx_rproc_addr_init\n" ); goto err_put_rproc; }Signature · 1 line
2.17.1
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Quoted 7 lines · Fabio Estevam
Besides i.MX6SX and i.MX7D, there are other i.MX devices that contain Cortex M4 and could make use of the imx remoteproc driver, such as i.MX7ULP, i.MX8M, etc.
Instead of adding new SoC entries in the
Kconfiglogic, make it broader by using the more genericARCH_MXC, which encompasses all the 32-bit and 64-bit i.MX devices.
Quoted 22 lines
Signed-off-by Fabio Estevam <[email protected]>--- drivers/remoteproc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/remoteproc/Kconfig +1
-1@@ -16,7 +16,7 @@ if REMOTEPROC config IMX_REMOTEPROC tristate "IMX6/7 remoteproc support" - depends on SOC_IMX6SX || SOC_IMX7D + depends on ARCH_MXC help Say y here to support iMX's remote processors (Cortex M4 on iMX7D) via the remote processor framework.Signature · 1 line
2.17.1
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Quoted 8 lines · Fabio Estevam
Besides i.MX6SX and i.MX7D, there are other i.MX devices that contain Cortex M4 and could make use of the imx remoteproc driver, such as i.MX7ULP, i.MX8M, etc.
Instead of adding new SoC entries in the
Kconfiglogic, make it broader by using the more genericARCH_MXC, which encompasses all the 32-bit and 64-bit i.MX devices.
Patches applied with Oleksij's review.
Thanks,
Bjorn
Quoted 21 lines
Signed-off-by Fabio Estevam <[email protected]>--- drivers/remoteproc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/remoteproc/Kconfig +1
-1@@ -16,7 +16,7 @@ if REMOTEPROC config IMX_REMOTEPROC tristate "IMX6/7 remoteproc support" - depends on SOC_IMX6SX || SOC_IMX7D + depends on ARCH_MXC help Say y here to support iMX's remote processors (Cortex M4 on iMX7D) via the remote processor framework.Signature · 1 line
2.17.1