mtd: onenand_base: Mark expected switch fall-through

PATCH Applied Gustavo A. R. Silva 3 participants 5 messages Jun 4, 2019 – Jul 1, 2019

Subsystems (3)

Memory technology devices (MTD) NAND flash Onenand flash driver

lore

Share & tools

lore

Gustavo A. R. Silva

author

2019-06-04 14:17 UTC #0 lore raw

PATCH 1/1 mtd: onenand_base: Mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/mtd/nand/onenand/onenand_base.c: In function ‘onenand_check_features’:
drivers/mtd/nand/onenand/onenand_base.c:3264:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
this->options |= ONENAND_HAS_NOP_1;
drivers/mtd/nand/onenand/onenand_base.c:3265:2: note: here
case ONENAND_DEVICE_DENSITY_4Gb:
^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.

Cc Jonathan Bakker <[email protected]>

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/mtd/nand/onenand/onenand_base.c | 1 +
 1 file changed, 1 insertion(+)

drivers/mtd/nand/onenand/onenand_base.c +1 -0

index ba46d0cf60a1..bdb5f4733d28 100644
@@ -3262,6 +3262,7 @@ static void onenand_check_features(struct mtd_info *mtd)
 	switch (density) {
 	case ONENAND_DEVICE_DENSITY_8Gb:
 		this->options |= ONENAND_HAS_NOP_1;
+		/* fall through */
 	case ONENAND_DEVICE_DENSITY_4Gb:
 		if (ONENAND_IS_DDP(this))
 			this->options |= ONENAND_HAS_2PLANE;

Signature · 1 line

2.21.0

Kees Cook

Reviewed-by on v1 1/1

2019-06-04 14:45 UTC #1 lore raw

Quoted 12 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/mtd/nand/onenand/onenand_base.c: In function ‘onenand_check_features’:
drivers/mtd/nand/onenand/onenand_base.c:3264:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
this->options |= ONENAND_HAS_NOP_1;
drivers/mtd/nand/onenand/onenand_base.c:3265:2: note: here
case ONENAND_DEVICE_DENSITY_4Gb:
^~~~

Quoted 7 lines

Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Cc Jonathan Bakker <[email protected]>
Signed-off-by Gustavo A. R. Silva <[email protected]>

Reviewed-by Kees Cook <[email protected]>

-Kees

Quoted 19 lines

---
 drivers/mtd/nand/onenand/onenand_base.c | 1 +
 1 file changed, 1 insertion(+)

drivers/mtd/nand/onenand/onenand_base.c +1 -0

index ba46d0cf60a1..bdb5f4733d28 100644
@@ -3262,6 +3262,7 @@ static void onenand_check_features(struct mtd_info *mtd)
 	switch (density) {
 	case ONENAND_DEVICE_DENSITY_8Gb:
 		this->options |= ONENAND_HAS_NOP_1;
+		/* fall through */
 	case ONENAND_DEVICE_DENSITY_4Gb:
 		if (ONENAND_IS_DDP(this))
 			this->options |= ONENAND_HAS_2PLANE;

Signature · 1 line

2.21.0

Signature · 1 line

Kees Cook

Gustavo A. R. Silva

author

2019-06-26 18:16 UTC #2 lore raw

Hi all,

Friendly ping:

Who can take this?

Thanks
--
Gustavo

Quoted 45 lines · Kees Cook

Quoted 12 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/mtd/nand/onenand/onenand_base.c: In function ‘onenand_check_features’:
drivers/mtd/nand/onenand/onenand_base.c:3264:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
this->options |= ONENAND_HAS_NOP_1;
drivers/mtd/nand/onenand/onenand_base.c:3265:2: note: here
case ONENAND_DEVICE_DENSITY_4Gb:
^~~~
Quoted 7 lines
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Cc Jonathan Bakker <[email protected]>
Signed-off-by Gustavo A. R. Silva <[email protected]>
Reviewed-by Kees Cook <[email protected]>
-Kees
Quoted 19 lines
---
 drivers/mtd/nand/onenand/onenand_base.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/nand/onenand/onenand_base.c +1 -0
index ba46d0cf60a1..bdb5f4733d28 100644
@@ -3262,6 +3262,7 @@ static void onenand_check_features(struct mtd_info *mtd)
 	switch (density) {
 	case ONENAND_DEVICE_DENSITY_8Gb:
 		this->options |= ONENAND_HAS_NOP_1;
+		/* fall through */
 	case ONENAND_DEVICE_DENSITY_4Gb:
 		if (ONENAND_IS_DDP(this))
 			this->options |= ONENAND_HAS_2PLANE;
Signature · 1 line
2.21.0

Miquel Raynal

maintainer

2019-06-27 16:45 UTC #3 lore raw

Hi Gustavo,

"Gustavo A. R. Silva" <[email protected]> wrote on Wed, 26 Jun 2019 13:16:22 -0500:

Quoted 5 lines

Hi all,
Friendly ping:
Who can take this?

I am queuing it right now, please be patient.

Also for next time, the prefix should have been "mtd: onenand:" but that's ok, I edited the title.

Thanks,
Miquèl

Miquel Raynal

maintainer Applied

2019-07-01 07:18 UTC #4 lore raw

In reply to Gustavo A. R. Silva

Hi Gustavo,

"Gustavo A. R. Silva" <[email protected]> wrote on Tue, 4 Jun 2019 09:17:37 -0500:

Quoted 28 lines

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/mtd/nand/onenand/onenand_base.c: In function ‘onenand_check_features’:
drivers/mtd/nand/onenand/onenand_base.c:3264:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
this->options |= ONENAND_HAS_NOP_1;
drivers/mtd/nand/onenand/onenand_base.c:3265:2: note: here
case ONENAND_DEVICE_DENSITY_4Gb:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
Cc Jonathan Bakker <[email protected]>
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/mtd/nand/onenand/onenand_base.c | 1 +
 1 file changed, 1 insertion(+)
drivers/mtd/nand/onenand/onenand_base.c +0 -0
index ba46d0cf60a1..bdb5f4733d28 100644

drivers/mtd/nand/onenand/onenand_base.c static void onenand_check_features(struct mtd_info *mtd) · line 3268

Quoted 7 lines

drivers/mtd/nand/onenand/onenand_base.c +1 -0

@@ -3262,6 +3262,7 @@ static void onenand_check_features(struct mtd_info *mtd)
 	switch (density) {
 	case ONENAND_DEVICE_DENSITY_8Gb:
 		this->options |= ONENAND_HAS_NOP_1;
+		/* fall through */
 	case ONENAND_DEVICE_DENSITY_4Gb:
 		if (ONENAND_IS_DDP(this))
 			this->options |= ONENAND_HAS_2PLANE;

Applied to nand/next, thanks.

Miquèl