Skip to contentSkip to conversation

staging: rtl8188eu: core: Replace function rtw_free_network_nolock

PATCH Superseded Nishka Dasgupta 2 participants 2 messages Jun 4, 2019 – Jun 6, 2019 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: rtl8188eu: core: Replace function rtw_free_network_nolock

Remove function rtw_free_network_nolock, as all it does is call _rtw_free_network_nolock, and rename _rtw_free_network_nolock to rtw_free_network_nolock.

---
 drivers/staging/rtl8188eu/core/rtw_mlme.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/staging/rtl8188eu/core/rtw_mlme.c +1 -7
index 0abb2df32645..454c5795903d 100644
@@ -159,7 +159,7 @@ static void _rtw_free_network(struct mlme_priv *pmlmepriv, struct wlan_network *
 	spin_unlock_bh(&free_queue->lock);
 }
 
-void _rtw_free_network_nolock(struct	mlme_priv *pmlmepriv, struct wlan_network *pnetwork)
+void rtw_free_network_nolock(struct	mlme_priv *pmlmepriv, struct wlan_network *pnetwork)
 {
 	struct __queue *free_queue = &pmlmepriv->free_bss_pool;
 
@@ -276,12 +276,6 @@ static struct wlan_network *rtw_alloc_network(struct mlme_priv *pmlmepriv)
 	return _rtw_alloc_network(pmlmepriv);
 }
 
-static void rtw_free_network_nolock(struct mlme_priv *pmlmepriv,
-				    struct wlan_network *pnetwork)
-{
-	_rtw_free_network_nolock(pmlmepriv, pnetwork);
-}
-
 int rtw_is_same_ibss(struct adapter *adapter, struct wlan_network *pnetwork)
 {
 	int ret = true;
Signature · 1 line
2.19.1
maintainer
#1 lore raw
Quoted 14 lines · Nishka Dasgupta

Remove function rtw_free_network_nolock, as all it does is call _rtw_free_network_nolock, and rename _rtw_free_network_nolock to rtw_free_network_nolock.

---
 drivers/staging/rtl8188eu/core/rtw_mlme.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)
drivers/staging/rtl8188eu/core/rtw_mlme.c +0 -0
index 0abb2df32645..454c5795903d 100644

drivers/staging/rtl8188eu/core/rtw_mlme.c static void _rtw_free_network(struct mlme_priv *pmlmepriv, struct wlan_network * · line 162

Quoted 5 lines
drivers/staging/rtl8188eu/core/rtw_mlme.c +1 -1
@@ -159,7 +159,7 @@ static void _rtw_free_network(struct mlme_priv *pmlmepriv, struct wlan_network *
 	spin_unlock_bh(&free_queue->lock);
 }
 
-void _rtw_free_network_nolock(struct	mlme_priv *pmlmepriv, struct wlan_network *pnetwork)
+void rtw_free_network_nolock(struct	mlme_priv *pmlmepriv, struct wlan_network *pnetwork)

Why is this function moved from being static to not being static?

that doesn't seem right to me, does it to you?

thanks,

greg k-h