Skip to contentSkip to conversation

package/libubootenv: needs threads

PATCH New Fabrice Fontaine 3 participants 6 messages Jun 3, 2019 – Jun 4, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libubootenv: needs threads

Fixes:
- http://autobuild.buildroot.org/results/813e8951530c093f46b38bf8c3b467ab6535c95b

---
 package/libubootenv/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/libubootenv/Config.in +4 -0
index 9be52c4522..016497abbb 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBUBOOTENV
 	bool "libubootenv"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_ZLIB
 	help
 	  libubootenv is a library that provides a hardware independent
@@ -9,3 +10,6 @@ config BR2_PACKAGE_LIBUBOOTENV
 	  new tools build from the library and not from U-Boot.
 
 	  https://github.com/sbabic/libubootenv/
+
+comment "libubootenv needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 package/libubootenv: needs threads

Hi Fabrice,

Le 03/06/2019 ? 21:59, Fabrice Fontaine a ?crit?:

Quoted 4 lines

Fixes:
- http://autobuild.buildroot.org/results/813e8951530c093f46b38bf8c3b467ab6535c95b

Thanks for the fix !

Quoted 23 lines
---
  package/libubootenv/Config.in | 4 ++++
  1 file changed, 4 insertions(+)
package/libubootenv/Config.in +4 -0
index 9be52c4522..016497abbb 100644
@@ -1,5 +1,6 @@
  config BR2_PACKAGE_LIBUBOOTENV
  	bool "libubootenv"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
  	select BR2_PACKAGE_ZLIB
  	help
  	  libubootenv is a library that provides a hardware independent
@@ -9,3 +10,6 @@ config BR2_PACKAGE_LIBUBOOTENV
  	  new tools build from the library and not from U-Boot.
 
  	  https://github.com/sbabic/libubootenv/
+
+comment "libubootenv needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 2 lines
Best regards,
Pierre-Jean Texier
#2 lore raw

PATCH 1/1 package/libubootenv: needs threads

In reply to Fabrice Fontaine

Hello,

Quoted 4 lines · On Mon, 3 Jun 2019 21:59:26 +0200 Fabrice Fontaine…

Fixes:
- http://autobuild.buildroot.org/results/813e8951530c093f46b38bf8c3b467ab6535c95b

From a very quick glance at the code and a quick build test, the <pthread.h> include doesn't seem to be necessary. Perhaps it should simply be removed ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw

PATCH 1/1 package/libubootenv: needs threads

Hello,

Le 04/06/2019 ? 09:07, Thomas Petazzoni a ?crit?:

Quoted 5 lines

Hello,

On Mon, 3 Jun 2019 21:59:26 +0200
Fabrice Fontaine <[email protected]> wrote:

Quoted 8 lines
Quoted 4 lines

Fixes:
- http://autobuild.buildroot.org/results/813e8951530c093f46b38bf8c3b467ab6535c95b

From a very quick glance at the code and a quick build test, the
<pthread.h> include doesn't seem to be necessary. Perhaps it should simply be removed ?

Indeed, you are right.

If needed, I can send the patch upstream.
I've already updated this on my local branch [1]
and the build is now OK:

- br-arm-full-nothread [1/1]: OK

Thanks,

[1] -
https://github.com/texierp/buildroot/commit/452941dd7a225e25ef16f71119b277f69eb6ec66

Signature · 2 lines
Best regards,
Pierre-Jean Texier
#4 lore raw

PATCH 1/1 package/libubootenv: needs threads

Hello,

Le mar. 4 juin 2019 ? 14:05, Pierre-Jean Texier <[email protected]> a ?crit :

Quoted 14 lines

Hello,

Le 04/06/2019 ? 09:07, Thomas Petazzoni a ?crit :

Quoted 10 lines

Hello,

Quoted 4 lines · On Mon, 3 Jun 2019 21:59:26 +0200 Fabrice Fontaine…

Fixes:
- http://autobuild.buildroot.org/results/813e8951530c093f46b38bf8c3b467ab6535c95b

Quoted 7 lines
Quoted 3 lines

From a very quick glance at the code and a quick build test, the
<pthread.h> include doesn't seem to be necessary. Perhaps it should simply be removed ?

Indeed, you are right.

If needed, I can send the patch upstream.

I'll mark my patch as "Not applicable" in patchwork. Can you also send your patch to buildroot?

Quoted 5 lines

I've already updated this on my local branch [1]
and the build is now OK:

- br-arm-full-nothread [1/1]: OK

Quoted 7 lines

Thanks,

[1] -
https://github.com/texierp/buildroot/commit/452941dd7a225e25ef16f71119b277f69eb6ec66
--
Best regards,
Pierre-Jean Texier

Best Regards,

Fabrice

#5 lore raw

PATCH 1/1 package/libubootenv: needs threads

Hello,

Le 04/06/2019 ? 14:24, Fabrice Fontaine a ?crit?:

Quoted 2 lines

I'll mark my patch as "Not applicable" in patchwork. Can you also send your patch to buildroot?

Sure, I will do.

Thanks

Signature · 2 lines
Best regards,
Pierre-Jean Texier