Skip to contentSkip to conversation

drm/amd/powerplay/smu7_hwmgr: replace blocking delay with non-blocking

PATCH Applied Yrjan Skrimstad 3 participants 7 messages May 30, 2019 – Jul 5, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/amd/powerplay/smu7_hwmgr: replace blocking delay with non-blocking

This driver currently contains a repeated 500ms blocking delay call which causes frequent major buffer underruns in PulseAudio. This patch fixes this issue by replacing the blocking delay with a non-blocking sleep call.

---
 drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c +1 -1
index 048757e8f494..340afdbddc72 100644
@@ -3494,7 +3494,7 @@ static int smu7_get_gpu_power(struct pp_hwmgr *hwmgr, u32 *query)
 							ixSMU_PM_STATUS_95, 0);
 
 	for (i = 0; i < 10; i++) {
-		mdelay(500);
+		msleep(500);
 		smum_send_msg_to_smc(hwmgr, PPSMC_MSG_PmStatusLogSample);
 		tmp = cgs_read_ind_register(hwmgr->device,
 						CGS_IND_REG__SMC,
Signature · 6 lines
2.20.1

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
#1 lore raw
Quoted 4 lines · Yrjan Skrimstad

This driver currently contains a repeated 500ms blocking delay call which causes frequent major buffer underruns in PulseAudio. This patch fixes this issue by replacing the blocking delay with a non-blocking sleep call.

I see that I have not explained this bug well enough, and I hope that is the reason for the lack of replies on this patch. I will here attempt to explain the situation better.

To start with some hardware description I am here using an AMD R9 380 GPU, an AMD Ryzen 7 1700 Eight-Core Processor and an AMD X370 chipset. If any more hardware or software specifications are necessary, please ask.

The bug is as follows: When playing audio I will regularly have major audio issues, similar to that of a skipping CD. This is reported by PulseAudio as scheduling delays and buffer underruns when running PulseAudio verbosely and these scheduling delays are always just under 500ms, typically around 490ms. This makes listening to any music quite the horrible experience as PulseAudio constantly will attempt to rewind and catch up. It is not a great situation, and seems to me to quite clearly be a case where regular user space behaviour has been broken.

I want to note that this audio problem was not something I experienced until recently, it is therefore a new bug.

I have bisected the kernel to find out where the problem originated and found the following commit:

# first bad commit: [f5742ec36422a39b57f0256e4847f61b3c432f8c] drm/amd/powerplay: correct power reading on fiji

This commit introduces a blocking delay (mdelay) of 500ms, whereas the old behaviour was a smaller blocking delay of only 1ms. This seems to me to be very curious as the scheduling delays of PulseAudio are always almost 500ms. I have therefore with the previous patch replaced the scheduling delay with a non-blocking sleep (msleep).

The results of the patch seems promising as I have yet to encounter any of the old <500ms scheduling delays when using it and I have also not encountered any kernel log messages regarding sleeping in an atomic context.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#2 lore raw

CC trimmed

Hello Alex and Harry,

any comments on this?
I'm running my Xeon X3470 (4c/8t) with this under amd-staging-drm-next (as always ;-) ) and see no issues so far.

Thanks!
Dieter

Am 04.06.2019 22:21, schrieb Yrjan Skrimstad:

Quoted 39 lines · Yrjan Skrimstad
Quoted 4 lines

This driver currently contains a repeated 500ms blocking delay call which causes frequent major buffer underruns in PulseAudio. This patch fixes this issue by replacing the blocking delay with a non-blocking sleep call.

I see that I have not explained this bug well enough, and I hope that is the reason for the lack of replies on this patch. I will here attempt to explain the situation better.

To start with some hardware description I am here using an AMD R9 380 GPU, an AMD Ryzen 7 1700 Eight-Core Processor and an AMD X370 chipset. If any more hardware or software specifications are necessary, please ask.

The bug is as follows: When playing audio I will regularly have major audio issues, similar to that of a skipping CD. This is reported by PulseAudio as scheduling delays and buffer underruns when running PulseAudio verbosely and these scheduling delays are always just under 500ms, typically around 490ms. This makes listening to any music quite the horrible experience as PulseAudio constantly will attempt to rewind and catch up. It is not a great situation, and seems to me to quite clearly be a case where regular user space behaviour has been broken.

I want to note that this audio problem was not something I experienced until recently, it is therefore a new bug.

I have bisected the kernel to find out where the problem originated and found the following commit:

# first bad commit: [f5742ec36422a39b57f0256e4847f61b3c432f8c]
drm/amd/powerplay: correct power reading on fiji

This commit introduces a blocking delay (mdelay) of 500ms, whereas the old behaviour was a smaller blocking delay of only 1ms. This seems to me to be very curious as the scheduling delays of PulseAudio are always almost 500ms. I have therefore with the previous patch replaced the scheduling delay with a non-blocking sleep (msleep).

Quoted 8 lines

The results of the patch seems promising as I have yet to encounter any of the old <500ms scheduling delays when using it and I have also not encountered any kernel log messages regarding sleeping in an atomic context.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#3 lore raw
In reply to Yrjan Skrimstad
Quoted 39 lines · Yrjan Skrimstad
Quoted 4 lines · Yrjan Skrimstad

This driver currently contains a repeated 500ms blocking delay call which causes frequent major buffer underruns in PulseAudio. This patch fixes this issue by replacing the blocking delay with a non-blocking sleep call.

I see that I have not explained this bug well enough, and I hope that is the reason for the lack of replies on this patch. I will here attempt to explain the situation better.

To start with some hardware description I am here using an AMD R9 380 GPU, an AMD Ryzen 7 1700 Eight-Core Processor and an AMD X370 chipset. If any more hardware or software specifications are necessary, please ask.

The bug is as follows: When playing audio I will regularly have major audio issues, similar to that of a skipping CD. This is reported by PulseAudio as scheduling delays and buffer underruns when running PulseAudio verbosely and these scheduling delays are always just under 500ms, typically around 490ms. This makes listening to any music quite the horrible experience as PulseAudio constantly will attempt to rewind and catch up. It is not a great situation, and seems to me to quite clearly be a case where regular user space behaviour has been broken.

I want to note that this audio problem was not something I experienced until recently, it is therefore a new bug.

I have bisected the kernel to find out where the problem originated and found the following commit:

# first bad commit: [f5742ec36422a39b57f0256e4847f61b3c432f8c] drm/amd/powerplay: correct power reading on fiji

This commit introduces a blocking delay (mdelay) of 500ms, whereas the old behaviour was a smaller blocking delay of only 1ms. This seems to me to be very curious as the scheduling delays of PulseAudio are always almost 500ms. I have therefore with the previous patch replaced the scheduling delay with a non-blocking sleep (msleep).

Quoted 4 lines

The results of the patch seems promising as I have yet to encounter any of the old <500ms scheduling delays when using it and I have also not encountered any kernel log messages regarding sleeping in an atomic context.

The patch is fine and I can apply it (I don't think there are any restrictions on sleeping in sysfs), but this code only gets executed when you actually read the power status from the card (e.g., via sysfs or debugfs). Presumably you have something in userspace polling one of those files on a regular basis?

Alex
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

#4 lore raw
Quoted 7 lines · Alex Deucher

The patch is fine and I can apply it (I don't think there are any restrictions on sleeping in sysfs), but this code only gets executed when you actually read the power status from the card (e.g., via sysfs or debugfs). Presumably you have something in userspace polling one of those files on a regular basis?

Alex

That is an interesting observation to me. I am actually running lm-sensors, although only every 15 seconds. I suppose that this might be the reason this happens to me.

- Yrjan
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

#5 lore raw
Quoted 3 lines · Yrjan Skrimstad

That is an interesting observation to me. I am actually running lm-sensors, although only every 15 seconds. I suppose that this might be the reason this happens to me.

Though I don't think this should reasonably cause problems with the system, even if it does here. Is there an update on the status of this patch?

- Yrjan
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Applied
#6 lore raw
Quoted 9 lines · Yrjan Skrimstad
Quoted 3 lines · Yrjan Skrimstad

That is an interesting observation to me. I am actually running lm-sensors, although only every 15 seconds. I suppose that this might be the reason this happens to me.

Though I don't think this should reasonably cause problems with the system, even if it does here. Is there an update on the status of this patch?

Applied. sorry for the delay.

Alex
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel