drm/panel-simple: Add panel parameters for ortustech-com37h3m05dtc/99dtc and sharp-lq070y3dg3b
Subsystems (3)
v2 cover drm/panel-simple: Add panel parameters for ortustech-com37h3m05dtc/99dtc and sharp-lq070y3dg3b
V2:
* fix typo in 99dtc panel compatible string (reported by [email protected])
V1:
Since v5.2-rc1 OMAP is no longer using a special display driver architecture for DPI panels, but uses the general drm/panel/panel-simple.
So we finally can add SoC independent panel definitions for two panel models which we already had worked on quite a while ago (before device tree was introduced):
https://patchwork.kernel.org/patch/2851295/
H. Nikolaus Schaller (2):
drm/panel: simple: Add Sharp LQ070Y3DG3B panel support drm/panel: simple: Add Ortustech COM37H3M panel support
drivers/gpu/drm/panel/panel-simple.c | 63 ++++++++++++++++++++++++++++ 1 file changed, 63 insertions(+)
Signature · 1 line
2.19.1
PATCH v2 1/2 drm/panel: simple: Add Sharp LQ070Y3DG3B panel support
The change adds support for the Sharp LQ070Y3DG3B 7.0" TFT LCD panel.
Tested on Letux7004.
--- drivers/gpu/drm/panel/panel-simple.c | 30 ++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +30 -0
@@ -2204,6 +2204,33 @@ static const struct panel_desc samsung_ltn140at29_301 = { }, }; +static const struct drm_display_mode sharp_lq070y3dg3b_mode = { + .clock =33260 , + .hdisplay =800 , + .hsync_start =800 +64 , + .hsync_end =800 +64 +128 , + .htotal =800 +64 +128 +64 , + .vdisplay =480 , + .vsync_start =480 +8 , + .vsync_end =480 +8 +2 , + .vtotal =480 +8 +2 +35 , + .vrefresh =60 , + .flags =DISPLAY_FLAGS_PIXDATA_POSEDGE , +}; + +static const struct panel_desc sharp_lq070y3dg3b = { + .modes = &sharp_lq070y3dg3b_mode, + .num_modes =1 , + .bpc =8 , + .size = { + .width =152 ,/* 152.4mm */ + .height =91 ,/* 91.4mm */ + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X24 , + .bus_flags =DRM_BUS_FLAG_DE_HIGH |DRM_BUS_FLAG_PIXDATA_POSEDGE | +DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE , +}; +static const struct drm_display_mode sharp_lq035q7db03_mode = { .clock =5500 , .hdisplay =240 ,
@@ -2786,6 +2813,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "sharp,lq035q7db03", .data = &sharp_lq035q7db03, + }, { + .compatible = "sharp,lq070y3dg3b", + .data = &sharp_lq070y3dg3b, }, { .compatible = "sharp,lq101k1ly04", .data = &sharp_lq101k1ly04,
Signature · 1 line
2.19.1
PATCH v2 2/2 drm/panel: simple: Add Ortustech COM37H3M panel support
In reply to H. Nikolaus SchallerThe change adds support for the Ortustech COM37H3M05DTC/99DTC 3.7" TFT LCD panel.
Tested on Letux3704.
--- drivers/gpu/drm/panel/panel-simple.c | 33 ++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +33 -0
@@ -2007,6 +2007,33 @@ static const struct panel_desc ontat_yx700wv03 = { .bus_format = MEDIA_BUS_FMT_RGB666_1X18, }; +static const struct drm_display_mode ortustech_com37h3m_mode = { + .clock =22153 , + .hdisplay =480 , + .hsync_start =480 +8 , + .hsync_end =480 +8 +10 , + .htotal =480 +8 +10 +10 , + .vdisplay =640 , + .vsync_start =640 +4 , + .vsync_end =640 +4 +3 , + .vtotal =640 +4 +3 +4 , + .vrefresh =60 , + .flags =DRM_MODE_FLAG_NVSYNC |DRM_MODE_FLAG_NHSYNC , +}; + +static const struct panel_desc ortustech_com37h3m = { + .modes = &ortustech_com37h3m_mode, + .num_modes =1 , + .bpc =8 , + .size = { + .width =56 ,/* 56.16mm */ + .height =75 ,/* 74.88mm */ + }, + .bus_format =MEDIA_BUS_FMT_RGB888_1X24 , + .bus_flags =DRM_BUS_FLAG_DE_HIGH |DRM_BUS_FLAG_PIXDATA_POSEDGE | +DRM_BUS_FLAG_SYNC_DRIVE_POSEDGE , +}; +static const struct drm_display_mode ortustech_com43h4m85ulc_mode = { .clock =25000 , .hdisplay =480 ,
@@ -2786,6 +2813,12 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "ontat,yx700wv03", .data = &ontat_yx700wv03, + }, { + .compatible = "ortustech,com37h3m05dtc", + .data = &ortustech_com37h3m, + }, { + .compatible = "ortustech,com37h3m99dtc", + .data = &ortustech_com37h3m, }, { .compatible = "ortustech,com43h4m85ulc", .data = &ortustech_com43h4m85ulc,
Signature · 1 line
2.19.1
Hi Nikolaus.
Thanks for the new panel patches.
Quoted 12 lines · H. Nikolaus Schaller
V2:
* fix typo in 99dtc panel compatible string (reported by [email protected])V1:
Since v5.2-rc1 OMAP is no longer using a special display driver architecture for DPI panels, but uses the general drm/panel/panel-simple.
So we finally can add SoC independent panel definitions for two panel models which we already had worked on quite a while ago (before device tree was introduced):
Quoted 7 lines
https://patchwork.kernel.org/patch/2851295/H. Nikolaus Schaller (2):
drm/panel: simple: Add Sharp LQ070Y3DG3B panel support drm/panel: simple: Add Ortustech COM37H3M panel support
All three panels are missing binding documentation. Please submit binding documentation, in separate patches, with proper "dt-bindings: xxx" subjects.
See Documentation/device-tree/bindings/submitting...
Patches not applied due to the missing docs.
But the patches itself looked good.
You have specified bus_flags etc, and added the
new entries in correct alphabetical order etc.
Sam
Hi Sam,
Quoted 22 lines
Am 05.06.2019 um 10:29 schrieb Sam Ravnborg <[email protected]>:
Hi Nikolaus.
Thanks for the new panel patches.
Quoted 16 lines · H. Nikolaus Schaller
V2:
* fix typo in 99dtc panel compatible string (reported by [email protected])V1:
Since v5.2-rc1 OMAP is no longer using a special display driver architecture for DPI panels, but uses the general drm/panel/panel-simple.
So we finally can add SoC independent panel definitions for two panel models which we already had worked on quite a while ago (before device tree was introduced):
https://patchwork.kernel.org/patch/2851295/
Quoted 8 lines
Quoted 3 lines
H. Nikolaus Schaller (2):
drm/panel: simple: Add Sharp LQ070Y3DG3B panel support drm/panel: simple: Add Ortustech COM37H3M panel supportAll three panels are missing binding documentation. Please submit binding documentation, in separate patches, with proper "dt-bindings: xxx" subjects.
SeeDocumentation/device-tree/bindings/submitting...
Ah, ok. Yes, will add to v3 asap.
Quoted 7 lines
Patches not applied due to the missing docs.
But the patches itself looked good.
You have specifiedbus_flagsetc, and added the
new entries in correct alphabetical order etc.Sam
BR and thanks,
Nikolaus