Skip to contentSkip to conversation

USB: omap_udc: Remove unneeded variable

PATCH New Hariprasad Kelam 1 participant 1 message Jun 5, 2019 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB: omap_udc: Remove unneeded variable

With the current implementation omap_udc_stop is always returning -ENODEV.

Added changes to return 0 and remove variable status.

Issue identified with coccicheck drivers/usb/gadget/udc/omap_udc.c:2106:6-12:
Unneeded variable: "status". Return "- ENODEV" on line 2128

---
 drivers/usb/gadget/udc/omap_udc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/gadget/udc/omap_udc.c +1 -2
index fcf13ef..f36f073 100644
@@ -2103,7 +2103,6 @@ static int omap_udc_start(struct usb_gadget *g,
 static int omap_udc_stop(struct usb_gadget *g)
 {
 	unsigned long	flags;
-	int		status = -ENODEV;
 
 	if (udc->dc_clk != NULL)
 		omap_udc_enable_clock(1);
@@ -2125,7 +2124,7 @@ static int omap_udc_stop(struct usb_gadget *g)
 	if (udc->dc_clk != NULL)
 		omap_udc_enable_clock(0);
 
-	return status;
+	return 0;
 }
 
 /*-------------------------------------------------------------------------*/
Signature · 1 line
2.7.4