Skip to contentSkip to conversation

rtc: tegra: Drop MODULE_ALIAS

PATCH Applied Dmitry Osipenko 3 participants 4 messages Jun 5, 2019 – Jun 7, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtc: tegra: Drop MODULE_ALIAS

RTC driver was converted to OF driver long time ago. The MODULE_ALIAS macro has no effect for the OF drivers since the alias is overridden by the drivers core to follow the OF naming convention of the driver's alias, which is based on the device-tree matching name.

$ cat /sys/devices/soc0/7000e000.rtc/modalias
of:NrtcT(null)Cnvidia,tegra20-rtc
---
 drivers/rtc/rtc-tegra.c | 1 -
 1 file changed, 1 deletion(-)
drivers/rtc/rtc-tegra.c +0 -1
index 8bbaea24926e..8fa1b3febf69 100644
@@ -419,5 +419,4 @@ module_platform_driver(tegra_rtc_driver);
 
 MODULE_AUTHOR("Jon Mayo <[email protected]>");
 MODULE_DESCRIPTION("driver for Tegra internal RTC");
-MODULE_ALIAS("platform:tegra_rtc");
 MODULE_LICENSE("GPL");
Signature · 1 line
2.21.0
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Dmitry Osipenko

RTC driver was converted to OF driver long time ago. The MODULE_ALIAS macro has no effect for the OF drivers since the alias is overridden by the drivers core to follow the OF naming convention of the driver's alias, which is based on the device-tree matching name.

Quoted 7 lines
$ cat /sys/devices/soc0/7000e000.rtc/modalias
of:NrtcT(null)Cnvidia,tegra20-rtc
---
 drivers/rtc/rtc-tegra.c | 1 -
 1 file changed, 1 deletion(-)
#2 lore raw

05.06.2019 15:33, Thierry Reding пишет:

Quoted 9 lines · Dmitry Osipenko
Quoted 8 lines

RTC driver was converted to OF driver long time ago. The MODULE_ALIAS macro has no effect for the OF drivers since the alias is overridden by the drivers core to follow the OF naming convention of the driver's alias, which is based on the device-tree matching name.

$ cat /sys/devices/soc0/7000e000.rtc/modalias
of:NrtcT(null)Cnvidia,tegra20-rtc
Quoted 7 lines
Quoted 4 lines
---
 drivers/rtc/rtc-tegra.c | 1 -
 1 file changed, 1 deletion(-)

Thanks!

maintainer Applied
#3 lore raw
In reply to Dmitry Osipenko
Quoted 5 lines · Dmitry Osipenko

RTC driver was converted to OF driver long time ago. The MODULE_ALIAS macro has no effect for the OF drivers since the alias is overridden by the drivers core to follow the OF naming convention of the driver's alias, which is based on the device-tree matching name.

Quoted 8 lines
$ cat /sys/devices/soc0/7000e000.rtc/modalias
of:NrtcT(null)Cnvidia,tegra20-rtc
---
 drivers/rtc/rtc-tegra.c | 1 -
 1 file changed, 1 deletion(-)

Applied, thanks.

Signature · 3 lines
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com