Skip to contentSkip to conversation

net: fec_ptp: Use dev_err() instead of pr_err()

PATCH Applied Fabio Estevam 2 participants 2 messages Jun 5, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 net: fec_ptp: Use dev_err() instead of pr_err()

dev_err() is more appropriate for printing error messages inside drivers, so switch to dev_err().

---
Changes since v2:
- Made it a standalone patch
- Collected Andy's Ack

 drivers/net/ethernet/freescale/fec_ptp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/fec_ptp.c +1 -1
index 7e892b1cbd3d..19e2365be7d8 100644
@@ -617,7 +617,7 @@ void fec_ptp_init(struct platform_device *pdev, int irq_idx)
 	fep->ptp_clock = ptp_clock_register(&fep->ptp_caps, &pdev->dev);
 	if (IS_ERR(fep->ptp_clock)) {
 		fep->ptp_clock = NULL;
-		pr_err("ptp_clock_register failed\n");
+		dev_err(&pdev->dev, "ptp_clock_register failed\n");
 	}
 
 	schedule_delayed_work(&fep->time_keep, HZ);
Signature · 1 line
2.17.1