Skip to contentSkip to conversation

iotests: restrict 254 to support only qcow2

PATCH Applied Vladimir Sementsov-Ogievskiy 2 participants 2 messages Jun 5, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iotests: restrict 254 to support only qcow2

Test fails at least for qcow, because of different cluster sizes in base and top (and therefore different granularities of bitmaps we are trying to merge).

The test aim is to check block-dirty-bitmap-merge between different nodes functionality, no needs to check all formats. So, let's just drop support for anything except qcow2.

---
 tests/qemu-iotests/254 | 2 ++
 1 file changed, 2 insertions(+)
tests/qemu-iotests/254 +2 -0
index 33cb80a512..8edba91c5d 100755
@@ -21,6 +21,8 @@
 import iotests
 from iotests import qemu_img_create, file_path, log
 
+iotests.verify_image_format(supported_fmts=['qcow2'])
+
 disk, top = file_path('disk', 'top')
 size = 1024 * 1024
 
Signature · 1 line
2.18.0
Applied
#1 lore raw
Quoted 8 lines · Vladimir Sementsov-Ogievskiy

Test fails at least for qcow, because of different cluster sizes in base and top (and therefore different granularities of bitmaps we are trying to merge).

The test aim is to check block-dirty-bitmap-merge between different nodes functionality, no needs to check all formats. So, let's just drop support for anything except qcow2.

Quoted 5 lines
---
 tests/qemu-iotests/254 | 2 ++
 1 file changed, 2 insertions(+)

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max