Skip to contentSkip to conversation

revert async probing of VMBus network devices.

PATCH In review Stephen Hemminger 2 participants 3 messages Jun 5, 2019 – Jun 6, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 revert async probing of VMBus network devices.

Doing asynchronous probing can lead to reordered network device names. And because udev doesn't have any useful information to construct a persistent name, this causes VM's to sporadically boot with reordered device names and no connectivity.

This shows up on the Ubuntu image on larger VM's where 30% of the time eth0 and eth1 get swapped.

Note: udev MAC address policy is disabled on Azure images because the netvsc and PCI VF will have the same mac address.

Fixes af0a5646cb8d ("use the new async probing feature for the hyperv drivers")
---
 drivers/net/hyperv/netvsc_drv.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/hyperv/netvsc_drv.c +0 -3
index 06393b215102..1a2c32111106 100644
@@ -2411,9 +2411,6 @@ static struct  hv_driver netvsc_drv = {
 	.id_table = id_table,
 	.probe = netvsc_probe,
 	.remove = netvsc_remove,
-	.driver = {
-		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
-	},
 };
 
 /*
Signature · 1 line
2.20.1
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 19 lines

-----Original Message-----
From: [email protected] <linux-hyperv- [email protected]> On Behalf Of Stephen Hemminger
Sent: Wednesday, June 5, 2019 2:51 PM
To: [email protected]
Cc: [email protected]; Stephen Hemminger <[email protected]>
Subject: [PATCH] revert async probing of VMBus network devices.

Doing asynchronous probing can lead to reordered network device names. And because udev doesn't have any useful information to construct a persistent name, this causes VM's to sporadically boot with reordered device names and no connectivity.

This shows up on the Ubuntu image on larger VM's where 30% of the time eth0 and eth1 get swapped.

Quoted 7 lines

Note: udev MAC address policy is disabled on Azure images because the netvsc and PCI VF will have the same mac address.

Fixes af0a5646cb8d ("use the new async probing feature for the hyperv

drivers")

---

#2 lore raw
In reply to Stephen Hemminger
Quoted 22 lines · On Wed, 5 Jun 2019 11:51:14 -0700 Stephen Hemminger…

Doing asynchronous probing can lead to reordered network device names. And because udev doesn't have any useful information to construct a persistent name, this causes VM's to sporadically boot with reordered device names and no connectivity.

This shows up on the Ubuntu image on larger VM's where 30% of the time eth0 and eth1 get swapped.

Note: udev MAC address policy is disabled on Azure images because the netvsc and PCI VF will have the same mac address.

Fixes af0a5646cb8d ("use the new async probing feature for the hyperv drivers")
---
 drivers/net/hyperv/netvsc_drv.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/net/hyperv/netvsc_drv.c +0 -0
index 06393b215102..1a2c32111106 100644

drivers/net/hyperv/netvsc_drv.c static struct hv_driver netvsc_drv = { · line 2416

Quoted 9 lines
drivers/net/hyperv/netvsc_drv.c +0 -3
@@ -2411,9 +2411,6 @@ static struct  hv_driver netvsc_drv = {
 	.id_table = id_table,
 	.probe = netvsc_probe,
 	.remove = netvsc_remove,
-	.driver = {
-		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
-	},
 };
 
 /*

Even though storage can handle out of order devices, networking can not. The network devices in Hyper-V do not have any persistant properties that will work with existing udev. The current kernel is breaking current distributions. This patch fixes it, why did you reject it?