drm: actually remove the newline for CRC source name.
Subsystems (2)
PATCH 1/1 drm: actually remove the newline for CRC source name.
'n-1' is the index to replace the newline character of CRC source name.
--- drivers/gpu/drm/drm_debugfs_crc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_debugfs_crc.c +2 -2
@@ -131,8 +131,8 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf,if (IS_ERR (source))return PTR_ERR (source); -if (source[len] =='\n' ) - source[len] ='\0' ; +if (source[len-1 ] =='\n' ) + source[len-1 ] ='\0' ; ret = crtc->funcs->verify_crc_source (crtc, source, &values_cnt);if (ret)
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Dingchen.
Thanks for the quick follow-up.
Quoted 1 line · Dingchen Zhang
'n-1' is the index to replace the newline character of CRC source name.
subject is much better now.
It would be fine if the body of the changelog conveyed the same message. The body explains what the patch does, it is better to focus on why the patch does what is do.
So maybe a short explanation that userspace may transfer a newine, and that this terminating newline is replaced by a '\0' to avoid followup isses.
Quoted 3 lines
Cc Leo Li <[email protected]>Cc Harry Wentland<[email protected]>
Please add a space after the name, before the '<'. This is also suggested by checkpatch.pl.
Quoted 10 lines
Signed-off-by Dingchen Zhang <[email protected]>--- drivers/gpu/drm/drm_debugfs_crc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_debugfs_crc.c +0
-0
drivers/gpu/drm/drm_debugfs_crc.c static ssize_t crc_control_write(struct file *file, const char __user *ubuf, · line 135
Quoted 7 lines
drivers/gpu/drm/drm_debugfs_crc.c +2
-2@@ -131,8 +131,8 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf,if (IS_ERR (source))return PTR_ERR (source); -if (source[len] =='\n' ) - source[len] ='\0' ; +if (source[len-1 ] =='\n' ) + source[len-1 ] ='\0' ;
You did not add spaces around operators as requested.
Whith the above things fixed:
Quoted 10 lines
drivers/gpu/drm/drm_debugfs_crc.c +0
-0ret = crtc->funcs->verify_crc_source (crtc, source, &values_cnt);if (ret)Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Thanks for the quick follow-up to Sam.
Drop the word "actually" from the patch subject line.
It's generally helpful to generate a 2nd version of the patch with '-v 2', and to leave a description what v2 changed.
Also CC anyone who previously commented.
Quoted 2 lines · Dingchen Zhang
'n-1' is the index to replace the newline character of CRC source name.
Add here:
v2: Update patch subject (Sam)
Quoted 12 lines
Cc Leo Li <[email protected]>Cc Harry Wentland<[email protected]>Signed-off-by Dingchen Zhang <[email protected]>--- drivers/gpu/drm/drm_debugfs_crc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_debugfs_crc.c +0
-0
drivers/gpu/drm/drm_debugfs_crc.c static ssize_t crc_control_write(struct file *file, const char __user *ubuf, · line 136
Quoted 8 lines
drivers/gpu/drm/drm_debugfs_crc.c +2
-2@@ -131,8 +131,8 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf,if (IS_ERR (source))return PTR_ERR (source); -if (source[len] =='\n' ) - source[len] ='\0' ; +if (source[len-1 ] =='\n' ) + source[len-1 ] ='\0' ;
As Sam mentioned, you'll want this to be
+ if (source[len - 1] == '\n')
+ source[len - 1] = '\0';
I forgot to mention this to you before, but please run ./scripts/checkpatch.pl on your patches before sending them and fix up any errors or warnings.
Harry
drivers/gpu/drm/drm_debugfs_crc.c static ssize_t crc_control_write(struct file *file, const char __user *ubuf, · line 138
Quoted 3 lines
drivers/gpu/drm/drm_debugfs_crc.c +0
-0ret = crtc->funcs->verify_crc_source (crtc, source, &values_cnt);if (ret)
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel