Skip to contentSkip to conversation

enhance meson summary - list disabled components

PATCH Applied Bruce Richardson 3 participants 14 messages Jun 5, 2019 – Jul 2, 2019

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

cover enhance meson summary - list disabled components

After using meson to configure a build, we output a brief list of all components that are enabled. However, of more use to most users is a list of what is not being enabled, so that they can look for gaps and see about fixing those gaps, e.g. by installing driver dependencies.

This patchset adds such a printout at the end, but to make things easier, it also adds support for drivers adding a reason why they not being built, e.g. unsupported platform, or missing software dependency.

Example output from a FreeBSD platform, for which many drivers do not compile:

=================
Content Skipped
=================

libs:

        kni:    only supported on 64-bit linux
        power:  only supported on linux
        vhost:  only supported on linux

telemetry: missing dependency "jansson"

drivers:

        common/dpaax:   only supported on linux
        common/mvep:    missing dependency, "libmusdk"
        bus/dpaa:       only supported on linux
        bus/fslmc:      only supported on linux
        bus/vmbus:      only supported on linux
        mempool/dpaa:   only supported on linux
        mempool/dpaa2:  only supported on linux
        net/af_packet:  only supported on linux
        net/af_xdp:     missing dependency, "libbpf"
        net/avp:        only supported on linux
        net/axgbe:      only supported on linux
        net/dpaa:       only supported on linux
        net/dpaa2:      only supported on linux
        net/enetc:      only supported on linux
        net/ifc:        missing dependency, DPDK vhost library
        net/kni:        missing dependency, DPDK KNI library
        net/mlx4:       missing dependency, "ibverbs"
        net/mlx5:       missing dependency, "ibverbs"
        net/mvneta:     missing dependency, "libmusdk"
        net/mvpp2:      missing dependency, "libmusdk"
        net/netvsc:     missing dependency, DPDK VMBus driver
        net/nfb:        missing dependency, "libnfb"
        net/nfp:        only supported on 64-bit linux
        net/softnic:    only supported on linux
        net/szedata2:   missing dependency, "libsze2"
        net/tap:        only supported on linux

net/vdev_netvsc: only supported on linux
net/vhost: missing dependency, DPDK vhost library
crypto/aesni_gcm: missing dependency, "libIPSec_MB"
crypto/aesni_mb: missing dependency, "libIPSec_MB"
crypto/caam_jr: only supported on linux
crypto/ccp: missing dependency, "libcrypto"
crypto/dpaa_sec: only supported on linux
crypto/dpaa2_sec: only supported on linux
crypto/kasumi: missing dependency, "libsso_kasumi"
crypto/mvsam: missing dependency, "libmusdk"
crypto/octeontx: only supported on linux
crypto/openssl: missing dependency, "libcrypto" crypto/snow3g: missing dependency, "libsso_snow3g"
crypto/zuc: missing dependency, "libsso_zuc"
compress/isal: missing dependency, "libisal"
event/dpaa: only supported on linux
event/dpaa2: only supported on linux
raw/dpaa2_cmdif: missing dependency, DPDK DPAA2 mempool driver
raw/dpaa2_qdma: missing dependency, DPDK DPAA2 mempool driver
raw/ifpga_rawdev: missing dependency, "libfdt"

Bruce Richardson (10):
build: print list of disabled components for meson build
lib: add reasons for components being disabled drivers/bus: add reasons for components being disabled drivers/common: add reasons for components being disabled drivers/compress: add reasons for components being disabled drivers/crypto: add reasons for components being disabled drivers/event: add reasons for components being disabled drivers/mempool: add reasons for components being disabled drivers/net: add reasons for components being disabled drivers/raw: add reasons for components being disabled

 doc/guides/contributing/coding_style.rst | 15 ++++++++++++++-
 drivers/bus/dpaa/meson.build             |  3 ++-
 drivers/bus/fslmc/meson.build            |  3 ++-
 drivers/bus/vmbus/meson.build            |  1 +
 drivers/common/dpaax/meson.build         |  3 ++-
 drivers/common/mvep/meson.build          |  1 +
 drivers/common/qat/meson.build           |  1 +
 drivers/compress/isal/meson.build        |  3 ++-
 drivers/compress/zlib/meson.build        |  1 +
 drivers/crypto/aesni_gcm/meson.build     |  5 +++--
 drivers/crypto/aesni_mb/meson.build      |  5 +++--
 drivers/crypto/caam_jr/meson.build       |  3 ++-
 drivers/crypto/ccp/meson.build           |  4 +++-
 drivers/crypto/dpaa2_sec/meson.build     |  3 ++-
 drivers/crypto/dpaa_sec/meson.build      |  3 ++-
 drivers/crypto/kasumi/meson.build        |  1 +
 drivers/crypto/mvsam/meson.build         |  1 +
 drivers/crypto/octeontx/meson.build      |  1 +
 drivers/crypto/openssl/meson.build       |  1 +
 drivers/crypto/qat/meson.build           |  1 +
 drivers/crypto/snow3g/meson.build        |  1 +
 drivers/crypto/zuc/meson.build           |  1 +
 drivers/event/dpaa/meson.build           |  1 +
 drivers/event/dpaa2/meson.build          |  1 +
 drivers/mempool/dpaa/meson.build         |  3 ++-
 drivers/mempool/dpaa2/meson.build        |  3 ++-
 drivers/meson.build                      | 12 +++++++++++-
 drivers/net/af_packet/meson.build        |  1 +
 drivers/net/af_xdp/meson.build           |  1 +
 drivers/net/avp/meson.build              |  3 ++-
 drivers/net/axgbe/meson.build            |  1 +
 drivers/net/bnx2x/meson.build            |  1 +
 drivers/net/dpaa/meson.build             |  1 +
 drivers/net/dpaa2/meson.build            |  3 ++-
 drivers/net/enetc/meson.build            |  1 +
 drivers/net/ifc/meson.build              |  1 +
 drivers/net/kni/meson.build              |  1 +
 drivers/net/mlx4/meson.build             |  1 +
 drivers/net/mlx5/meson.build             |  1 +
 drivers/net/mvneta/meson.build           |  1 +
 drivers/net/mvpp2/meson.build            |  1 +
 drivers/net/netvsc/meson.build           |  1 +
 drivers/net/nfb/meson.build              |  1 +
 drivers/net/nfp/meson.build              |  3 ++-
 drivers/net/pcap/meson.build             |  1 +
 drivers/net/sfc/meson.build              |  1 +
 drivers/net/softnic/meson.build          |  3 ++-
 drivers/net/szedata2/meson.build         |  1 +
 drivers/net/tap/meson.build              |  3 ++-
 drivers/net/vdev_netvsc/meson.build      |  3 ++-
 drivers/net/vhost/meson.build            |  1 +
 drivers/raw/dpaa2_cmdif/meson.build      |  1 +
 drivers/raw/dpaa2_qdma/meson.build       |  1 +
 drivers/raw/ifpga_rawdev/meson.build     |  1 +
 lib/librte_kni/meson.build               |  1 +
 lib/librte_power/meson.build             |  1 +
 lib/librte_telemetry/meson.build         |  1 +
 lib/librte_vhost/meson.build             |  1 +
 lib/meson.build                          |  6 +++++-
 meson.build                              | 15 +++++++++++++++
 60 files changed, 122 insertions(+), 23 deletions(-)
Signature · 1 line
2.21.0
#1 lore raw

PATCH 1/10 build: print list of disabled components for meson build

When configuring with meson we print out a list of enabled components, but it is also useful to list out the disabled components and the reasons why.

---
 doc/guides/contributing/coding_style.rst | 15 ++++++++++++++-
 drivers/meson.build                      | 12 +++++++++++-
 lib/meson.build                          |  6 +++++-
 meson.build                              | 15 +++++++++++++++
 4 files changed, 45 insertions(+), 3 deletions(-)
doc/guides/contributing/coding_style.rst +14 -1
index a5d5897f3..449b33494 100644
@@ -852,12 +852,15 @@ allow_experimental_apis
 build
 	**Default Value = true**
 	Used to optionally compile a library, based on its dependencies or
-	environment. A simple example of use would be:
+	environment. When set to "false" the ``reason`` value, explained below, should
+	also be set to explain to the user why the component is not being built.
+	A simple example of use would be:
 
 .. code-block:: python
 
 	if not is_linux
 	        build = false
+	        reason = 'only supported on Linux'
 	endif
 
 
@@ -938,6 +941,13 @@ objs
 	objects that were compiled up as part of another target given in the
 	included library ``meson.build`` file.
 
+reason
+	**Default Value = '<unknown reason>'**.
+	This variable should be used when a library is not to be built i.e. when
+	``build`` is set to "false", to specify the reason why a library will not be
+	built. For missing dependencies this should be of the form
+	``'missing dependency, "libname"'``.
+
 version
 	**Default Value = 1**.
 	Specifies the ABI version of the library, and is used as the major
@@ -991,6 +1001,9 @@ pkgconfig_extra_libs
 	using static libraries. Anything added here will be appended to the end
 	of the ``pkgconfig --libs`` output.
 
+reason
+	As above.
+
 sources [mandatory]
 	As above
 
drivers/meson.build +11 -1
index 4c444f495..94e6c829e 100644
@@ -40,6 +40,7 @@ foreach class:dpdk_driver_classes
 
 		# set up empty variables used for build
 		build = true # set to false to disable, e.g. missing deps
+		reason = '<unknown reason>' # set if build == false to explain
 		name = drv
 		version = 1
 		allow_experimental_apis = false
@@ -61,7 +62,16 @@ foreach class:dpdk_driver_classes
 		# pull in driver directory which should assign to each of the above
 		subdir(drv_path)
 
-		if build
+		if not build
+			# some driver directories are placeholders which
+			# are never built, so we allow suppression of the
+			# component disable printout in those cases
+			if reason != ''
+				dpdk_drvs_disabled += drv_path
+				set_variable(drv_path.underscorify() +
+						'_disable_reason', reason)
+			endif
+		else
 			class_drivers += name
 
 			dpdk_conf.set(config_flag_fmt.format(name.to_upper()),1)
lib/meson.build +5 -1
index e067ce5ea..76c13b7da 100644
@@ -46,6 +46,7 @@ default_cflags += '-D_GNU_SOURCE'
 
 foreach l:libraries
 	build = true
+	reason = '<unknown reason>' # set if build == false to explain why
 	name = l
 	version = 1
 	allow_experimental_apis = false
@@ -68,7 +69,10 @@ foreach l:libraries
 	dir_name = 'librte_' + l
 	subdir(dir_name)
 
-	if build
+	if not build
+		dpdk_libs_disabled += name
+		set_variable(name.underscorify() + '_disable_reason', reason)
+	else
 		enabled_libs += name
 		dpdk_conf.set('RTE_LIBRTE_' + name.to_upper(), 1)
 		install_headers(headers)
meson.build +15 -0
index 9cad43481..63a1ce25b 100644
@@ -20,6 +20,8 @@ dpdk_driver_classes = []
 dpdk_drivers = []
 dpdk_extra_ldflags = []
 dpdk_app_link_libraries = []
+dpdk_libs_disabled = []
+dpdk_drvs_disabled = []
 
 # configure the build, and make sure configs here and in config folder are
 # able to be included in any file. We also store a global array of include dirs
@@ -108,3 +110,16 @@ foreach class:dpdk_driver_classes
 	endforeach
 endforeach
 message(output_message + '\n')
+
+output_message = '\n=================\nContent Skipped\n=================\n'
+output_message += '\nlibs:\n\t'
+foreach lib:dpdk_libs_disabled
+	reason = get_variable(lib.underscorify() + '_disable_reason')
+	output_message += lib + ':\t' + reason + '\n\t'
+endforeach
+output_message += '\ndrivers:\n\t'
+foreach drv:dpdk_drvs_disabled
+	reason = get_variable(drv.underscorify() + '_disable_reason')
+	output_message += drv + ':\t' + reason + '\n\t'
+endforeach
+message(output_message + '\n')
Signature · 1 line
2.21.0
#2 lore raw

PATCH 2/10 lib: add reasons for components being disabled

In reply to Bruce Richardson

For each library where we optionally disable it, add in the reason why it's being disabled, so the user knows how to fix it.

---
 lib/librte_kni/meson.build       | 1 +
 lib/librte_power/meson.build     | 1 +
 lib/librte_telemetry/meson.build | 1 +
 lib/librte_vhost/meson.build     | 1 +
 4 files changed, 4 insertions(+)
lib/librte_kni/meson.build +1 -0
index 400af9a4d..41fa2e39b 100644
@@ -3,6 +3,7 @@
 
 if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
+	reason = 'only supported on 64-bit linux'
 endif
 version = 2
 sources = files('rte_kni.c')
lib/librte_power/meson.build +1 -0
index cc6c30075..cdf08f6df 100644
@@ -3,6 +3,7 @@
 
 if not is_linux
 	build = false
+	reason = 'only supported on linux'
 endif
 sources = files('rte_power.c', 'power_acpi_cpufreq.c',
 		'power_kvm_vm.c', 'guest_channel.c',
lib/librte_telemetry/meson.build +1 -0
index cafb26f08..3e7db4f19 100644
@@ -12,4 +12,5 @@ if jansson.found()
 	dpdk_app_link_libraries += ['telemetry']
 else
 	build = false
+	reason = 'missing dependency "jansson"'
 endif
lib/librte_vhost/meson.build +1 -0
index 3090bbe08..cb1123ae3 100644
@@ -3,6 +3,7 @@
 
 if not is_linux
 	build = false
+	reason = 'only supported on linux'
 endif
 if has_libnuma == 1
 	dpdk_conf.set10('RTE_LIBRTE_VHOST_NUMA', true)
Signature · 1 line
2.21.0
#3 lore raw

PATCH 3/10 drivers/bus: add reasons for components being disabled

In reply to Bruce Richardson

For each driver where we optionally disable it, add in the reason why it's being disabled, so the user knows how to fix it.

---
 drivers/bus/dpaa/meson.build  | 3 ++-
 drivers/bus/fslmc/meson.build | 3 ++-
 drivers/bus/vmbus/meson.build | 1 +
 3 files changed, 5 insertions(+), 2 deletions(-)
drivers/bus/dpaa/meson.build +2 -1
index 1c8ca8c9a..19daaa5b5 100644
@@ -4,7 +4,8 @@
 version = 2
 
 if not is_linux
-        build = false
+	build = false
+	reason = 'only supported on linux'
 endif
 
 deps += ['common_dpaax', 'eventdev']
drivers/bus/fslmc/meson.build +2 -1
index 04624c363..faebc4327 100644
@@ -4,7 +4,8 @@
 version = 2
 
 if not is_linux
-        build = false
+	build = false
+	reason = 'only supported on linux'
 endif
 
 deps += ['common_dpaax', 'eventdev', 'kvargs']
drivers/bus/vmbus/meson.build +1 -0
index 9fd430dae..79d4c685e 100644
@@ -17,4 +17,5 @@ if is_linux
 	includes += include_directories('linux')
 else
 	build = false
+	reason = 'only supported on linux'
 endif
Signature · 1 line
2.21.0
#4 lore raw

PATCH 4/10 drivers/common: add reasons for components being disabled

In reply to Bruce Richardson

For each driver where we optionally disable it, add in the reason why it's being disabled, so the user knows how to fix it.

---
 drivers/common/dpaax/meson.build | 3 ++-
 drivers/common/mvep/meson.build  | 1 +
 drivers/common/qat/meson.build   | 1 +
 3 files changed, 4 insertions(+), 1 deletion(-)
drivers/common/dpaax/meson.build +2 -1
index 78378e2a6..a315e7786 100644
@@ -4,7 +4,8 @@
 allow_experimental_apis = true
 
 if not is_linux
-        build = false
+	build = false
+	reason = 'only supported on linux'
 endif
 
 sources = files('dpaax_iova_table.c')
drivers/common/mvep/meson.build +1 -0
index 8ccfacb3f..8df4bc6e0 100644
@@ -10,6 +10,7 @@ inc_dir = path + '/include'
 lib = cc.find_library('libmusdk', dirs: [lib_dir], required: false)
 if not lib.found()
 	build = false
+	reason = 'missing dependency, "libmusdk"'
 else
 	ext_deps += lib
 	includes += include_directories(inc_dir)
drivers/common/qat/meson.build +1 -0
index 80b6b25a8..8de249289 100644
@@ -4,6 +4,7 @@
 # This does not build a driver, but instead holds common files for
 # the crypto and compression drivers.
 build = false
+reason = '' # sentinal value to suppress printout
 qat_deps = ['bus_pci']
 qat_sources = files('qat_common.c',
 		'qat_qp.c',
Signature · 1 line
2.21.0
#5 lore raw

PATCH 5/10 drivers/compress: add reasons for components being disabled

In reply to Bruce Richardson

For each driver where we optionally disable it, add in the reason why it's being disabled, so the user knows how to fix it.

---
 drivers/compress/isal/meson.build | 3 ++-
 drivers/compress/zlib/meson.build | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
drivers/compress/isal/meson.build +2 -1
index 94c10fd60..67b5c4aae 100644
@@ -3,7 +3,8 @@
 
 dep = dependency('libisal', required: false)
 if not dep.found()
-       build =false
+	build = false
+	reason = 'missing dependency, "libisal"'
 endif
 
 deps += 'bus_vdev'
drivers/compress/zlib/meson.build +1 -0
index b036703c7..b1328c535 100644
@@ -4,6 +4,7 @@
 dep = dependency('zlib', required: false)
 if not dep.found()
 	build = false
+	reason = 'missing dependency, "zlib"'
 endif
 
 deps += 'bus_vdev'
Signature · 1 line
2.21.0
#6 lore raw

PATCH 6/10 drivers/crypto: add reasons for components being disabled

In reply to Bruce Richardson

For each driver where we optionally disable it, add in the reason why it's being disabled, so the user knows how to fix it.

---
 drivers/crypto/aesni_gcm/meson.build | 5 +++--
 drivers/crypto/aesni_mb/meson.build  | 5 +++--
 drivers/crypto/caam_jr/meson.build   | 3 ++-
 drivers/crypto/ccp/meson.build       | 4 +++-
 drivers/crypto/dpaa2_sec/meson.build | 3 ++-
 drivers/crypto/dpaa_sec/meson.build  | 3 ++-
 drivers/crypto/kasumi/meson.build    | 1 +
 drivers/crypto/mvsam/meson.build     | 1 +
 drivers/crypto/octeontx/meson.build  | 1 +
 drivers/crypto/openssl/meson.build   | 1 +
 drivers/crypto/qat/meson.build       | 1 +
 drivers/crypto/snow3g/meson.build    | 1 +
 drivers/crypto/zuc/meson.build       | 1 +
 13 files changed, 22 insertions(+), 8 deletions(-)
drivers/crypto/aesni_gcm/meson.build +3 -2
index 7183cfcba..3a6e332dc 100644
@@ -5,6 +5,7 @@ IMB_required_ver = '0.52.0'
 lib = cc.find_library('IPSec_MB', required: false)
 if not lib.found()
 	build = false
+	reason = 'missing dependency, "libIPSec_MB"'
 else
 	ext_deps += lib
 
@@ -13,8 +14,8 @@ else
 		prefix : '#include<intel-ipsec-mb.h>').split('"')[1]
 
 	if (imb_ver == '') or (imb_ver.version_compare('<' + IMB_required_ver))
-		message('IPSec_MB version >= @0@ is required, found version @1@'.format(
-				IMB_required_ver, imb_ver))
+		reason = 'IPSec_MB version >= @0@ is required, found version @1@'.format(
+				IMB_required_ver, imb_ver)
 		build = false
 	endif
 endif
drivers/crypto/aesni_mb/meson.build +3 -2
index 7c1eb3f86..3e1687416 100644
@@ -5,6 +5,7 @@ IMB_required_ver = '0.52.0'
 lib = cc.find_library('IPSec_MB', required: false)
 if not lib.found()
 	build = false
+	reason = 'missing dependency, "libIPSec_MB"'
 else
 	ext_deps += lib
 
@@ -13,8 +14,8 @@ else
 		prefix : '#include<intel-ipsec-mb.h>').split('"')[1]
 
 	if (imb_ver == '') or (imb_ver.version_compare('<' + IMB_required_ver))
-		message('IPSec_MB version >= @0@ is required, found version @1@'.format(
-				IMB_required_ver, imb_ver))
+		reason = 'IPSec_MB version >= @0@ is required, found version @1@'.format(
+				IMB_required_ver, imb_ver)
 		build = false
 	endif
 
drivers/crypto/caam_jr/meson.build +2 -1
index e61a13c25..4c66dd844 100644
@@ -2,7 +2,8 @@
 # Copyright 2018 NXP
 
 if not is_linux
-        build = false
+	build = false
+	reason = 'only supported on linux'
 endif
 
 deps += ['bus_vdev', 'bus_dpaa', 'security']
drivers/crypto/ccp/meson.build +3 -1
index 071ccc5e7..6f7217adb 100644
@@ -2,11 +2,13 @@
 # Copyright(c) 2018 Advanced Micro Devices, Inc. All rights reserved.
 
 if not is_linux
-        build = false
+	build = false
+	reason = 'only supported on linux'
 endif
 dep = dependency('libcrypto', required: false)
 if not dep.found()
 	build = false
+	reason = 'missing dependency, "libcrypto"'
 endif
 deps += 'bus_vdev'
 deps += 'bus_pci'
drivers/crypto/dpaa2_sec/meson.build +2 -1
index d197cda1a..23affa8a6 100644
@@ -4,7 +4,8 @@
 version = 2
 
 if not is_linux
-        build = false
+	build = false
+	reason = 'only supported on linux'
 endif
 
 deps += ['security', 'mempool_dpaa2']
drivers/crypto/dpaa_sec/meson.build +2 -1
index 134af88da..7b9a019b9 100644
@@ -2,7 +2,8 @@
 # Copyright 2018 NXP
 
 if not is_linux
-        build = false
+	build = false
+	reason = 'only supported on linux'
 endif
 
 deps += ['bus_dpaa', 'security']
drivers/crypto/kasumi/meson.build +1 -0
index 0fa301740..90a3c4fe6 100644
@@ -4,6 +4,7 @@
 lib = cc.find_library('sso_kasumi', required: false)
 if not lib.found() or not cc.has_header('sso_kasumi.h')
 	build = false
+	reason = 'missing dependency, "libsso_kasumi"'
 	subdir_done()
 endif
 
drivers/crypto/mvsam/meson.build +1 -0
index f1c879663..6d97dc8a2 100644
@@ -10,6 +10,7 @@ inc_dir = path + '/include'
 lib = cc.find_library('libmusdk', dirs: [lib_dir], required: false)
 if not lib.found()
 	build = false
+	reason = 'missing dependency, "libmusdk"'
 else
 	ext_deps += lib
 	includes += include_directories(inc_dir)
drivers/crypto/octeontx/meson.build +1 -0
index a9f2d3157..63a59c51a 100644
@@ -2,6 +2,7 @@
 # Copyright(c) 2018 Cavium, Inc
 if not is_linux
 	build = false
+	reason = 'only supported on linux'
 endif
 
 deps += ['bus_pci']
drivers/crypto/openssl/meson.build +1 -0
index d56a32366..394e74c9e 100644
@@ -4,6 +4,7 @@
 dep = dependency('libcrypto', required: false)
 if not dep.found()
 	build = false
+	reason = 'missing dependency, "libcrypto"'
 endif
 allow_experimental_apis = true
 deps += 'bus_vdev'
drivers/crypto/qat/meson.build +1 -0
index 710b081ff..fc65923a7 100644
@@ -4,6 +4,7 @@
 # this does not build the QAT driver, instead that is done in the compression
 # driver which comes later. Here we just add our sources files to the list
 build = false
+reason = '' # sentinal value to suppress printout
 dep = dependency('libcrypto', required: false)
 qat_includes += include_directories('.')
 qat_deps += 'cryptodev'
drivers/crypto/snow3g/meson.build +1 -0
index c566a5f67..0e8742ab9 100644
@@ -4,6 +4,7 @@
 lib = cc.find_library('sso_snow3g', required: false)
 if not lib.found() or not cc.has_header('sso_snow3g.h')
 	build = false
+	reason = 'missing dependency, "libsso_snow3g"'
 	subdir_done()
 endif
 
drivers/crypto/zuc/meson.build +1 -0
index fc2900244..b231de0ba 100644
@@ -4,6 +4,7 @@
 lib = cc.find_library('sso_zuc', required: false)
 if not lib.found() or not cc.has_header('sso_zuc.h')
 	build = false
+	reason = 'missing dependency, "libsso_zuc"'
 	subdir_done()
 endif
 
Signature · 1 line
2.21.0
#7 lore raw

PATCH 7/10 drivers/event: add reasons for components being disabled

In reply to Bruce Richardson

For each driver where we optionally disable it, add in the reason why it's being disabled, so the user knows how to fix it.

---
 drivers/event/dpaa/meson.build  | 1 +
 drivers/event/dpaa2/meson.build | 1 +
 2 files changed, 2 insertions(+)
drivers/event/dpaa/meson.build +1 -0
index 11b1fe669..c1e725475 100644
@@ -3,6 +3,7 @@
 
 if not is_linux
 	build = false
+	reason = 'only supported on linux'
 endif
 deps += ['pmd_dpaa']
 sources = files('dpaa_eventdev.c')
drivers/event/dpaa2/meson.build +1 -0
index a94bc5643..f7da7fad5 100644
@@ -5,6 +5,7 @@ version = 2
 
 if not is_linux
 	build = false
+	reason = 'only supported on linux'
 endif
 deps += ['bus_vdev', 'pmd_dpaa2', 'pmd_dpaa2_sec']
 sources = files('dpaa2_hw_dpcon.c',
Signature · 1 line
2.21.0
#8 lore raw

PATCH 8/10 drivers/mempool: add reasons for components being disabled

In reply to Bruce Richardson

For each driver where we optionally disable it, add in the reason why it's being disabled, so the user knows how to fix it.

---
 drivers/mempool/dpaa/meson.build  | 3 ++-
 drivers/mempool/dpaa2/meson.build | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
drivers/mempool/dpaa/meson.build +2 -1
index c4c8ebc09..b7446f174 100644
@@ -2,7 +2,8 @@
 # Copyright 2018 NXP
 
 if not is_linux
-        build = false
+	build = false
+	reason = 'only supported on linux'
 endif
 
 deps += ['bus_dpaa']
drivers/mempool/dpaa2/meson.build +2 -1
index 9a8b28d7c..3d25ba06d 100644
@@ -4,7 +4,8 @@
 version = 2
 
 if not is_linux
-        build = false
+	build = false
+	reason = 'only supported on linux'
 endif
 
 deps += ['bus_fslmc']
Signature · 1 line
2.21.0
#9 lore raw

PATCH 9/10 drivers/net: add reasons for components being disabled

In reply to Bruce Richardson

For each driver where we optionally disable it, add in the reason why it's being disabled, so the user knows how to fix it.

---
 drivers/net/af_packet/meson.build   | 1 +
 drivers/net/af_xdp/meson.build      | 1 +
 drivers/net/avp/meson.build         | 3 ++-
 drivers/net/axgbe/meson.build       | 1 +
 drivers/net/bnx2x/meson.build       | 1 +
 drivers/net/dpaa/meson.build        | 1 +
 drivers/net/dpaa2/meson.build       | 3 ++-
 drivers/net/enetc/meson.build       | 1 +
 drivers/net/ifc/meson.build         | 1 +
 drivers/net/kni/meson.build         | 1 +
 drivers/net/mlx4/meson.build        | 1 +
 drivers/net/mlx5/meson.build        | 1 +
 drivers/net/mvneta/meson.build      | 1 +
 drivers/net/mvpp2/meson.build       | 1 +
 drivers/net/netvsc/meson.build      | 1 +
 drivers/net/nfb/meson.build         | 1 +
 drivers/net/nfp/meson.build         | 3 ++-
 drivers/net/pcap/meson.build        | 1 +
 drivers/net/sfc/meson.build         | 1 +
 drivers/net/softnic/meson.build     | 3 ++-
 drivers/net/szedata2/meson.build    | 1 +
 drivers/net/tap/meson.build         | 3 ++-
 drivers/net/vdev_netvsc/meson.build | 3 ++-
 drivers/net/vhost/meson.build       | 1 +
 24 files changed, 30 insertions(+), 6 deletions(-)
drivers/net/af_packet/meson.build +1 -0
index 92c306c73..a7f392ea1 100644
@@ -3,5 +3,6 @@
 
 if not is_linux
 	build = false
+	reason = 'only supported on linux'
 endif
 sources = files('rte_eth_af_packet.c')
drivers/net/af_xdp/meson.build +1 -0
index 7904840f0..ac679b92b 100644
@@ -13,4 +13,5 @@ if bpf_dep.found() and cc.has_header('bpf/xsk.h') and cc.has_header('linux/if_xd
 	pkgconfig_extra_libs += '-lbpf'
 else
 	build = false
+	reason = 'missing dependency, "libbpf"'
 endif
drivers/net/avp/meson.build +2 -1
index 8138cb22d..a5f63cdef 100644
@@ -2,7 +2,8 @@
 # Copyright(c) 2018 Intel Corporation
 
 if not is_linux
-        build = false
+	build = false
+	reason = 'only supported on linux'
 endif
 sources = files('avp_ethdev.c')
 install_headers('rte_avp_common.h', 'rte_avp_fifo.h')
drivers/net/axgbe/meson.build +1 -0
index 6decb25d4..86873b7ef 100644
@@ -3,6 +3,7 @@
 
 if not is_linux
 	build = false
+	reason = 'only supported on linux'
 endif
 
 sources = files('axgbe_ethdev.c',
drivers/net/bnx2x/meson.build +1 -0
index dd189ffc4..4892bb234 100644
@@ -3,6 +3,7 @@
 
 dep = dependency('zlib', required: false)
 build = dep.found()
+reason = 'missing dependency, "zlib"'
 ext_deps += dep
 cflags += '-DZLIB_CONST'
 sources = files('bnx2x.c',
drivers/net/dpaa/meson.build +1 -0
index 8e5418bd6..94c0e22c5 100644
@@ -3,6 +3,7 @@
 
 if not is_linux
 	build = false
+	reason = 'only supported on linux'
 endif
 deps += ['mempool_dpaa']
 
drivers/net/dpaa2/meson.build +2 -1
index a0ea99238..7e74c656a 100644
@@ -4,7 +4,8 @@
 version = 2
 
 if not is_linux
-        build = false
+	build = false
+	reason = 'only supported on linux'
 endif
 
 deps += ['mempool_dpaa2']
drivers/net/enetc/meson.build +1 -0
index 7d0c2ffe7..3bc069844 100644
@@ -3,6 +3,7 @@
 
 if not is_linux
 	build = false
+	reason = 'only supported on linux'
 endif
 
 sources = files('enetc_ethdev.c',
drivers/net/ifc/meson.build +1 -0
index 72df070ac..adc9ed9ff 100644
@@ -2,6 +2,7 @@
 # Copyright(c) 2018 Intel Corporation
 
 build = dpdk_conf.has('RTE_LIBRTE_VHOST')
+reason = 'missing dependency, DPDK vhost library'
 allow_experimental_apis = true
 sources = files('ifcvf_vdpa.c', 'base/ifcvf.c')
 includes += include_directories('base')
drivers/net/kni/meson.build +1 -0
index e3b2d83b5..0539b4768 100644
@@ -3,5 +3,6 @@
 
 # this driver can be built if-and-only-if KNI library is buildable
 build = dpdk_conf.has('RTE_LIBRTE_KNI')
+reason = 'missing dependency, DPDK KNI library'
 sources = files('rte_eth_kni.c')
 deps += 'kni'
drivers/net/mlx4/meson.build +1 -0
index 2540489bb..5de04b70b 100644
@@ -25,6 +25,7 @@ foreach libname:libnames
 		libs += [ lib ]
 	else
 		build = false
+		reason = 'missing dependency, "' + libname + '"'
 	endif
 endforeach
 # Compile PMD
drivers/net/mlx5/meson.build +1 -0
index ac3b529d1..22ddd54c2 100644
@@ -25,6 +25,7 @@ foreach libname:libnames
 		libs += [ lib ]
 	else
 		build = false
+		reason = 'missing dependency, "' + libname + '"'
 	endif
 endforeach
 if build
drivers/net/mvneta/meson.build +1 -0
index c0b1bce01..8d7202788 100644
@@ -10,6 +10,7 @@ inc_dir = path + '/include'
 lib = cc.find_library('libmusdk', dirs : [lib_dir], required: false)
 if not lib.found()
 	build = false
+	reason = 'missing dependency, "libmusdk"'
 else
 	ext_deps += lib
 	includes += include_directories(inc_dir)
drivers/net/mvpp2/meson.build +1 -0
index 70ef2d642..e06eddaac 100644
@@ -10,6 +10,7 @@ inc_dir = path + '/include'
 lib = cc.find_library('libmusdk', dirs : [lib_dir], required: false)
 if not lib.found()
 	build = false
+	reason = 'missing dependency, "libmusdk"'
 else
 	ext_deps += lib
 	includes += include_directories(inc_dir)
drivers/net/netvsc/meson.build +1 -0
index c84269716..e9fe35344 100644
@@ -2,6 +2,7 @@
 # Copyright(c) 2018 Microsoft Corporation
 
 build = dpdk_conf.has('RTE_LIBRTE_VMBUS_BUS')
+reason = 'missing dependency, DPDK VMBus driver'
 version = 2
 sources = files('hn_ethdev.c', 'hn_rxtx.c', 'hn_rndis.c', 'hn_nvs.c', 'hn_vf.c')
 
drivers/net/nfb/meson.build +1 -0
index 457955d72..4502c3f76 100644
@@ -4,6 +4,7 @@
 # All rights reserved.
 
 dep = cc.find_library('nfb', required: false)
+reason = 'missing dependency, "libnfb"'
 
 build = dep.found() and cc.has_header('nfb/nfb.h', dependencies: dep)
 
drivers/net/nfp/meson.build +2 -1
index 8c87c5b0b..b487cdffd 100644
@@ -2,7 +2,8 @@
 # Copyright(c) 2018 Intel Corporation
 
 if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
-        build = false
+	build = false
+	reason = 'only supported on 64-bit linux'
 endif
 sources = files('nfpcore/nfp_cpp_pcie_ops.c',
 	'nfpcore/nfp_nsp.c',
drivers/net/pcap/meson.build +1 -0
index 2c2fd11e4..910dfab9b 100644
@@ -14,6 +14,7 @@ else
 		pkgconfig_extra_libs += '-lpcap'
 	else
 		build = false
+		reason = 'missing dependency, "libpcap"'
 	endif
 endif
 sources = files('rte_eth_pcap.c')
drivers/net/sfc/meson.build +1 -0
index e67560991..4fb0d0ac1 100644
@@ -8,6 +8,7 @@
 
 if arch_subdir != 'x86' or not dpdk_conf.get('RTE_ARCH_64')
 	build = false
+	reason = 'only supported on x86_64'
 endif
 
 allow_experimental_apis = true
drivers/net/softnic/meson.build +2 -1
index dd1d610ea..9c10c2ec8 100644
@@ -2,7 +2,8 @@
 # Copyright(c) 2018 Intel Corporation
 
 if not is_linux
-        build = false
+	build = false
+	reason = 'only supported on linux'
 endif
 allow_experimental_apis = true
 install_headers('rte_eth_softnic.h')
drivers/net/szedata2/meson.build +1 -0
index da3733743..032b42518 100644
@@ -3,5 +3,6 @@
 
 dep = cc.find_library('sze2', required: false)
 build = dep.found()
+reason = 'missing dependency, "libsze2"'
 ext_deps += dep
 sources = files('rte_eth_szedata2.c')
drivers/net/tap/meson.build +2 -1
index c407a1f35..baa70f756 100644
@@ -2,7 +2,8 @@
 # Copyright 2018 Luca Boccassi <[email protected]>
 
 if not is_linux
-        build = false
+	build = false
+	reason = 'only supported on linux'
 endif
 sources = files(
 	'rte_eth_tap.c',
drivers/net/vdev_netvsc/meson.build +2 -1
index 6655859f8..c82c5476c 100644
@@ -2,7 +2,8 @@
 # Copyright(c) 2018 Luca Boccassi <[email protected]>
 
 if not is_linux
-        build = false
+	build = false
+	reason = 'only supported on linux'
 endif
 sources = files('vdev_netvsc.c')
 
drivers/net/vhost/meson.build +1 -0
index 9b067c35e..9532a7605 100644
@@ -2,6 +2,7 @@
 # Copyright(c) 2018 Intel Corporation
 
 build = dpdk_conf.has('RTE_LIBRTE_VHOST')
+reason = 'missing dependency, DPDK vhost library'
 version = 2
 sources = files('rte_eth_vhost.c')
 install_headers('rte_eth_vhost.h')
Signature · 1 line
2.21.0
#10 lore raw

PATCH 10/10 drivers/raw: add reasons for components being disabled

In reply to Bruce Richardson

For each driver where we optionally disable it, add in the reason why it's being disabled, so the user knows how to fix it.

---
 drivers/raw/dpaa2_cmdif/meson.build  | 1 +
 drivers/raw/dpaa2_qdma/meson.build   | 1 +
 drivers/raw/ifpga_rawdev/meson.build | 1 +
 3 files changed, 3 insertions(+)
drivers/raw/dpaa2_cmdif/meson.build +1 -0
index 37bb24a1b..9ba1ae2de 100644
@@ -4,6 +4,7 @@
 version = 2
 
 build = dpdk_conf.has('RTE_LIBRTE_DPAA2_MEMPOOL')
+reason = 'missing dependency, DPDK DPAA2 mempool driver'
 deps += ['rawdev', 'mempool_dpaa2', 'bus_vdev']
 sources = files('dpaa2_cmdif.c')
 
drivers/raw/dpaa2_qdma/meson.build +1 -0
index 1577946fa..f70ade3b4 100644
@@ -4,6 +4,7 @@
 version = 2
 
 build = dpdk_conf.has('RTE_LIBRTE_DPAA2_MEMPOOL')
+reason = 'missing dependency, DPDK DPAA2 mempool driver'
 deps += ['rawdev', 'mempool_dpaa2', 'ring', 'kvargs']
 sources = files('dpaa2_qdma.c')
 
drivers/raw/ifpga_rawdev/meson.build +1 -0
index 132b77793..0ab6fd711 100644
@@ -9,6 +9,7 @@ objs = [base_objs]
 dep = dependency('libfdt', required: false)
 if not dep.found()
 	build = false
+	reason = 'missing dependency, "libfdt"'
 endif
 deps += ['rawdev', 'pci', 'bus_pci', 'kvargs',
 	'bus_vdev', 'bus_ifpga', 'net']
Signature · 1 line
2.21.0
#11 lore raw
In reply to Bruce Richardson
Quoted 9 lines · Bruce Richardson

After using meson to configure a build, we output a brief list of all components that are enabled. However, of more use to most users is a list of what is not being enabled, so that they can look for gaps and see about fixing those gaps, e.g. by installing driver dependencies.

This patchset adds such a printout at the end, but to make things easier, it also adds support for drivers adding a reason why they not being built, e.g. unsupported platform, or missing software dependency.

Signature · 2 lines
Kind regards,
Luca Boccassi
#12 lore raw
Quoted 6 lines · Luca Boccassi
Quoted 5 lines · Bruce Richardson

After using meson to configure a build, we output a brief list of all components that are enabled. However, of more use to most users is a list of what is not being enabled, so that they can look for gaps and see about fixing those gaps, e.g. by installing driver dependencies.

Quoted 7 lines
Quoted 4 lines

This patchset adds such a printout at the end, but to make things easier, it also adds support for drivers adding a reason why they not being built, e.g. unsupported platform, or missing software dependency.

Ping on this patchset. It's acked almost 2 weeks now, so can it be merged? [to get it off my "list-of-stuff-to-track"]

/Bruce

#13 lore raw
In reply to Luca Boccassi

05/06/2019 22:39, Luca Boccassi:

Quoted 6 lines · Bruce Richardson
Quoted 5 lines

After using meson to configure a build, we output a brief list of all components that are enabled. However, of more use to most users is a list of what is not being enabled, so that they can look for gaps and see about fixing those gaps, e.g. by installing driver dependencies.

Quoted 6 lines
Quoted 4 lines

This patchset adds such a printout at the end, but to make things easier, it also adds support for drivers adding a reason why they not being built, e.g. unsupported platform, or missing software dependency.

Applied, thanks