ARM: dts: imx53: Bind CPLD on M53Menlo
Subsystems (2)
PATCH v2 1/1 ARM: dts: imx53: Bind CPLD on M53Menlo
Enable ECSPI2 and bind CPLD to both chip selects.
To: [email protected]
---
V2: Drop fsl,spi-num-chipselects
--- arch/arm/boot/dts/imx53-m53menlo.dts | 30 ++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)
arch/arm/boot/dts/imx53-m53menlo.dts +30 -0
@@ -100,6 +100,25 @@ assigned-clock-rates = <133333334>, <33333334>, <33333334>; }; +&ecspi2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ecspi2>; + cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>, <&gpio2 27 GPIO_ACTIVE_HIGH>; + status = "okay"; + + spidev@0 { + compatible = "menlo,m53cpld", "spidev"; + spi-max-frequency = <25000000>; + reg = <0>; + }; + + spidev@1 { + compatible = "menlo,m53cpld", "spidev"; + spi-max-frequency = <25000000>; + reg = <1>; + }; +}; + &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>;
@@ -301,6 +320,17 @@ >; }; + pinctrl_ecspi2: ecspi2grp { + fsl,pins = < + MX53_PAD_EIM_CS0__ECSPI2_SCLK 0xe4 + MX53_PAD_EIM_OE__ECSPI2_MISO 0xe4 + MX53_PAD_EIM_CS1__ECSPI2_MOSI 0xe4 + + MX53_PAD_EIM_RW__GPIO2_26 0xe4 + MX53_PAD_EIM_LBA__GPIO2_27 0xe4 + >; + }; + pinctrl_esdhc1: esdhc1grp { fsl,pins = < MX53_PAD_SD1_DATA0__ESDHC1_DAT0 0x1e4
Signature · 7 lines
2.20.1 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 19 lines · Marek Vasut
Enable ECSPI2 and bind CPLD to both chip selects.
Signed-off-by Marek Vasut <[email protected]>Cc Shawn Guo <[email protected]>Cc Fabio Estevam <[email protected]>Cc NXP Linux Team <[email protected]>To: [email protected]
---
V2: Drop fsl,spi-num-chipselects--- arch/arm/boot/dts/imx53-m53menlo.dts | 30 ++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+)arch/arm/boot/dts/imx53-m53menlo.dts +0
-0@@ -100,6 +100,25 @@ assigned-clock-rates = <133333334>, <33333334>, <33333334>;
arch/arm/boot/dts/imx53-m53menlo.dts line 110
Quoted 10 lines
arch/arm/boot/dts/imx53-m53menlo.dts +8
-0}; +&ecspi2 { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_ecspi2>; + cs-gpios = <&gpio2 26 GPIO_ACTIVE_HIGH>, <&gpio2 27 GPIO_ACTIVE_HIGH>; + status = "okay"; + + spidev@0 { + compatible = "menlo,m53cpld", "spidev";
Don't you get the following warning from kernel?
OF: buggy DT: spidev listed directly in DT
Quoted 15 lines
arch/arm/boot/dts/imx53-m53menlo.dts +11
-0+ spi-max-frequency = <25000000>; + reg = <0>; + }; + + spidev@1 { + compatible = "menlo,m53cpld", "spidev"; + spi-max-frequency = <25000000>; + reg = <1>; + }; +}; + &esdhc1 { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_esdhc1>;
arch/arm/boot/dts/imx53-m53menlo.dts line 328
Quoted 9 lines
arch/arm/boot/dts/imx53-m53menlo.dts +6
-0@@ -301,6 +320,17 @@ >; }; + pinctrl_ecspi2: ecspi2grp { + fsl,pins = < + MX53_PAD_EIM_CS0__ECSPI2_SCLK 0xe4 + MX53_PAD_EIM_OE__ECSPI2_MISO 0xe4 + MX53_PAD_EIM_CS1__ECSPI2_MOSI 0xe4 +
Nit: unnecessary newline.
Shawn
Quoted 11 lines
arch/arm/boot/dts/imx53-m53menlo.dts +5
-0+ MX53_PAD_EIM_RW__GPIO2_26 0xe4 + MX53_PAD_EIM_LBA__GPIO2_27 0xe4 + >; + }; + pinctrl_esdhc1: esdhc1grp { fsl,pins = < MX53_PAD_SD1_DATA0__ESDHC1_DAT0 0x1e4Signature · 1 line
2.20.1
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Fabio Estevam
reviewerHi Shawn,
Quoted 3 lines · Shawn Guo
Don't you get the following warning from kernel?
OF: buggy DT: spidev listed directly in DT
I originally thought about that too, but then I saw this patch from Marek, which avoids the warning:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/spi/spidev.c?h=next-20190605&id=c6e2d2c7ca4e6d09bc07ab5ced2e687cc842a860
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Quoted 11 lines · Fabio Estevam
Hi Shawn,
Quoted 3 lines · Shawn Guo
Don't you get the following warning from kernel?
OF: buggy DT: spidev listed directly in DT
I originally thought about that too, but then I saw this patch from Marek, which avoids the warning:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/drivers/spi/spidev.c?h=next-20190605&id=c6e2d2c7ca4e6d09bc07ab5ced2e687cc842a860
Okay. Has compatible "menlo,m53cpld" been documented? Also my understanding is that as long as "spidev" is on the compatible list, we will see this warning, no?
Shawn
_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel