drivers: net: dsa: realtek: fix warning same module names
Subsystems (5)
PATCH 1/8 drivers: net: dsa: realtek: fix warning same module names
When building with CONFIG_NET_DSA_REALTEK_SMI and CONFIG_REALTEK_PHY enabled as loadable modules, we see the following warning:
warning: same module names found:
drivers/net/phy/realtek.ko
drivers/net/dsa/realtek.ko
Rework so the names matches the config fragment.
--- drivers/net/dsa/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/dsa/Makefile +2 -2
@@ -9,8 +9,8 @@ obj-$(CONFIG_NET_DSA_LANTIQ_GSWIP) += lantiq_gswip.o obj-$(CONFIG_NET_DSA_MT7530) += mt7530.o obj-$(CONFIG_NET_DSA_MV88E6060) += mv88e6060.o obj-$(CONFIG_NET_DSA_QCA8K) += qca8k.o -obj-$(CONFIG_NET_DSA_REALTEK_SMI) += realtek.o -realtek-objs := realtek-smi.o rtl8366.o rtl8366rb.o +obj-$(CONFIG_NET_DSA_REALTEK_SMI) += dsa-realtek-smi.o +dsa-realtek-smi-objs := realtek-smi.o rtl8366.o rtl8366rb.o obj-$(CONFIG_NET_DSA_SMSC_LAN9303) += lan9303-core.o obj-$(CONFIG_NET_DSA_SMSC_LAN9303_I2C) += lan9303_i2c.o obj-$(CONFIG_NET_DSA_SMSC_LAN9303_MDIO) += lan9303_mdio.o
Signature · 1 line
2.20.1
Andrew Lunn
maintainerQuoted 10 lines · Anders Roxell
When building with
CONFIG_NET_DSA_REALTEK_SMIandCONFIG_REALTEK_PHYenabled as loadable modules, we see the following warning:warning: same module names found:
drivers/net/phy/realtek.ko
drivers/net/dsa/realtek.koRework so the names matches the config fragment.
Signed-off-by Anders Roxell <[email protected]>
[Removes most of the Cc:]
Hi Anders
Please base this patch on net-next and submit it to David Miller/netdev.
It would also be nice to state the new name of the module in the commit message.
Linus, would you prefer this module is called rtl8366?
Andrew
Quoted 16 lines · Andrew Lunn
Quoted 10 lines · Anders Roxell
When building with
CONFIG_NET_DSA_REALTEK_SMIandCONFIG_REALTEK_PHYenabled as loadable modules, we see the following warning:warning: same module names found:
drivers/net/phy/realtek.ko
drivers/net/dsa/realtek.koRework so the names matches the config fragment.
Signed-off-by Anders Roxell <[email protected]>[Removes most of the Cc:]
Hi Anders
Quoted 7 lines
Please base this patch on net-next and submit it to David Miller/netdev.
It would also be nice to state the new name of the module in the commit message.
Linus, would you prefer this module is called rtl8366?
Yes that should be unique enough!
Anders: thanks for looking into this. I just always compiled all modules as y.
Yours,
Linus Walleij