drivers: media: coda: fix warning same module names
Subsystems (4)
PATCH 5/8 drivers: media: coda: fix warning same module names
When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as loadable modules, we see the following warning:
warning: same module names found:
fs/coda/coda.ko
drivers/media/platform/coda/coda.ko
Rework so media coda matches the config fragment. Leaving CODA_FS as is since thats a well known module.
--- drivers/media/platform/coda/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/platform/coda/Makefile +2 -2
@@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o -obj-$(CONFIG_VIDEO_CODA) += coda.o +obj-$(CONFIG_VIDEO_CODA) += video-coda.o obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o
Signature · 1 line
2.20.1
Quoted 20 lines · Anders Roxell
When building with
CONFIG_VIDEO_CODAandCONFIG_CODA_FSenabled as loadable modules, we see the following warning:warning: same module names found:
fs/coda/coda.ko
drivers/media/platform/coda/coda.koRework so media coda matches the config fragment. Leaving
CODA_FSas is since thats a well known module.Signed-off-by Anders Roxell <[email protected]>--- drivers/media/platform/coda/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/media/platform/coda/Makefile +0
-0
drivers/media/platform/coda/Makefile line 5
Quoted 7 lines
drivers/media/platform/coda/Makefile +2
-2@@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o -obj-$(CONFIG_VIDEO_CODA) += coda.o +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
How about imx-coda? video-coda suggests it is part of the video subsystem, which it isn't.
Regards,
Hans
Quoted 2 lines
drivers/media/platform/coda/Makefile +0
-0obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o
Quoted 24 lines · Hans Verkuil
Quoted 22 lines · Anders Roxell
When building with
CONFIG_VIDEO_CODAandCONFIG_CODA_FSenabled as loadable modules, we see the following warning:warning: same module names found:
fs/coda/coda.ko
drivers/media/platform/coda/coda.koRework so media coda matches the config fragment. Leaving
CODA_FSas is since thats a well known module.Signed-off-by Anders Roxell <[email protected]>--- drivers/media/platform/coda/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/media/platform/coda/Makefile +0
-0@@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only
Quoted 8 lines
drivers/media/platform/coda/Makefile line 5
Quoted 5 lines
drivers/media/platform/coda/Makefile +2
-2-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o -obj-$(CONFIG_VIDEO_CODA) += coda.o +obj-$(CONFIG_VIDEO_CODA) += video-coda.oHow about imx-coda? video-coda suggests it is part of the video subsystem, which it isn't.
I'll resend a v2 shortly with imx-coda instead.
Cheers,
Anders
Quoted 8 lines
Regards,
Hans
Quoted 2 lines
drivers/media/platform/coda/Makefile +0
-0obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o
Quoted 28 lines · Anders Roxell
Quoted 27 lines · Hans Verkuil
Quoted 25 lines · Anders Roxell
When building with
CONFIG_VIDEO_CODAandCONFIG_CODA_FSenabled as loadable modules, we see the following warning:warning: same module names found:
fs/coda/coda.ko
drivers/media/platform/coda/coda.koRework so media coda matches the config fragment. Leaving
CODA_FSas is since thats a well known module.Signed-off-by Anders Roxell <[email protected]>--- drivers/media/platform/coda/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/media/platform/coda/Makefile +1
-1@@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
Quoted 7 lines
Quoted 5 lines
drivers/media/platform/coda/Makefile line 5
Quoted 2 lines
drivers/media/platform/coda/Makefile +1
-1-obj-$(CONFIG_VIDEO_CODA) += coda.o +obj-$(CONFIG_VIDEO_CODA) += video-coda.oHow about imx-coda? video-coda suggests it is part of the video subsystem, which it isn't.
I'll resend a v2 shortly with imx-coda instead.
What about other vendor SoCs implementing the Coda IP block which are not an imx? I'd prefer a more generic name - maybe media-coda.
Thanks,
Matt
Quoted 13 lines
Cheers,
AndersQuoted 8 lines
Regards,
Hans
Quoted 2 lines
drivers/media/platform/coda/Makefile +0
-0obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o
Hi,
Quoted 30 lines · Matt Redfearn
Quoted 28 lines · Anders Roxell
Quoted 27 lines · Hans Verkuil
Quoted 25 lines · Anders Roxell
When building with
CONFIG_VIDEO_CODAandCONFIG_CODA_FSenabled as loadable modules, we see the following warning:warning: same module names found:
fs/coda/coda.ko
drivers/media/platform/coda/coda.koRework so media coda matches the config fragment. Leaving
CODA_FSas is since thats a well known module.Signed-off-by Anders Roxell <[email protected]>--- drivers/media/platform/coda/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/media/platform/coda/Makefile +1
-1@@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
drivers/media/platform/coda/Makefile line 5
Quoted 2 lines
drivers/media/platform/coda/Makefile +1
-1-obj-$(CONFIG_VIDEO_CODA) += coda.o +obj-$(CONFIG_VIDEO_CODA) += video-coda.oHow about imx-coda? video-coda suggests it is part of the video subsystem, which it isn't.
I'll resend a v2 shortly with imx-coda instead.
I'd be in favor of calling it "coda-vpu" instead.
Quoted 2 lines
What about other vendor SoCs implementing the Coda IP block which are not an imx? I'd prefer a more generic name - maybe media-coda.
Right, this driver can be used on other SoCs [1].
[1] https://www.mail-archive.com/[email protected]/msg146498.html
regards
Philipp
Quoted 39 lines · Philipp Zabel
Hi,
Quoted 36 lines · Matt Redfearn
Quoted 34 lines · Anders Roxell
Quoted 32 lines · Hans Verkuil
Quoted 20 lines · Anders Roxell
When building with
CONFIG_VIDEO_CODAandCONFIG_CODA_FSenabled as loadable modules, we see the following warning:warning: same module names found:
fs/coda/coda.ko
drivers/media/platform/coda/coda.koRework so media coda matches the config fragment. Leaving
CODA_FSas is since thats a well known module.Signed-off-by Anders Roxell <[email protected]>--- drivers/media/platform/coda/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/media/platform/coda/Makefile +0
-0drivers/media/platform/coda/Makefile line 5
Quoted 7 lines
drivers/media/platform/coda/Makefile +2
-2@@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o -obj-$(CONFIG_VIDEO_CODA) += coda.o +obj-$(CONFIG_VIDEO_CODA) += video-coda.oHow about imx-coda? video-coda suggests it is part of the video subsystem, which it isn't.
Quoted 3 lines
Quoted 1 line
Quoted 1 line
I'll resend a v2 shortly with imx-coda instead.
I'd be in favor of calling it "coda-vpu" instead.
Fine by me!
Quoted 5 lines
Quoted 3 lines
What about other vendor SoCs implementing the Coda IP block which are not an imx? I'd prefer a more generic name - maybe media-coda.
Right, this driver can be used on other SoCs [1].
Good point.
Regards,
Hans
Quoted 6 lines
[1] https://www.mail-archive.com/[email protected]/msg146498.html
regards
Philipp
Quoted 48 lines · Hans Verkuil
Quoted 39 lines · Philipp Zabel
Hi,
Quoted 36 lines · Matt Redfearn
Quoted 34 lines · Anders Roxell
Quoted 32 lines · Hans Verkuil
Quoted 20 lines · Anders Roxell
When building with
CONFIG_VIDEO_CODAandCONFIG_CODA_FSenabled as loadable modules, we see the following warning:warning: same module names found:
fs/coda/coda.ko
drivers/media/platform/coda/coda.koRework so media coda matches the config fragment. Leaving
CODA_FSas is since thats a well known module.Signed-off-by Anders Roxell <[email protected]>--- drivers/media/platform/coda/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/media/platform/coda/Makefile +0
-0drivers/media/platform/coda/Makefile line 5
Quoted 7 lines
drivers/media/platform/coda/Makefile +2
-2@@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o -obj-$(CONFIG_VIDEO_CODA) += coda.o +obj-$(CONFIG_VIDEO_CODA) += video-coda.oHow about imx-coda? video-coda suggests it is part of the video subsystem, which it isn't.
Quoted 3 lines
Quoted 1 line
Quoted 1 line
I'll resend a v2 shortly with imx-coda instead.
I'd be in favor of calling it "coda-vpu" instead.
Fine by me!
Quoted 1 line
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
What about other vendor SoCs implementing the Coda IP block which are not an imx? I'd prefer a more generic name - maybe media-coda.
Right, this driver can be used on other SoCs [1].
Good point.
OK, so I'll change it to 'media-coda'.
Cheers,
Anders
Quoted 12 lines
Regards,
Hans
Quoted 6 lines
[1] https://www.mail-archive.com/[email protected]/msg146498.html
regards
Philipp
Quoted 55 lines · Anders Roxell
Quoted 8 lines · Hans Verkuil
Quoted 6 lines · Philipp Zabel
Hi,
Quoted 3 lines · Matt Redfearn
Quoted 1 line · Anders Roxell
On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <[email protected]>
Quoted 10 lines · wrote:
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 10 lines · Anders Roxell
Quoted 8 lines
When building with
CONFIG_VIDEO_CODAandCONFIG_CODA_FSenabled as loadable modules, we see the following warning:warning: same module names found:
fs/coda/coda.ko
drivers/media/platform/coda/coda.koRework so media coda matches the config fragment. Leaving
CODA_FSas is
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Review
Quoted 8 lines
since thats a well known module.
Signed-off-by Anders Roxell <[email protected]>--- drivers/media/platform/coda/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)(quoted diff) +0
-0b/drivers/media/platform/coda/Makefile
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
drivers/media/platform/coda/Makefile line 3
Quoted 7 lines
index
54e9a73a92ab..588e6bf7c190100644drivers/media/platform/coda/Makefile +0
-1@@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.ocoda-mpeg2.o coda-mpeg4.o coda-jpeg.o
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
drivers/media/platform/coda/Makefile line 3
Quoted 1 line
drivers/media/platform/coda/Makefile +1
-0+video-coda-objs := coda-common.o coda-bit.o coda-gdi.ocoda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
drivers/media/platform/coda/Makefile line 4
Quoted 3 lines
drivers/media/platform/coda/Makefile +1
-1-obj-$(CONFIG_VIDEO_CODA) += coda.o +obj-$(CONFIG_VIDEO_CODA) += video-coda.oHow about imx-coda? video-coda suggests it is part of the video
subsystem,
Quoted 9 lines
Quoted 5 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
which it isn't.
I'll resend a v2 shortly with imx-coda instead.
I'd be in favor of calling it "coda-vpu" instead.
Fine by me!
Quoted 1 line
Quoted 12 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
What about other vendor SoCs implementing the Coda IP block which are not an imx? I'd prefer a more generic name - maybe media-coda.
Right, this driver can be used on other SoCs [1].
Good point.
OK, so I'll change it to 'media-coda'.
As suggested by Philipp, coda-vpu seems the most accurate name.
Thanks,
Ezequiel
Cheers,
Quoted 16 lines
Anders
Quoted 7 lines
Regards,
Hans
Quoted 2 lines
[1]
https://www.mail-archive.com/[email protected]/msg146498.html
Quoted 5 lines
Quoted 4 lines
regards
Philipp
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 59 lines · Ezequiel Garcia
Quoted 55 lines · Anders Roxell
Quoted 53 lines · Hans Verkuil
Quoted 39 lines · Philipp Zabel
Hi,
Quoted 36 lines · Matt Redfearn
Quoted 34 lines · Anders Roxell
Quoted 32 lines · Hans Verkuil
Quoted 20 lines · Anders Roxell
When building with
CONFIG_VIDEO_CODAandCONFIG_CODA_FSenabled as loadable modules, we see the following warning:warning: same module names found:
fs/coda/coda.ko
drivers/media/platform/coda/coda.koRework so media coda matches the config fragment. Leaving
CODA_FSas is since thats a well known module.Signed-off-by Anders Roxell <[email protected]>--- drivers/media/platform/coda/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/media/platform/coda/Makefile +0
-0drivers/media/platform/coda/Makefile line 5
Quoted 7 lines
drivers/media/platform/coda/Makefile +2
-2@@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o -obj-$(CONFIG_VIDEO_CODA) += coda.o +obj-$(CONFIG_VIDEO_CODA) += video-coda.oHow about imx-coda? video-coda suggests it is part of the video subsystem, which it isn't.
Quoted 3 lines
Quoted 1 line
Quoted 1 line
I'll resend a v2 shortly with imx-coda instead.
I'd be in favor of calling it "coda-vpu" instead.
Fine by me!
Quoted 5 lines
Quoted 3 lines
What about other vendor SoCs implementing the Coda IP block which are not an imx? I'd prefer a more generic name - maybe media-coda.
Right, this driver can be used on other SoCs [1].
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Good point.
OK, so I'll change it to 'media-coda'.
As suggested by Philipp, coda-vpu seems the most accurate name.
urgh, that correct.
Thanks,
Anders
Quoted 21 lines
Thanks,
EzequielQuoted 15 lines
Cheers,
AndersQuoted 12 lines
Regards,
Hans
Quoted 6 lines
[1] https://www.mail-archive.com/[email protected]/msg146498.html
regards
Philipp
Quoted 9 lines · Anders Roxell
When building with
CONFIG_VIDEO_CODAandCONFIG_CODA_FSenabled as loadable modules, we see the following warning:warning: same module names found:
fs/coda/coda.ko
drivers/media/platform/coda/coda.koRework so media coda matches the config fragment. Leaving
CODA_FSas is since thats a well known module.
s/thats/that's/