Skip to contentSkip to conversation

drivers: regulator: 88pm800: fix warning same module names

PATCH In review Anders Roxell 2 participants 3 messages Jun 6, 2019 – Jun 10, 2019

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

PATCH 8/8 drivers: regulator: 88pm800: fix warning same module names

When building with CONFIG_MFD_88PM800 and CONFIG_REGULATOR_88PM800 enabled as loadable modules, we see the following warning:

warning: same module names found:
drivers/regulator/88pm800.ko
drivers/mfd/88pm800.ko

Rework to rename the name.

---
 drivers/regulator/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/regulator/Makefile +2 -1
index 76e78fa449a2..6906938071f5 100644
@@ -11,7 +11,8 @@ obj-$(CONFIG_REGULATOR_VIRTUAL_CONSUMER) += virtual.o
 obj-$(CONFIG_REGULATOR_USERSPACE_CONSUMER) += userspace-consumer.o
 
 obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o
-obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
+obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
+88pm800-regulator-objs		:= 88pm800.o
 obj-$(CONFIG_REGULATOR_88PM8607) += 88pm8607.o
 obj-$(CONFIG_REGULATOR_CPCAP) += cpcap-regulator.o
 obj-$(CONFIG_REGULATOR_AAT2870) += aat2870-regulator.o
Signature · 1 line
2.20.1
maintainer
#1 lore raw

drivers/regulator/Makefile obj-$(CONFIG_REGULATOR_VIRTUAL_CONSUMER) += virtual.o · line 15

Quoted 4 lines · Anders Roxell

obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o

drivers/regulator/Makefile +2 -1
-obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
+obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
+88pm800-regulator-objs		:= 88pm800.o

Don't do this, no need for this driver to look different to all the others in the Makefile - just rename the whole file.

#2 lore raw
Quoted 10 lines · Mark Brown

drivers/regulator/Makefile obj-$(CONFIG_REGULATOR_VIRTUAL_CONSUMER) += virtual.o · line 15

Quoted 4 lines · Anders Roxell

obj-$(CONFIG_REGULATOR_88PG86X) += 88pg86x.o

drivers/regulator/Makefile +2 -1
-obj-$(CONFIG_REGULATOR_88PM800) += 88pm800.o
+obj-$(CONFIG_REGULATOR_88PM800) += 88pm800-regulator.o
+88pm800-regulator-objs               := 88pm800.o

Don't do this, no need for this driver to look different to all the others in the Makefile - just rename the whole file.

Thank you for your review, I'll rework and resend v2 shortly.

Cheers,
Anders