drivers: net: phy: fix warning same module names
Subsystems (5)
PATCH 6/8 drivers: net: phy: fix warning same module names
When building with CONFIG_ASIX_PHY and CONFIG_USB_NET_AX8817X enabled as loadable modules, we see the following warning:
warning: same module names found:
drivers/net/phy/asix.ko
drivers/net/usb/asix.ko
Rework so media coda matches the config fragment. Leaving CONFIG_USB_NET_AX8817X as is since thats a well known module.
--- drivers/net/phy/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/phy/Makefile +2 -1
@@ -52,7 +52,8 @@ ifdef CONFIG_HWMON aquantia-objs += aquantia_hwmon.o endif obj-$(CONFIG_AQUANTIA_PHY) += aquantia.o -obj-$(CONFIG_ASIX_PHY) += asix.o +obj-$(CONFIG_ASIX_PHY) += asix-phy.o +asix-phy-objs := asix.o obj-$(CONFIG_AT803X_PHY) += at803x.o obj-$(CONFIG_BCM63XX_PHY) += bcm63xx.o obj-$(CONFIG_BCM7XXX_PHY) += bcm7xxx.o
Signature · 1 line
2.20.1
Andrew Lunn
maintainerQuoted 8 lines · Anders Roxell
When building with
CONFIG_ASIX_PHYandCONFIG_USB_NET_AX8817Xenabled as loadable modules, we see the following warning:warning: same module names found:
drivers/net/phy/asix.ko
drivers/net/usb/asix.koRework so media coda matches the config fragment. Leaving
No media coda here.
Quoted 1 line
CONFIG_USB_NET_AX8817Xas is since thats a well known module.
Again, place base on net-next and submit to just netdev.
Please rename the PHY driver asix88796.
Andrew
Hi Andew, Anders,
sorry I dropped the ball on that one - I've got a patch for the ax88796b PHY driver that I just forgot to resend.
It'll clash with your patch, Anders - are you happy to drop the CONFIG_ASIX_PHY from your series?
Cheers,
Michael
Quoted 17 lines · Andrew Lunn
Quoted 8 lines · Anders Roxell
When building with
CONFIG_ASIX_PHYandCONFIG_USB_NET_AX8817Xenabled as loadable modules, we see the following warning:warning: same module names found:
drivers/net/phy/asix.ko
drivers/net/usb/asix.koRework so media coda matches the config fragment. Leaving
No media coda here.
Quoted 1 line
CONFIG_USB_NET_AX8817Xas is since thats a well known module.Again, place base on net-next and submit to just netdev.
Please rename the PHY driver asix88796.
Andrew
Andrew Lunn
maintainerQuoted 7 lines · Michael Schmitz
Hi Andew, Anders,
sorry I dropped the ball on that one - I've got a patch for the ax88796b PHY driver that I just forgot to resend.
It'll clash with your patch, Anders - are you happy to drop the
CONFIG_ASIX_PHYfrom your series?
Hi Michael
Please send your patch. Anders needs to split up his patchset anyway, so dropping one is not a problem.
Andrew
Hi Andrew,
Am 07.06.2019 um 13:59 schrieb Andrew Lunn:
Quoted 6 lines · Michael Schmitz
Quoted 5 lines
Hi Andew, Anders,
sorry I dropped the ball on that one - I've got a patch for the ax88796b PHY driver that I just forgot to resend.
Quoted 7 lines
Quoted 2 lines
It'll clash with your patch, Anders - are you happy to drop the
CONFIG_ASIX_PHYfrom your series?Hi Michael
Please send your patch. Anders needs to split up his patchset anyway, so dropping one is not a problem.
Done, thanks for your feedback.
Cheers,
Michael
Quoted 3 lines
Andrew