Skip to contentSkip to conversation

crypto: mxs-dcp - Use devm_platform_ioremap_resource()

PATCH In review Fabio Estevam 2 participants 3 messages Jun 6, 2019 – Jun 13, 2019

Subsystems (2)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 crypto: mxs-dcp - Use devm_platform_ioremap_resource()

Use devm_platform_ioremap_resource() to simplify the code a bit.

---
 drivers/crypto/mxs-dcp.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/crypto/mxs-dcp.c +1 -4
index bdc4c42d3ac8..f1fa637cb029 100644
@@ -986,8 +986,6 @@ static int mxs_dcp_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct dcp *sdcp = NULL;
 	int i, ret;
-
-	struct resource *iores;
 	int dcp_vmi_irq, dcp_irq;
 
 	if (global_sdcp) {
@@ -995,7 +993,6 @@ static int mxs_dcp_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 
-	iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	dcp_vmi_irq = platform_get_irq(pdev, 0);
 	if (dcp_vmi_irq < 0) {
 		dev_err(dev, "Failed to get IRQ: (%d)!\n", dcp_vmi_irq);
@@ -1013,7 +1010,7 @@ static int mxs_dcp_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	sdcp->dev = dev;
-	sdcp->base = devm_ioremap_resource(dev, iores);
+	sdcp->base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(sdcp->base))
 		return PTR_ERR(sdcp->base);
 
Signature · 1 line
2.17.1
author reviewer
#1 lore raw

PATCH 2/2 crypto: sahara - Use devm_platform_ioremap_resource()

Use devm_platform_ioremap_resource() to simplify the code a bit.

---
 drivers/crypto/sahara.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/crypto/sahara.c +1 -3
index fd11162a915e..616fdc9f1816 100644
@@ -1387,7 +1387,6 @@ MODULE_DEVICE_TABLE(of, sahara_dt_ids);
 static int sahara_probe(struct platform_device *pdev)
 {
 	struct sahara_dev *dev;
-	struct resource *res;
 	u32 version;
 	int irq;
 	int err;
@@ -1401,8 +1400,7 @@ static int sahara_probe(struct platform_device *pdev)
 	platform_set_drvdata(pdev, dev);
 
 	/* Get the base address */
-	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	dev->regs_base = devm_ioremap_resource(&pdev->dev, res);
+	dev->regs_base = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(dev->regs_base))
 		return PTR_ERR(dev->regs_base);
 
Signature · 1 line
2.17.1
maintainer
#2 lore raw
In reply to Fabio Estevam
Quoted 6 lines · Fabio Estevam

Use devm_platform_ioremap_resource() to simplify the code a bit.

---
 drivers/crypto/mxs-dcp.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

All applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt