Skip to contentSkip to conversation

net/netvsc: initialize vf spinlock

PATCH Applied Stephen Hemminger 2 participants 2 messages Jun 6, 2019 – Jun 18, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/netvsc: initialize vf spinlock

The VF spinlock was never initialized. It works because it is in zmalloc'd memory and an unlocked lock on x86 is 0. But for good practice, all spinlock's should be initialized.

Fixes dc7680e8597c ("net/netvsc: support integrated VF")
---
 drivers/net/netvsc/hn_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/netvsc/hn_ethdev.c +1 -0
index 9e7cf2df5472..70352f0e1a3d 100644
@@ -739,6 +739,7 @@ eth_hn_dev_init(struct rte_eth_dev *eth_dev)
 	hv->port_id = eth_dev->data->port_id;
 	hv->latency = HN_CHAN_LATENCY_NS;
 	hv->max_queues = 1;
+	rte_spinlock_init(&hv->vf_lock);
 	hv->vf_port = HN_INVALID_PORT;
 
 	err = hn_parse_args(eth_dev);
Signature · 1 line
2.20.1
Applied
#1 lore raw
Quoted 6 lines · Stephen Hemminger

The VF spinlock was never initialized. It works because it is in zmalloc'd memory and an unlocked lock on x86 is 0. But for good practice, all spinlock's should be initialized.

Fixes dc7680e8597c ("net/netvsc: support integrated VF")

Applied to dpdk-next-net/master, thanks.