clk: imx8qxp: Use devm_platform_ioremap_resource()
Subsystems (3)
Fabio Estevam
reviewerPATCH 1/1 clk: imx8qxp: Use devm_platform_ioremap_resource()
Use devm_platform_ioremap_resource() to simplify the code a bit.
--- drivers/clk/imx/clk-imx8qxp-lpcg.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
drivers/clk/imx/clk-imx8qxp-lpcg.c +3 -7
@@ -159,7 +159,6 @@ static int imx8qxp_lpcg_clk_probe(struct platform_device *pdev)struct clk_hw_onecell_data *clk_data;const struct imx8qxp_ss_lpcg *ss_lpcg;const struct imx8qxp_lpcg_data *lpcg; -struct resource *res;struct clk_hw **clks;void __iomem *base;int i;
@@ -168,12 +167,9 @@ static int imx8qxp_lpcg_clk_probe(struct platform_device *pdev)if (!ss_lpcg)return -ENODEV ; - res =platform_get_resource (pdev,IORESOURCE_MEM ,0 ); -if (!res) -return -EINVAL ; - base =devm_ioremap (dev, res->start,resource_size (res)); -if (!base) -return -ENOMEM ; + base =devm_platform_ioremap_resource (pdev,0 ); +if (IS_ERR (base)) +return PTR_ERR (base); clk_data =devm_kzalloc (&pdev->dev,struct_size (clk_data, hws, ss_lpcg->num_max),GFP_KERNEL );
Signature · 1 line
2.17.1
Quoting Fabio Estevam (2019-06-06 09:44:43)
Quoted 4 lines
Use
devm_platform_ioremap_resource()to simplify the code a bit.Signed-off-by Fabio Estevam <[email protected]>---
Quoted 7 lines · Stephen Boyd
Quoting Fabio Estevam (2019-06-06 09:44:43)
Quoted 4 lines
Use
devm_platform_ioremap_resource()to simplify the code a bit.Signed-off-by Fabio Estevam <[email protected]>---
Reviewed-by Stephen Boyd <[email protected]>
An extremely similar patch was already submitted and then reverted because it breaks boot:
https://patchwork.kernel.org/patch/10908807/
I tested and this new patch also breaks boot.
The current imx8 lpcg driver maps entire subsystems at once and if devm_platform_ioremap_resource is used then devices inside the subsystem will fail to probe, including lpuart!
The hardware on imx8qxp and related parts (imx8qm) has multiple separate LPCG blocks interspersed between devices. Some refactoring patches were posted by Aisheng to split LPCG into multiple blocks but apparently got stuck in review:
https://patchwork.kernel.org/cover/10924029/ https://patchwork.kernel.org/cover/10824443/ https://patchwork.kernel.org/cover/10824537/
There were some disagreements regarding DT bindings for split imx8 clocks, what would it take to move those patches forward?
--
Regards,
Leonard
Stephen Boyd
maintainerQuoting Leonard Crestez (2019-06-06 10:15:32)
Quoted 25 lines · Stephen Boyd
Quoted 7 lines
Quoting Fabio Estevam (2019-06-06 09:44:43)
Quoted 4 lines
Use
devm_platform_ioremap_resource()to simplify the code a bit.Signed-off-by Fabio Estevam <[email protected]>---
Reviewed-by Stephen Boyd <[email protected]>An extremely similar patch was already submitted and then reverted because it breaks boot:
https://patchwork.kernel.org/patch/10908807/I tested and this new patch also breaks boot.
The current imx8 lpcg driver maps entire subsystems at once and if
devm_platform_ioremap_resourceis used then devices inside the subsystem will fail to probe, including lpuart!The hardware on imx8qxp and related parts (imx8qm) has multiple separate LPCG blocks interspersed between devices. Some refactoring patches were posted by Aisheng to split LPCG into multiple blocks but apparently got stuck in review:
Quoted 7 lines
https://patchwork.kernel.org/cover/10924029/ https://patchwork.kernel.org/cover/10824443/ https://patchwork.kernel.org/cover/10824537/There were some disagreements regarding DT bindings for split imx8 clocks, what would it take to move those patches forward?
Don't know. I'll have to read those patches on the list and reply there.
Quoted 22 lines · Stephen Boyd
Quoting Leonard Crestez (2019-06-06 10:15:32)
Quoted 21 lines · Stephen Boyd
Quoted 7 lines
Quoting Fabio Estevam (2019-06-06 09:44:43)
Quoted 4 lines
Use
devm_platform_ioremap_resource()to simplify the code a bit.Signed-off-by Fabio Estevam <[email protected]>---
Reviewed-by Stephen Boyd <[email protected]>An extremely similar patch was already submitted and then reverted because it breaks boot:
The current imx8 lpcg driver maps entire subsystems at once and if
devm_platform_ioremap_resourceis used then devices inside the subsystem will fail to probe, including lpuart!The hardware on imx8qxp and related parts (imx8qm) has multiple separate LPCG blocks interspersed between devices. Some refactoring patches were posted by Aisheng to split LPCG into multiple blocks but apparently got stuck in review:
Quoted 4 lines
Quoted 2 lines
There were some disagreements regarding DT bindings for split imx8 clocks, what would it take to move those patches forward?
Don't know. I'll have to read those patches on the list and reply there.
Some specific advice on how to refactor and split imx8qxp clk in a way that is acceptable to upstream would be very helpful to us.
--
Regards,
Leonard
Fabio Estevam
reviewerQuoted 6 lines · Leonard Crestez
An extremely similar patch was already submitted and then reverted because it breaks boot:
https://patchwork.kernel.org/patch/10908807/I tested and this new patch also breaks boot.
Ops, sorry about that!