drm: remove the newline for CRC source name.
Subsystems (2)
PATCH 1/1 drm: remove the newline for CRC source name.
userspace may transfer a newline, and this terminating newline is replaced by a '\0' to avoid followup issues.
'n-1' is the index to replace the newline of CRC source name.
v2: update patch subject, body and format. (Sam)
--- drivers/gpu/drm/drm_debugfs_crc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_debugfs_crc.c +2 -2
@@ -131,8 +131,8 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf,if (IS_ERR (source))return PTR_ERR (source); -if (source[len] =='\n' ) - source[len] ='\0' ; +if (source[len -1 ] =='\n' ) + source[len -1 ] ='\0' ; ret = crtc->funcs->verify_crc_source (crtc, source, &values_cnt);if (ret)
Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Dingchen.
Patch is much better now.
Quoted 4 lines · Dingchen Zhang
userspace may transfer a newline, and this terminating newline is replaced by a '\0' to avoid followup issues.
'n-1' is the index to replace the newline of CRC source name.
I am a little confused where 'n' comes from here?
I you had written ' len - 1' then there was a clear connection to the patch.
With this fixed:
Quoted 28 lines
v2: update patch subject, body and format. (Sam)
Cc Leo Li <[email protected]>Cc Harry Wentland <[email protected]>Cc Sam Ravnborg <[email protected]>Signed-off-by Dingchen Zhang <[email protected]>--- drivers/gpu/drm/drm_debugfs_crc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_debugfs_crc.c +2
-2@@ -131,8 +131,8 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf,if (IS_ERR (source))return PTR_ERR (source); -if (source[len] =='\n' ) - source[len] ='\0' ; +if (source[len -1 ] =='\n' ) + source[len -1 ] ='\0' ; ret = crtc->funcs->verify_crc_source (crtc, source, &values_cnt);if (ret)Signature · 1 line
2.17.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Zhang, Dingchen (David)
Reviewed-by Sam RavnborgHi Sam,
Thanks for the good catch. Actually it's a typo in email reply. It should be 'len - 1'.
Regards,
-----Original Message-----
From: Sam Ravnborg <[email protected]>
Sent: Saturday, June 8, 2019 7:56 AM
To: Zhang, Dingchen (David) <[email protected]>
Cc: [email protected]; Li, Sun peng (Leo) <[email protected]>; Wentland, Harry <[email protected]>
Subject: Re: [PATCH] drm: remove the newline for CRC source name.
Hi Dingchen.
Patch is much better now.
Quoted 4 lines · Dingchen Zhang
userspace may transfer a newline, and this terminating newline is replaced by a '\0' to avoid followup issues.
'n-1' is the index to replace the newline of CRC source name.
I am a little confused where 'n' comes from here?
I you had written ' len - 1' then there was a clear connection to the patch.
With this fixed:
Quoted 28 lines
v2: update patch subject, body and format. (Sam)
Cc Leo Li <[email protected]>Cc Harry Wentland <[email protected]>Cc Sam Ravnborg <[email protected]>Signed-off-by Dingchen Zhang <[email protected]>--- drivers/gpu/drm/drm_debugfs_crc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_debugfs_crc.c +2
-3@@ -131,8 +131,8 @@ static ssize_t crc_control_write(struct file *file, const char __user *ubuf,if (IS_ERR (source))return PTR_ERR (source); -if (source[len] =='\n' ) - source[len] ='\0' ; +if (source[len -1 ] =='\n' ) + source[len -1 ] ='\0' ; ret = crtc->funcs->verify_crc_source (crtc, source, &values_cnt);if (ret) --
Quoted 1 line
2.17.1
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel