Skip to contentSkip to conversation

Revert "net/mlx: support IOVA VA mode"

PATCH In review Stephen Hemminger 2 participants 6 messages Jun 7, 2019 – Jul 22, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Revert "net/mlx: support IOVA VA mode"

From: Stephen Hemminger <[email protected]>

This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd. That commit breaks support for netvsc PMD with MLX SRIOV on both Hyper-V and Azure.

---
 drivers/net/mlx4/mlx4.c | 4 ++--
 drivers/net/mlx5/mlx5.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/net/mlx4/mlx4.c +2 -2
index aa4d43fad78a..4d84a923d2ff 100644
@@ -1142,8 +1142,8 @@ static struct rte_pci_driver mlx4_driver = {
 	},
 	.id_table = mlx4_pci_id_map,
 	.probe = mlx4_pci_probe,
-	.drv_flags = RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV |
-		     RTE_PCI_DRV_IOVA_AS_VA,
+	.drv_flags = RTE_PCI_DRV_INTR_LSC |
+		     RTE_PCI_DRV_INTR_RMV,
 };
 
 #ifdef RTE_IBVERBS_LINK_DLOPEN
drivers/net/mlx5/mlx5.c +2 -2
index daadf4a7a7f9..912d80e16d09 100644
@@ -2107,8 +2107,8 @@ static struct rte_pci_driver mlx5_driver = {
 	.remove = mlx5_pci_remove,
 	.dma_map = mlx5_dma_map,
 	.dma_unmap = mlx5_dma_unmap,
-	.drv_flags = RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV |
-		     RTE_PCI_DRV_PROBE_AGAIN | RTE_PCI_DRV_IOVA_AS_VA,
+	.drv_flags = (RTE_PCI_DRV_INTR_LSC | RTE_PCI_DRV_INTR_RMV |
+		      RTE_PCI_DRV_PROBE_AGAIN),
 };
 
 #ifdef RTE_IBVERBS_LINK_DLOPEN
Signature · 1 line
2.20.1
#4 lore raw

09/07/2019 16:39, Stephen Hemminger:

Quoted 5 lines
Quoted 2 lines · On Fri, 7 Jun 2019 16:08:41 -0700 Stephen Hemminger…

From: Stephen Hemminger <[email protected]>

Quoted 8 lines
Quoted 5 lines

This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd. That commit breaks support for netvsc PMD with MLX SRIOV on both Hyper-V and Azure.

DPDK 19.08-rc is broken on Azure. This patch which seems to have been ignored fixes it.

This patch was not ignored. I was waiting for the IOVA changes to settle down. As a result, the revert will happen because the type RTE_KDRV_NIC_MLX is not needed anymore:

	https://patches.dpdk.org/patch/56314/

However, I don't understand how it is related to netvsc PMD. Please could you give more details?

#5 lore raw

11/07/2019 00:18, Thomas Monjalon:

Quoted 12 lines

09/07/2019 16:39, Stephen Hemminger:

Quoted 11 lines
Quoted 7 lines · On Fri, 7 Jun 2019 16:08:41 -0700 Stephen Hemminger…

From: Stephen Hemminger <[email protected]>

This reverts commit 69c06d0e357ed0064b498d510d169603cf7308cd. That commit breaks support for netvsc PMD with MLX SRIOV on both Hyper-V and Azure.

Quoted 7 lines
Quoted 2 lines

DPDK 19.08-rc is broken on Azure. This patch which seems to have been ignored fixes it.

This patch was not ignored. I was waiting for the IOVA changes to settle down. As a result, the revert will happen because the type RTE_KDRV_NIC_MLX is not needed anymore:

	https://patches.dpdk.org/patch/56314/

The revert is applied on master now.

Quoted 2 lines

However, I don't understand how it is related to netvsc PMD. Please could you give more details?

Please did you investigate what happened?