Skip to contentSkip to conversation

fs: Add VirtualBox guest shared folder (vboxsf) support

PATCH Superseded Hans de Goede 1 participant 2 messages Jun 8, 2019 VFS

v12 of 19 Superseded Latest is v19 →

lore
Share & tools
lore
#0 lore raw

v12 cover fs: Add VirtualBox guest shared folder (vboxsf) support

Hello Everyone,

Here is the 12th version of my cleaned-up / refactored version of the VirtualBox shared-folder VFS driver.

This version hopefully addresses all issues pointed out in David Howell's review of v11 (thank you for the review David):

Changes in v12:
-Move make_kuid / make_kgid calls to option parsing time and add
uid_valid / gid_valid checks.
-In init_fs_context call current_uid_gid() to init uid and gid -Validate dmode, fmode, dmask and fmask options during option parsing -Use correct types for various mount option variables (kuid_t, kgid_t, umode_t) -Some small coding-style tweaks

For changes in older versions see the change log in the patch.

This version has been used by several distributions (arch, Fedora) for a while now, so hopefully we can get this upstream soonish, please review.

Regards,

Hans

#1 lore raw

Hi,

Quoted 16 lines · Hans de Goede

Hello Everyone,

Here is the 12th version of my cleaned-up / refactored version of the VirtualBox shared-folder VFS driver.

This version hopefully addresses all issues pointed out in David Howell's review of v11 (thank you for the review David):

Changes in v12:

(quoted diff) +0 -5
-Move make_kuid / make_kgid calls to option parsing time and add
  uid_valid / gid_valid checks.
-In init_fs_context call current_uid_gid() to init uid and gid
-Validate dmode, fmode, dmask and fmask options during option parsing
-Use correct types for various mount option variables (kuid_t, kgid_t, umode_t)
-Some small coding-style tweaks
Quoted 4 lines

For changes in older versions see the change log in the patch.

This version has been used by several distributions (arch, Fedora) for a while now, so hopefully we can get this upstream soonish, please review.

Hmm, a space which does not belong there has snuck in at the start of super.c line 151:

        /* Load nls if not utf8 */

Sorry about that, I will fix this in the next version.

Regards,

hans