Skip to contentSkip to conversation

Staging: rts5208: fixed brace coding style issue

PATCH In review [email protected] 2 participants 2 messages Jun 8, 2019 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rts5208: fixed brace coding style issue

From: Xabier Etxezarreta <[email protected]>

Fixed a coding style issue checked with checkpatch.pl

---
 drivers/staging/rts5208/rtsx.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/rts5208/rtsx.c +1 -4
index fa597953e9a0..d16e92b09a1f 100644
@@ -419,10 +419,7 @@ static int rtsx_control_thread(void *__dev)
 				chip->srb->device->id,
 				(u8)chip->srb->device->lun);
 			chip->srb->result = DID_BAD_TARGET << 16;
-		}
-
-		/* we've got a command, let's do it! */
-		else {
+		} else { /* we've got a command, let's do it! */
 			scsi_show_command(chip);
 			rtsx_invoke_transport(chip->srb, chip);
 		}
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 14 lines · On Sat, Jun 08, 2019 at 03:53:35PM +0200, [email protected] wrote:

From: Xabier Etxezarreta <[email protected]>

Fixed a coding style issue checked with checkpatch.pl

---
 drivers/staging/rts5208/rtsx.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/rts5208/rtsx.c +0 -0
index fa597953e9a0..d16e92b09a1f 100644

drivers/staging/rts5208/rtsx.c static int rtsx_control_thread(void *__dev) · line 423

Quoted 9 lines
drivers/staging/rts5208/rtsx.c +1 -4
@@ -419,10 +419,7 @@ static int rtsx_control_thread(void *__dev)
 				chip->srb->device->id,
 				(u8)chip->srb->device->lun);
 			chip->srb->result = DID_BAD_TARGET << 16;
-		}
-
-		/* we've got a command, let's do it! */
-		else {
+		} else { /* we've got a command, let's do it! */
 			scsi_show_command(chip);

Comment should go on a new line.

thanks,

greg k-h