Skip to contentSkip to conversation

net: phy: broadcom: Add genphy_suspend and genphy_resume for BCM5464

PATCH Applied Vladimir Oltean 3 participants 3 messages Jun 8, 2019 – Jun 10, 2019

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: phy: broadcom: Add genphy_suspend and genphy_resume for BCM5464

This puts the quad PHY ports in power-down mode when the PHY transitions to the PHY_HALTED state. It is likely that all the other PHYs support the BMCR_PDOWN bit, but I only have the BCM5464R to test.

---
 drivers/net/phy/broadcom.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/phy/broadcom.c +2 -0
index 67fa05d67523..937d0059e8ac 100644
@@ -663,6 +663,8 @@ static struct phy_driver broadcom_drivers[] = {
 	.config_init	= bcm54xx_config_init,
 	.ack_interrupt	= bcm_phy_ack_intr,
 	.config_intr	= bcm_phy_config_intr,
+	.suspend	= genphy_suspend,
+	.resume		= genphy_resume,
 }, {
 	.phy_id		= PHY_ID_BCM5481,
 	.phy_id_mask	= 0xfffffff0,
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Vladimir Oltean

This puts the quad PHY ports in power-down mode when the PHY transitions to the PHY_HALTED state. It is likely that all the other PHYs support the BMCR_PDOWN bit, but I only have the BCM5464R to test.

Yes, they should all support that low power mode, but like you, only have a limited subset to work with.

Quoted 2 lines
Signature · 1 line
Florian