staging: isdn: hysdn: fix symbol 'hysdn_proc_entry' was not declared.
Subsystems (3)
PATCH 1/1 staging: isdn: hysdn: fix symbol 'hysdn_proc_entry' was not declared.
This was reported by sparse:drivers/staging/isdn/hysdn/hysdn_procconf.c:352:23: warning: symbol 'hysdn_proc_entry' was not declared. Should it be static?
--- drivers/staging/isdn/hysdn/hysdn_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/isdn/hysdn/hysdn_defs.h +1 -1
@@ -221,7 +221,7 @@ typedef struct hycapictrl_info hycapictrl_info;/* exported vars */ /*****************/ extern hysdn_card *card_root;/* pointer to first card */ - +extern struct proc_dir_entry *hysdn_proc_entry;/* hysdn subdir in /proc/net /*************************/
Signature · 1 line
2.17.1
Greg KH
maintainerQuoted 13 lines · Valerio Genovese
This was reported by sparse:
drivers/staging/isdn/hysdn/hysdn_procconf.c:352:23: warning: symbol 'hysdn_proc_entry' was not declared. Should it be static?Signed-off-by Valerio Genovese <[email protected]>--- drivers/staging/isdn/hysdn/hysdn_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/isdn/hysdn/hysdn_defs.h +0
-0
drivers/staging/isdn/hysdn/hysdn_defs.h typedef struct hycapictrl_info hycapictrl_info; · line 227
Quoted 8 lines
drivers/staging/isdn/hysdn/hysdn_defs.h +1
-1@@ -221,7 +221,7 @@ typedef struct hycapictrl_info hycapictrl_info;/* exported vars */ /*****************/ extern hysdn_card *card_root;/* pointer to first card */ - +extern struct proc_dir_entry *hysdn_proc_entry;/* hysdn subdir in /proc/net /*************************/
Shouldn't you also remove it from the place it was devlared as extern?
Also, this is code on its way out of the kernel, not a big deal to leave it alone for now.
thanks,
greg k-h
Greg KH
maintainerQuoted 13 lines · Valerio Genovese
This was reported by sparse:
drivers/staging/isdn/hysdn/hysdn_procconf.c:352:23: warning: symbol 'hysdn_proc_entry' was not declared. Should it be static?Signed-off-by Valerio Genovese <[email protected]>--- drivers/staging/isdn/hysdn/hysdn_defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/isdn/hysdn/hysdn_defs.h +0
-0
drivers/staging/isdn/hysdn/hysdn_defs.h typedef struct hycapictrl_info hycapictrl_info; · line 224
Quoted 5 lines
drivers/staging/isdn/hysdn/hysdn_defs.h +1
-1@@ -221,7 +221,7 @@ typedef struct hycapictrl_info hycapictrl_info;/* exported vars */ /*****************/ extern hysdn_card *card_root;/* pointer to first card */ - +extern struct proc_dir_entry *hysdn_proc_entry;/* hysdn subdir in /proc/net
I can not take drivers/staging/isdn patches until 5.3-rc1.
thanks,
greg k-h