net: mscc: serval: Remove delay when serdes is configured
PATCH 1/1 net: mscc: serval: Remove delay when serdes is configured
When serdes configuration was written in hardware there was a delay of 100ms to be sure that configuration was written. But the delay is not needed because already the function serdes_write it is checking that the operation finished.
Therefore remove the mdelay. This improves the speed of configuring the network driver.
--- drivers/net/mscc_eswitch/serval_switch.c | 2 -- 1 file changed, 2 deletions(-)
drivers/net/mscc_eswitch/serval_switch.c +0 -2
@@ -356,8 +356,6 @@ static void serdes_write(void __iomem *base, u32 addr)do { data =readl (base +HSIO_MCB_SERDES1G_CFG ); }while (data &HSIO_MCB_SERDES1G_CFG_WR_ONE_SHOT ); - -mdelay (100 ); } static void serdes1g_setup(void __iomem *base, uint32_t addr,
Signature · 1 line
2.7.4
PATCH 1/1 net: mscc: serval: Remove delay when serdes is configured
Am 23.05.19 um 21:45 schrieb Horatiu Vultur:
Quoted 5 lines
When serdes configuration was written in hardware there was a delay of 100ms to be sure that configuration was written. But the delay is not needed because already the function
serdes_writeit is checking that the operation finished.
Quoted 8 lines
Therefore remove the mdelay. This improves the speed of configuring the network driver.
Signed-off-by Horatiu Vultur <[email protected]>--- drivers/net/mscc_eswitch/serval_switch.c | 2 -- 1 file changed, 2 deletions(-)
Signature · 1 line
- Daniel
PATCH 1/1 net: mscc: serval: Remove delay when serdes is configured
Hi,
I just wanted to give you a gentle ping. Thanks.
Quoted 23 lines · Daniel Schwierzeck
External E-Mail
Am 23.05.19 um 21:45 schrieb Horatiu Vultur:
Quoted 5 lines
When serdes configuration was written in hardware there was a delay of 100ms to be sure that configuration was written. But the delay is not needed because already the function
serdes_writeit is checking that the operation finished.Quoted 8 lines
Therefore remove the mdelay. This improves the speed of configuring the network driver.
Signed-off-by Horatiu Vultur <[email protected]>--- drivers/net/mscc_eswitch/serval_switch.c | 2 -- 1 file changed, 2 deletions(-)Reviewed-by Daniel Schwierzeck <[email protected]>Signature · 1 line
- Daniel
Signature · 1 line
/Horatiu
PATCH 1/1 net: mscc: serval: Remove delay when serdes is configured
In reply to Horatiu VulturQuoted 10 lines · Horatiu Vultur
When serdes configuration was written in hardware there was a delay of 100ms to be sure that configuration was written. But the delay is not needed because already the function
serdes_writeit is checking that the operation finished.Therefore remove the mdelay. This improves the speed of configuring the network driver.
Signed-off-by Horatiu Vultur <[email protected]>
Hi Horatiu,
https://patchwork.ozlabs.org/patch/1104383/ was applied to http://git.denx.de/?p=u-boot/u-boot-net.git
Thanks!
-Joe