Skip to contentSkip to conversation

net: openvswitch: remove unnecessary ASSERT_OVSL in ovs_vport_del()

PATCH Applied Taehee Yoo 3 participants 3 messages Jun 9, 2019 – Jun 11, 2019

Subsystems (3)
lore
Share & tools
lore

Taehee Yoo

author
#0 lore raw

PATCH 1/1 net: openvswitch: remove unnecessary ASSERT_OVSL in ovs_vport_del()

ASSERT_OVSL() in ovs_vport_del() is unnecessary because ovs_vport_del() is only called by ovs_dp_detach_port() and ovs_dp_detach_port() calls ASSERT_OVSL() too.

---
 net/openvswitch/vport.c | 2 --
 1 file changed, 2 deletions(-)
net/openvswitch/vport.c +0 -2
index 258ce3b7b452..9e71f1a601a9 100644
@@ -261,8 +261,6 @@ int ovs_vport_set_options(struct vport *vport, struct nlattr *options)
  */
 void ovs_vport_del(struct vport *vport)
 {
-	ASSERT_OVSL();
-
 	hlist_del_rcu(&vport->hash_node);
 	module_put(vport->ops->owner);
 	vport->ops->destroy(vport);
Signature · 1 line
2.17.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Taehee Yoo

ASSERT_OVSL() in ovs_vport_del() is unnecessary because ovs_vport_del() is only called by ovs_dp_detach_port() and ovs_dp_detach_port() calls ASSERT_OVSL() too.

---
  net/openvswitch/vport.c | 2 --
  1 file changed, 2 deletions(-)
net/openvswitch/vport.c +0 -0
index 258ce3b7b452..9e71f1a601a9 100644

net/openvswitch/vport.c int ovs_vport_set_options(struct vport *vport, struct nlattr *options) · line 266

Quoted 8 lines
net/openvswitch/vport.c +0 -2
@@ -261,8 +261,6 @@ int ovs_vport_set_options(struct vport *vport, struct nlattr *options)
   */
  void ovs_vport_del(struct vport *vport)
  {
-	ASSERT_OVSL();
-
  	hlist_del_rcu(&vport->hash_node);
  	module_put(vport->ops->owner);
  	vport->ops->destroy(vport);

LGTM