net: openvswitch: remove unnecessary ASSERT_OVSL in ovs_vport_del()
Subsystems (3)
PATCH 1/1 net: openvswitch: remove unnecessary ASSERT_OVSL in ovs_vport_del()
ASSERT_OVSL() in ovs_vport_del() is unnecessary because ovs_vport_del() is only called by ovs_dp_detach_port() and ovs_dp_detach_port() calls ASSERT_OVSL() too.
Signed-off-by Taehee Yoo <[email protected]>
--- net/openvswitch/vport.c | 2 -- 1 file changed, 2 deletions(-)
net/openvswitch/vport.c +0 -2
@@ -261,8 +261,6 @@ int ovs_vport_set_options(struct vport *vport, struct nlattr *options)*/ void ovs_vport_del (struct vport *vport) { -ASSERT_OVSL (); -hlist_del_rcu (&vport->hash_node);module_put (vport->ops->owner); vport->ops->destroy (vport);
Signature · 1 line
2.17.1
Quoted 14 lines · Taehee Yoo
ASSERT_OVSL()inovs_vport_del()is unnecessary becauseovs_vport_del()is only called byovs_dp_detach_port()andovs_dp_detach_port()callsASSERT_OVSL()too.Signed-off-by Taehee Yoo <[email protected]>--- net/openvswitch/vport.c | 2 -- 1 file changed, 2 deletions(-)net/openvswitch/vport.c +0
-0
net/openvswitch/vport.c int ovs_vport_set_options(struct vport *vport, struct nlattr *options) · line 266
Quoted 8 lines
net/openvswitch/vport.c +0
-2@@ -261,8 +261,6 @@ int ovs_vport_set_options(struct vport *vport, struct nlattr *options)*/ void ovs_vport_del (struct vport *vport) { -ASSERT_OVSL (); -hlist_del_rcu (&vport->hash_node);module_put (vport->ops->owner); vport->ops->destroy (vport);
LGTM
Reviewed-by Greg Rose <[email protected]>
From: Taehee Yoo <[email protected]>
Date: Mon, 10 Jun 2019 02:19:06 +0900
Quoted 5 lines
ASSERT_OVSL()inovs_vport_del()is unnecessary becauseovs_vport_del()is only called byovs_dp_detach_port()andovs_dp_detach_port()callsASSERT_OVSL()too.Signed-off-by Taehee Yoo <[email protected]>
Applied.