Skip to contentSkip to conversation

kea: replace -Og with -O

PATCH In review [email protected] 2 participants 4 messages Jun 10, 2019 – Jun 11, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kea: replace -Og with -O

From: Mingli Yu <[email protected]>

With below logic in local.conf:
MACHINE ??= "qemumips64" MULTILIB_GLOBAL_VARIANTS_append = " libn32" MULTILIBS ?= "multilib:lib32 multilib:libn32" DEFAULTTUNE_virtclass-multilib-lib32 ?= "mips" DEFAULTTUNE_virtclass-multilib-libn32 ?= "mips64-n32" require conf/multilib.conf
DEBUG_BUILD = "1"

 $ bitbake lib32-kea
[snip]
{standard input}: Assembler messages:
{standard input}:305030: Error: branch out of range
{standard input}:305041: Error: branch out of range
{standard input}:305432: Error: branch out of range
{standard input}:305443: Error: branch out of range
Makefile:707: recipe for target 'dhcp4_parser.lo' failed
make[6]: *** [dhcp4_parser.lo] Error 1
[snip]

When DEBUG_BUILD enabled, -Og pass to compiler, replace -Og with -O to fix the above compile error.

---
 meta-networking/recipes-connectivity/kea/kea_1.5.0.bb | 10 ++++++++++
 1 file changed, 10 insertions(+)
meta-networking/recipes-connectivity/kea/kea_1.5.0.bb +10 -0
index 9210ac1bc..fb166df60 100644
@@ -23,6 +23,16 @@ inherit autotools systemd
 SYSTEMD_SERVICE_${PN} = "kea-dhcp4.service kea-dhcp6.service kea-dhcp-ddns.service"
 SYSTEMD_AUTO_ENABLE = "disable"
 
+DEBUG_OPTIMIZATION_remove_mips = " -Og"
+DEBUG_OPTIMIZATION_append_mips = " -O"
+BUILD_OPTIMIZATION_remove_mips = " -Og"
+BUILD_OPTIMIZATION_append_mips = " -O"
+
+DEBUG_OPTIMIZATION_remove_mipsel = " -Og"
+DEBUG_OPTIMIZATION_append_mipsel = " -O"
+BUILD_OPTIMIZATION_remove_mipsel = " -Og"
+BUILD_OPTIMIZATION_append_mipsel = " -O"
+
 do_configure_prepend_class-target() {
     mkdir -p ${B}/src/lib/log/compiler/
     ln -sf ${STAGING_BINDIR_NATIVE}/kea-msg-compiler ${B}/src/lib/log/compiler/kea-msg-compiler
Signature · 1 line
2.21.0
#1 lore raw
Quoted 21 lines · On Mon, Jun 10, 2019 at 12:13:10AM -0700, [email protected] wrote:

From: Mingli Yu <[email protected]>

With below logic in local.conf:
MACHINE ??= "qemumips64" MULTILIB_GLOBAL_VARIANTS_append = " libn32" MULTILIBS ?= "multilib:lib32 multilib:libn32" DEFAULTTUNE_virtclass-multilib-lib32 ?= "mips" DEFAULTTUNE_virtclass-multilib-libn32 ?= "mips64-n32" require conf/multilib.conf
DEBUG_BUILD = "1"

 $ bitbake lib32-kea
[snip]
{standard input}: Assembler messages:
{standard input}:305030: Error: branch out of range
{standard input}:305041: Error: branch out of range
{standard input}:305432: Error: branch out of range
{standard input}:305443: Error: branch out of range
Makefile:707: recipe for target 'dhcp4_parser.lo' failed
make[6]: *** [dhcp4_parser.lo] Error 1
[snip]
Quoted 3 lines

When DEBUG_BUILD enabled, -Og pass to compiler, replace -Og with -O to fix the above compile error.
...

This sounds like a toolchain bug in gcc or binutils that should be fixed there.

I've opened #13387 in bugzilla so that this doesn't get lost.

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
author
#2 lore raw
Quoted 22 lines · Adrian Bunk
Quoted 21 lines · On Mon, Jun 10, 2019 at 12:13:10AM -0700, [email protected] wrote:

From: Mingli Yu <[email protected]>

With below logic in local.conf:
MACHINE ??= "qemumips64" MULTILIB_GLOBAL_VARIANTS_append = " libn32" MULTILIBS ?= "multilib:lib32 multilib:libn32" DEFAULTTUNE_virtclass-multilib-lib32 ?= "mips" DEFAULTTUNE_virtclass-multilib-libn32 ?= "mips64-n32" require conf/multilib.conf
DEBUG_BUILD = "1"

  $ bitbake lib32-kea
[snip]
{standard input}: Assembler messages:
{standard input}:305030: Error: branch out of range
{standard input}:305041: Error: branch out of range
{standard input}:305432: Error: branch out of range
{standard input}:305443: Error: branch out of range
Makefile:707: recipe for target 'dhcp4_parser.lo' failed
make[6]: *** [dhcp4_parser.lo] Error 1
[snip]
Quoted 8 lines
Quoted 3 lines

When DEBUG_BUILD enabled, -Og pass to compiler, replace -Og with -O to fix the above compile error.
...

This sounds like a toolchain bug in gcc or binutils that should be fixed there.

I've opened #13387 in bugzilla so that this doesn't get lost.

Could you help to post the link here about the issue you opened?

Thanks,

Quoted 4 lines

cu
Adrian

#3 lore raw
Quoted 29 lines · Mingli
Quoted 26 lines · Adrian Bunk
Quoted 24 lines · On Mon, Jun 10, 2019 at 12:13:10AM -0700, [email protected] wrote:

From: Mingli Yu <[email protected]>

With below logic in local.conf:
MACHINE ??= "qemumips64" MULTILIB_GLOBAL_VARIANTS_append = " libn32" MULTILIBS ?= "multilib:lib32 multilib:libn32" DEFAULTTUNE_virtclass-multilib-lib32 ?= "mips" DEFAULTTUNE_virtclass-multilib-libn32 ?= "mips64-n32" require conf/multilib.conf
DEBUG_BUILD = "1"

  $ bitbake lib32-kea
[snip]
{standard input}: Assembler messages:
{standard input}:305030: Error: branch out of range
{standard input}:305041: Error: branch out of range
{standard input}:305432: Error: branch out of range
{standard input}:305443: Error: branch out of range
Makefile:707: recipe for target 'dhcp4_parser.lo' failed
make[6]: *** [dhcp4_parser.lo] Error 1
[snip]

When DEBUG_BUILD enabled, -Og pass to compiler, replace -Og with -O to fix the above compile error.
...

Quoted 6 lines
Quoted 4 lines

This sounds like a toolchain bug in gcc or binutils that should be fixed there.

I've opened #13387 in bugzilla so that this doesn't get lost.

Could you help to post the link here about the issue you opened?

https://bugzilla.yoctoproject.org/show_bug.cgi?id=13387

Quoted 1 line

Thanks,

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed