Skip to contentSkip to conversation

imx8qm_mek: Remove unneeded config options settings

PATCH New Fabio Estevam 3 participants 6 messages May 8, 2019 – Jun 10, 2019 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/2 imx8qm_mek: Remove unneeded config options settings

Remove such unneeded custom config options because the provided default values are good enough.

---
 include/configs/imx8qm_mek.h | 9 ---------
 1 file changed, 9 deletions(-)
include/configs/imx8qm_mek.h +0 -9
index 02c5d1c054..fecfdf6289 100644
@@ -157,15 +157,6 @@
 /* Serial */
 #define CONFIG_BAUDRATE			115200
 
-/* Monitor Command Prompt */
-#define CONFIG_HUSH_PARSER
-#define CONFIG_SYS_PROMPT_HUSH_PS2     "> "
-#define CONFIG_SYS_CBSIZE              2048
-#define CONFIG_SYS_MAXARGS             64
-#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
-#define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
-					sizeof(CONFIG_SYS_PROMPT) + 16)
-
 /* Generic Timer Definitions */
 #define COUNTER_FREQUENCY		8000000	/* 8MHz */
 
Signature · 1 line
2.17.1
author reviewer
#1 lore raw

PATCH 2/2 imx8qxp_mek: Remove unneeded config options settings

Remove such unneeded custom config options because the provided default values are good enough.

---
 include/configs/imx8qxp_mek.h | 8 --------
 1 file changed, 8 deletions(-)
include/configs/imx8qxp_mek.h +0 -8
index 18ea5a8fb6..d52313cd7e 100644
@@ -157,14 +157,6 @@
 /* Serial */
 #define CONFIG_BAUDRATE			115200
 
-/* Monitor Command Prompt */
-#define CONFIG_SYS_PROMPT_HUSH_PS2     "> "
-#define CONFIG_SYS_CBSIZE              2048
-#define CONFIG_SYS_MAXARGS             64
-#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
-#define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
-					sizeof(CONFIG_SYS_PROMPT) + 16)
-
 /* Generic Timer Definitions */
 #define COUNTER_FREQUENCY		8000000	/* 8MHz */
 
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/2 imx8qxp_mek: Remove unneeded config options settings

Quoted 6 lines

Subject: [PATCH 2/2] imx8qxp_mek: Remove unneeded config options settings

Remove such unneeded custom config options because the provided default values are good enough.

Quoted 25 lines
---
 include/configs/imx8qxp_mek.h | 8 --------
 1 file changed, 8 deletions(-)
include/configs/imx8qxp_mek.h +0 -9
index 18ea5a8fb6..d52313cd7e 100644
@@ -157,14 +157,6 @@
 /* Serial */
 #define CONFIG_BAUDRATE			115200
 
-/* Monitor Command Prompt */
-#define CONFIG_SYS_PROMPT_HUSH_PS2     "> "
-#define CONFIG_SYS_CBSIZE              2048
-#define CONFIG_SYS_MAXARGS             64
-#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
-#define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
-					sizeof(CONFIG_SYS_PROMPT) + 16)
-
 /* Generic Timer Definitions */
 #define COUNTER_FREQUENCY		8000000	/* 8MHz */
 
--

2.17.1

#3 lore raw

PATCH 2/2 imx8qxp_mek: Remove unneeded config options

In reply to Fabio Estevam
Quoted 4 lines

Remove such unneeded custom config options because the provided default values are good enough.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#4 lore raw

PATCH 1/2 imx8qm_mek: Remove unneeded config options settings

In reply to Fabio Estevam
Quoted 6 lines

Subject: [PATCH 1/2] imx8qm_mek: Remove unneeded config options settings

Remove such unneeded custom config options because the provided default values are good enough.

Quoted 26 lines
---
 include/configs/imx8qm_mek.h | 9 ---------
 1 file changed, 9 deletions(-)
include/configs/imx8qm_mek.h +0 -10
index 02c5d1c054..fecfdf6289 100644
@@ -157,15 +157,6 @@
 /* Serial */
 #define CONFIG_BAUDRATE			115200
 
-/* Monitor Command Prompt */
-#define CONFIG_HUSH_PARSER
-#define CONFIG_SYS_PROMPT_HUSH_PS2     "> "
-#define CONFIG_SYS_CBSIZE              2048
-#define CONFIG_SYS_MAXARGS             64
-#define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
-#define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
-					sizeof(CONFIG_SYS_PROMPT) + 16)
-
 /* Generic Timer Definitions */
 #define COUNTER_FREQUENCY		8000000	/* 8MHz */
 
--

2.17.1

#5 lore raw

PATCH 1/2 imx8qm_mek: Remove unneeded config options settings <mailto:[email protected]?subject=unsubscribe> <mailto:[email protected]?subject=subscribe>

In reply to Fabio Estevam
Quoted 4 lines

Remove such unneeded custom config options because the provided default values are good enough.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================