Skip to contentSkip to conversation

opos6uldev: don't call enable_lcdif_clock

PATCH Superseded Sébastien Szymanski 3 participants 6 messages May 14, 2019 – Jun 10, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 opos6uldev: don't call enable_lcdif_clock

The mxsfb driver already calls enable_lcdif_clock.

---
 board/armadeus/opos6uldev/board.c | 3 ---
 1 file changed, 3 deletions(-)
board/armadeus/opos6uldev/board.c +0 -3
index 4faa997126..aed334f8fb 100644
@@ -3,7 +3,6 @@
  * Copyright (C) 2018 Armadeus Systems
  */
 
-#include <asm/arch/clock.h>
 #include <asm/arch/mx6-pins.h>
 #include <asm/arch/sys_proto.h>
 #include <asm/gpio.h>
@@ -49,8 +48,6 @@ int setup_lcd(void)
 	struct gpio_desc backlight;
 	int ret;
 
-	enable_lcdif_clock(LCDIF1_BASE_ADDR, 1);
-
 	imx_iomux_v3_setup_multiple_pads(lcd_pads, ARRAY_SIZE(lcd_pads));
 
 	/* Set Brightness to high */
Signature · 1 line
2.19.2
#1 lore raw

PATCH 2/2 opos6uldev: remove board_ehci_hcd_init function

It's useless on the opos6uldev. Remove it.

---
 board/armadeus/opos6uldev/board.c | 21 ---------------------
 1 file changed, 21 deletions(-)
board/armadeus/opos6uldev/board.c +0 -21
index aed334f8fb..cbf40d5c4a 100644
@@ -70,27 +70,6 @@ int setup_lcd(void)
 }
 #endif
 
-#ifdef CONFIG_USB_EHCI_MX6
-#define USB_OTHERREGS_OFFSET	0x800
-#define UCTRL_PWR_POL		(1 << 9)
-
-int board_ehci_hcd_init(int port)
-{
-	u32 *usbnc_usb_ctrl;
-
-	if (port > 1)
-		return -EINVAL;
-
-	usbnc_usb_ctrl = (u32 *)(USB_BASE_ADDR + USB_OTHERREGS_OFFSET +
-				 port * 4);
-
-	/* Set Power polarity */
-	setbits_le32(usbnc_usb_ctrl, UCTRL_PWR_POL);
-
-	return 0;
-}
-#endif
-
 int opos6ul_board_late_init(void)
 {
 #ifdef CONFIG_VIDEO_MXS
Signature · 1 line
2.19.2
#2 lore raw

PATCH 2/2 opos6uldev: remove board_ehci_hcd_init function

Quoted 2 lines · Sébastien Szymanski

It's useless on the opos6uldev. Remove it.

Why is it useless? No USB host on this port?

#3 lore raw

PATCH 2/2 opos6uldev: remove board_ehci_hcd_init function

Hi Fabio,

Quoted 6 lines · Fabio Estevam
Quoted 2 lines · Sébastien Szymanski

It's useless on the opos6uldev. Remove it.

Why is it useless? No USB host on this port?

There is an USB host port but this function was just setting the polarity of the PWR signal which is not used on the opos6uldev board.

I guess I should send a v2 with that explanation.

Regards,

Quoted 3 lines
Signature · 4 lines
Sébastien Szymanski
Software engineer, Armadeus Systems
Tel: +33 (0)9 72 29 41 44
Fax: +33 (0)9 72 28 79 26
#5 lore raw

PATCH 1/2 opos6uldev: don't call enable_lcdif_clock

In reply to Sébastien Szymanski
Quoted 3 lines

The mxsfb driver already calls enable_lcdif_clock.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================