toradex apalis/colibri: extend CONFIG_SYS_MALLOC_F_LEN
PATCH 1/1 toradex apalis/colibri: extend CONFIG_SYS_MALLOC_F_LEN
Extend size of the malloc() pool for use before relocation, from 0x400 (default one) to 0x2000 (CONFIG_SYS_MALLOC_F_LEN=0x2000),
as adding of DM_FLAG_PRE_RELOC flag to simple-bus driver introduced a regression on multiple boards, because of more intensive usage of malloc() pool and therefore a broken boot as the size of pool isn't sufficient.
--- configs/apalis-tk1_defconfig | 1 + configs/apalis_imx6_defconfig | 1 + configs/apalis_t30_defconfig | 1 + configs/colibri-imx6ull_defconfig | 1 + configs/colibri_imx6_defconfig | 1 + configs/colibri_imx7_defconfig | 1 + configs/colibri_imx7_emmc_defconfig | 1 + configs/colibri_pxa270_defconfig | 1 + configs/colibri_t20_defconfig | 1 + configs/colibri_t30_defconfig | 1 + configs/colibri_vf_defconfig | 2 +- 11 files changed, 11 insertions(+), 1 deletion(-)
configs/apalis-tk1_defconfig +1 -0
@@ -1,6 +1,7 @@ CONFIG_ARM=y CONFIG_TEGRA=y CONFIG_SYS_TEXT_BASE=0x80110000 +CONFIG_SYS_MALLOC_F_LEN=0x2000 CONFIG_NR_DRAM_BANKS=2 CONFIG_TEGRA124=y CONFIG_TARGET_APALIS_TK1=y
configs/apalis_imx6_defconfig +1 -0
@@ -1,6 +1,7 @@ CONFIG_ARM=y CONFIG_ARCH_MX6=y CONFIG_SYS_TEXT_BASE=0x17800000 +CONFIG_SYS_MALLOC_F_LEN=0x2000 CONFIG_SPL_GPIO_SUPPORT=y CONFIG_SPL_LIBCOMMON_SUPPORT=y CONFIG_SPL_LIBGENERIC_SUPPORT=y
configs/apalis_t30_defconfig +1 -0
@@ -1,6 +1,7 @@ CONFIG_ARM=y CONFIG_TEGRA=y CONFIG_SYS_TEXT_BASE=0x80110000 +CONFIG_SYS_MALLOC_F_LEN=0x2000 CONFIG_NR_DRAM_BANKS=2 CONFIG_TEGRA30=y CONFIG_TARGET_APALIS_T30=y
configs/colibri-imx6ull_defconfig +1 -0
@@ -2,6 +2,7 @@ CONFIG_ARM=y CONFIG_SYS_THUMB_BUILD=y CONFIG_ARCH_MX6=y CONFIG_SYS_TEXT_BASE=0x87800000 +CONFIG_SYS_MALLOC_F_LEN=0x2000 CONFIG_TARGET_COLIBRI_IMX6ULL=y CONFIG_NR_DRAM_BANKS=1 CONFIG_DISTRO_DEFAULTS=y
configs/colibri_imx6_defconfig +1 -0
@@ -1,6 +1,7 @@ CONFIG_ARM=y CONFIG_ARCH_MX6=y CONFIG_SYS_TEXT_BASE=0x17800000 +CONFIG_SYS_MALLOC_F_LEN=0x2000 CONFIG_SPL_GPIO_SUPPORT=y CONFIG_SPL_LIBCOMMON_SUPPORT=y CONFIG_SPL_LIBGENERIC_SUPPORT=y
configs/colibri_imx7_defconfig +1 -0
@@ -2,6 +2,7 @@ CONFIG_ARM=y CONFIG_SYS_THUMB_BUILD=y CONFIG_ARCH_MX7=y CONFIG_SYS_TEXT_BASE=0x87800000 +CONFIG_SYS_MALLOC_F_LEN=0x2000 CONFIG_SECURE_BOOT=y CONFIG_TARGET_COLIBRI_IMX7=y CONFIG_NR_DRAM_BANKS=1
configs/colibri_imx7_emmc_defconfig +1 -0
@@ -2,6 +2,7 @@ CONFIG_ARM=y CONFIG_SYS_THUMB_BUILD=y CONFIG_ARCH_MX7=y CONFIG_SYS_TEXT_BASE=0x87800000 +CONFIG_SYS_MALLOC_F_LEN=0x2000 CONFIG_SECURE_BOOT=y CONFIG_TARGET_COLIBRI_IMX7=y CONFIG_TARGET_COLIBRI_IMX7_EMMC=y
configs/colibri_pxa270_defconfig +1 -0
@@ -1,6 +1,7 @@ CONFIG_ARM=y CONFIG_TARGET_COLIBRI_PXA270=y CONFIG_SYS_TEXT_BASE=0x0 +CONFIG_SYS_MALLOC_F_LEN=0x2000 CONFIG_NR_DRAM_BANKS=1 CONFIG_ENV_VARS_UBOOT_CONFIG=y CONFIG_USE_BOOTARGS=y
configs/colibri_t20_defconfig +1 -0
@@ -1,6 +1,7 @@ CONFIG_ARM=y CONFIG_TEGRA=y CONFIG_SYS_TEXT_BASE=0x00110000 +CONFIG_SYS_MALLOC_F_LEN=0x2000 CONFIG_NR_DRAM_BANKS=2 CONFIG_TEGRA20=y CONFIG_TARGET_COLIBRI_T20=y
configs/colibri_t30_defconfig +1 -0
@@ -1,6 +1,7 @@ CONFIG_ARM=y CONFIG_TEGRA=y CONFIG_SYS_TEXT_BASE=0x80110000 +CONFIG_SYS_MALLOC_F_LEN=0x2000 CONFIG_NR_DRAM_BANKS=2 CONFIG_TEGRA30=y CONFIG_TARGET_COLIBRI_T30=y
configs/colibri_vf_defconfig +1 -1
@@ -2,7 +2,7 @@ CONFIG_ARM=y CONFIG_SYS_THUMB_BUILD=y CONFIG_ARCH_VF610=y CONFIG_SYS_TEXT_BASE=0x3f401000 -CONFIG_SYS_MALLOC_F_LEN=0x800 +CONFIG_SYS_MALLOC_F_LEN=0x2000 CONFIG_NR_DRAM_BANKS=1 CONFIG_TARGET_COLIBRI_VF=y CONFIG_ENV_VARS_UBOOT_CONFIG=y
Signature · 1 line
2.17.1
PATCH 1/1 toradex apalis/colibri: extend CONFIG_SYS_MALLOC_F_LEN
Quoted 9 lines · Igor Opaniuk
Extend size of the
malloc()pool for use before relocation, from0x400(default one) to0x2000(CONFIG_SYS_MALLOC_F_LEN=0x2000),
as adding ofDM_FLAG_PRE_RELOCflag to simple-bus driver introduced a regression on multiple boards, because of more intensive usage ofmalloc()pool and therefore a broken boot as the size of pool isn't sufficient.Fixes 3a7c45f6a7 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus")Signed-off-by Igor Opaniuk <[email protected]>
Quoted 14 lines
--- configs/apalis-tk1_defconfig | 1 + configs/apalis_imx6_defconfig | 1 + configs/apalis_t30_defconfig | 1 + configs/colibri-imx6ull_defconfig | 1 + configs/colibri_imx6_defconfig | 1 + configs/colibri_imx7_defconfig | 1 + configs/colibri_imx7_emmc_defconfig | 1 + configs/colibri_pxa270_defconfig | 1 + configs/colibri_t20_defconfig | 1 + configs/colibri_t30_defconfig | 1 + configs/colibri_vf_defconfig | 2 +- 11 files changed, 11 insertions(+), 1 deletion(-)
Fabio Estevam
reviewerPATCH 1/1 toradex apalis/colibri: extend CONFIG_SYS_MALLOC_F_LEN
In reply to Igor OpaniukHi Igor,
Quoted 9 lines · Igor Opaniuk
Extend size of the
malloc()pool for use before relocation, from0x400(default one) to0x2000(CONFIG_SYS_MALLOC_F_LEN=0x2000),
as adding ofDM_FLAG_PRE_RELOCflag to simple-bus driver introduced a regression on multiple boards, because of more intensive usage ofmalloc()pool and therefore a broken boot as the size of pool isn't sufficient.Fixes 3a7c45f6a7 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus")Signed-off-by Igor Opaniuk <[email protected]>
I have already sent a fix for this issue:
https://lists.denx.de/pipermail/u-boot/2019-May/367839.html
Thanks
PATCH 1/1 toradex apalis/colibri: extend CONFIG_SYS_MALLOC_F_LEN
Quoted 14 lines · Fabio Estevam
Hi Igor,
Quoted 10 lines · Igor Opaniuk
Extend size of the
malloc()pool for use before relocation, from0x400
(default one) to0x2000(CONFIG_SYS_MALLOC_F_LEN=0x2000), as adding ofDM_FLAG_PRE_RELOCflag to simple-bus driver introduced a
regression on multiple boards, because of more intensive usage ofmalloc()
pool and therefore a broken boot as the size of pool isn't sufficient.
Quoted 6 lines
Quoted 3 lines
Fixes 3a7c45f6a7 ("simple-bus: add DM_FLAG_PRE_RELOC flag tosimple-bus")
Signed-off-by Igor Opaniuk <[email protected]>I have already sent a fix for this issue:
https://lists.denx.de/pipermail/u-boot/2019-May/367839.html
Ah, cool. But I believe on i.MX 8QM not even 0x2000 is/was enough but I rather had/have to increase it to 0x4000 (which BTW: Peng had already increased it to on i.MX 8QXP (;-p).
commit e5b8f7e665aa ("imx8qxp: mek: enable dm-spl for pm")
Quoted 1 line
Thanks
PATCH 1/1 toradex apalis/colibri: extend CONFIG_SYS_MALLOC_F_LEN
In reply to Fabio EstevamQuoted 14 lines · Fabio Estevam
Hi Igor,
Quoted 10 lines · Igor Opaniuk
Extend size of the
malloc()pool for use before relocation, from0x400
(default one) to0x2000(CONFIG_SYS_MALLOC_F_LEN=0x2000), as adding ofDM_FLAG_PRE_RELOCflag to simple-bus driver introduced a
regression on multiple boards, because of more intensive usage ofmalloc()
pool and therefore a broken boot as the size of pool isn't sufficient.
Quoted 6 lines
Quoted 3 lines
Fixes 3a7c45f6a7 ("simple-bus: add DM_FLAG_PRE_RELOC flag tosimple-bus")
Signed-off-by Igor Opaniuk <[email protected]>I have already sent a fix for this issue:
https://lists.denx.de/pipermail/u-boot/2019-May/367839.html
And then BTW this also does not fix it should one already manually have set a different but too small value ins his board configuration!
Quoted 1 line
Thanks
PATCH 1/1 toradex apalis/colibri: extend
In reply to Igor OpaniukQuoted 8 lines
Extend size of the
malloc()pool for use before relocation, from0x400(default one) to0x2000(CONFIG_SYS_MALLOC_F_LEN=0x2000),
as adding ofDM_FLAG_PRE_RELOCflag to simple-bus driver introduced a regression on multiple boards, because of more intensive usage ofmalloc()pool and therefore a broken boot as the size of pool isn't sufficient.Fixes 3a7c45f6a7 ("simple-bus: add DM_FLAG_PRE_RELOC flag to simple-bus")Signed-off-by Igor Opaniuk <[email protected]>Reviewed-by Bin Meng <[email protected]>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================