Skip to contentSkip to conversation

wandboard: Rework Makefile to prevent spl.o from being built

PATCH New Ezequiel Garcia 2 participants 2 messages May 25, 2019 – Jun 10, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 wandboard: Rework Makefile to prevent spl.o from being built

The spl.c source was entirely conditioned by CONFIG_SPL_BUILD. Change this moving CONFIG_SPL_BUILD to be used in the Makefile, which is slightly cleaner and more readable.

---
 board/wandboard/Makefile | 3 ++-
 board/wandboard/spl.c    | 3 ---
 2 files changed, 2 insertions(+), 4 deletions(-)
board/wandboard/Makefile +2 -1
index 6e886f729a85..c3d80536b3a3 100644
@@ -2,4 +2,5 @@
 #
 # (C) Copyright 2013 Freescale Semiconductor, Inc.
 
-obj-y  := wandboard.o spl.o
+obj-y  := wandboard.o
+obj-$(CONFIG_SPL_BUILD) += spl.o
board/wandboard/spl.c +0 -3
index 000cb109fc15..7b0f15a5c4d1 100644
@@ -20,7 +20,6 @@
 #include <asm/arch/sys_proto.h>
 #include <spl.h>
 
-#if defined(CONFIG_SPL_BUILD)
 #include <asm/arch/mx6-ddr.h>
 /*
  * Driving strength:
@@ -513,5 +512,3 @@ int board_mmc_init(bd_t *bis)
 
 	return 0;
 }
-
-#endif
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 wandboard: Rework Makefile to prevent spl.o from

Quoted 4 lines

The spl.c source was entirely conditioned by CONFIG_SPL_BUILD. Change this moving CONFIG_SPL_BUILD to be used in the Makefile, which is slightly cleaner and more readable.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================