drm/i915: Eliminate unused mmio accessors
Subsystems (2)
PATCH 1/6 drm/i915: Eliminate unused mmio accessors
From: Tvrtko Ursulin <[email protected]>
On the path of removing mmio accessors with implicit dev_priv, easy first step is to remove all such unused macros.
--- drivers/gpu/drm/i915/i915_drv.h | 4 ---- 1 file changed, 4 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +0 -4
@@ -2842,12 +2842,9 @@ extern void intel_display_print_error_state(struct drm_i915_error_state_buf *e, intel_uncore_##op__(&(dev_priv__)->uncore, __VA_ARGS__)#define I915_READ8 (reg__) __I915_REG_OP(read8, dev_priv, (reg__)) -#define I915_WRITE8 (reg__, val__) __I915_REG_OP(write8, dev_priv, (reg__), (val__))#define I915_READ16 (reg__) __I915_REG_OP(read16, dev_priv, (reg__))#define I915_WRITE16 (reg__, val__) __I915_REG_OP(write16, dev_priv, (reg__), (val__)) -#define I915_READ16_NOTRACE (reg__) __I915_REG_OP(read16_notrace, dev_priv, (reg__)) -#define I915_WRITE16_NOTRACE (reg__, val__) __I915_REG_OP(write16_notrace, dev_priv, (reg__), (val__))#define I915_READ (reg__) __I915_REG_OP(read, dev_priv, (reg__))#define I915_WRITE (reg__, val__) __I915_REG_OP(write, dev_priv, (reg__), (val__))
@@ -2903,7 +2900,6 @@ extern void intel_display_print_error_state(struct drm_i915_error_state_buf *e,*/ #define I915_READ_FW (reg__) __I915_REG_OP(read_fw, dev_priv, (reg__))#define I915_WRITE_FW (reg__, val__) __I915_REG_OP(write_fw, dev_priv, (reg__), (val__)) -#define I915_WRITE64_FW (reg__, val__) __I915_REG_OP(write64_fw, dev_priv, (reg__), (val__))#define POSTING_READ_FW (reg__) __I915_REG_OP(posting_read_fw, dev_priv, (reg__))/* "Broadcast RGB" property */
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/6 drm/i915: Convert i915_reg_read_ioctl to use explicit mmio accessors
From: Tvrtko Ursulin <[email protected]>
No excuse for code located in intel_uncore.c to not use intel_uncore_ helpers.
--- drivers/gpu/drm/i915/intel_uncore.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/intel_uncore.c +14 -9
@@ -1672,7 +1672,8 @@ static const struct reg_whitelist {int i915_reg_read_ioctl (struct drm_device *dev,void *data,struct drm_file *file) { -struct drm_i915_private *dev_priv =to_i915 (dev); +struct drm_i915_private *i915 =to_i915 (dev); +struct intel_uncore *uncore = &i915->uncore;struct drm_i915_reg_read *reg = data;struct reg_whitelist const *entry;intel_wakeref_t wakeref;
@@ -1689,7 +1690,7 @@ int i915_reg_read_ioctl(struct drm_device *dev,GEM_BUG_ON (entry->size >8 );GEM_BUG_ON (entry_offset & (entry->size -1 )); -if (INTEL_INFO (dev_priv)->gen_mask & entry->gen_mask && +if (INTEL_INFO (i915)->gen_mask & entry->gen_mask && entry_offset == (reg->offset & -entry->size))break ; entry++;
@@ -1701,18 +1702,22 @@ int i915_reg_read_ioctl(struct drm_device *dev, flags = reg->offset & (entry->size -1 ); - with_intel_runtime_pm(dev_priv, wakeref) { + with_intel_runtime_pm(i915, wakeref) {if (entry->size ==8 && flags ==I915_REG_READ_8B_WA ) - reg->val =I915_READ64_2x32 (entry->offset_ldw, - entry->offset_udw); + reg->val =intel_uncore_read64_2x32 (uncore, + entry->offset_ldw, + entry->offset_udw);else if (entry->size ==8 && flags ==0 ) - reg->val =I915_READ64 (entry->offset_ldw); + reg->val =intel_uncore_read64 (uncore, + entry->offset_ldw);else if (entry->size ==4 && flags ==0 ) - reg->val =I915_READ (entry->offset_ldw); + reg->val =intel_uncore_read (uncore, entry->offset_ldw);else if (entry->size ==2 && flags ==0 ) - reg->val =I915_READ16 (entry->offset_ldw); + reg->val =intel_uncore_read16 (uncore, + entry->offset_ldw);else if (entry->size ==1 && flags ==0 ) - reg->val =I915_READ8 (entry->offset_ldw); + reg->val =intel_uncore_read8 (uncore, + entry->offset_ldw);else ret = -EINVAL ; }
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/6 drm/i915: Convert icl_get_stolen_reserved to uncore mmio accessors
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
More removal of implicit dev_priv.
--- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_stolen.c +2 -2
@@ -325,11 +325,11 @@ static void bdw_get_stolen_reserved(struct drm_i915_private *dev_priv, *size = stolen_top - *base; } -static void icl_get_stolen_reserved (struct drm_i915_private *dev_priv, +static void icl_get_stolen_reserved (struct drm_i915_private *i915,resource_size_t *base,resource_size_t *size) { -u64 reg_val =I915_READ64 (GEN6_STOLEN_RESERVED ); +u64 reg_val =intel_uncore_read64 (&i915->uncore,GEN6_STOLEN_RESERVED );DRM_DEBUG_DRIVER ("GEN6_STOLEN_RESERVED = 0x%016llx\n" , reg_val);
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/6 drm/i915: Convert gem_record_fences to uncore mmio accessors
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
More implicit dev_priv removal.
--- drivers/gpu/drm/i915/i915_gpu_error.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_gpu_error.c +9 -3
@@ -1123,17 +1123,23 @@ static u32 i915_error_generate_code(struct i915_gpu_state *error,static void gem_record_fences (struct i915_gpu_state *error) {struct drm_i915_private *dev_priv = error->i915; +struct intel_uncore *uncore = &dev_priv->uncore;int i;if (INTEL_GEN (dev_priv) >=6 ) {for (i =0 ; i < dev_priv->num_fence_regs; i++) - error->fence[i] =I915_READ64 (FENCE_REG_GEN6_LO (i)); + error->fence[i] = +intel_uncore_read64 (uncore, +FENCE_REG_GEN6_LO (i)); }else if (INTEL_GEN (dev_priv) >=4 ) {for (i =0 ; i < dev_priv->num_fence_regs; i++) - error->fence[i] =I915_READ64 (FENCE_REG_965_LO (i)); + error->fence[i] = +intel_uncore_read64 (uncore, +FENCE_REG_965_LO (i)); }else {for (i =0 ; i < dev_priv->num_fence_regs; i++) - error->fence[i] =I915_READ (FENCE_REG (i)); + error->fence[i] = +intel_uncore_read (uncore,FENCE_REG (i)); } error->nfence = i; }
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/6 drm/i915: Convert intel_read_wm_latency to uncore mmio accessors
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
More implicit dev_priv removal.
--- drivers/gpu/drm/i915/intel_pm.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +5 -3
@@ -2813,6 +2813,8 @@ hsw_compute_linetime_wm(const struct intel_crtc_state *cstate)static void intel_read_wm_latency (struct drm_i915_private *dev_priv,u16 wm[8 ]) { +struct intel_uncore *uncore = &dev_priv->uncore; +if (INTEL_GEN (dev_priv) >=9 ) {u32 val;int ret, i;
@@ -2894,7 +2896,7 @@ static void intel_read_wm_latency(struct drm_i915_private *dev_priv, wm[0 ] +=1 ; }else if (IS_HASWELL (dev_priv) ||IS_BROADWELL (dev_priv)) { -u64 sskpd =I915_READ64 (MCH_SSKPD ); +u64 sskpd =intel_uncore_read64 (uncore,MCH_SSKPD ); wm[0 ] = (sskpd >>56 ) &0xFF ;if (wm[0 ] ==0 )
@@ -2904,14 +2906,14 @@ static void intel_read_wm_latency(struct drm_i915_private *dev_priv, wm[3 ] = (sskpd >>20 ) &0x1FF ; wm[4 ] = (sskpd >>32 ) &0x1FF ; }else if (INTEL_GEN (dev_priv) >=6 ) { -u32 sskpd =I915_READ (MCH_SSKPD ); +u32 sskpd =intel_uncore_read (uncore,MCH_SSKPD ); wm[0 ] = (sskpd >>SSKPD_WM0_SHIFT ) &SSKPD_WM_MASK ; wm[1 ] = (sskpd >>SSKPD_WM1_SHIFT ) &SSKPD_WM_MASK ; wm[2 ] = (sskpd >>SSKPD_WM2_SHIFT ) &SSKPD_WM_MASK ; wm[3 ] = (sskpd >>SSKPD_WM3_SHIFT ) &SSKPD_WM_MASK ; }else if (INTEL_GEN (dev_priv) >=5 ) { -u32 mltr =I915_READ (MLTR_ILK ); +u32 mltr =intel_uncore_read (uncore,MLTR_ILK );/* ILK primary LP0 latency is 700 ns */ wm[0 ] =7 ;
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 6/6 drm/i915: Remove I915_READ64 and I915_READ64_32x2
In reply to Tvrtko UrsulinFrom: Tvrtko Ursulin <[email protected]>
Now that all their users are gone we can remove the macros and accompanying duplicated comment.
--- drivers/gpu/drm/i915/i915_drv.h | 18 ------------------ 1 file changed, 18 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +0 -18
@@ -2851,24 +2851,6 @@ extern void intel_display_print_error_state(struct drm_i915_error_state_buf *e,#define I915_READ_NOTRACE (reg__) __I915_REG_OP(read_notrace, dev_priv, (reg__))#define I915_WRITE_NOTRACE (reg__, val__) __I915_REG_OP(write_notrace, dev_priv, (reg__), (val__)) -/* Be very careful with read/write 64-bit values. On 32-bit machines, they -* will be implemented using 2 32-bit writes in an arbitrary order with -* an arbitrary delay between them. This can cause the hardware to -* act upon the intermediate value, possibly leading to corruption and -* machine death. For this reason we do not support I915_WRITE64, or -* dev_priv->uncore.funcs.mmio_writeq. -* -* When reading a 64-bit value as two 32-bit values, the delay may cause -* the two reads to mismatch, e.g. a timestamp overflowing. Also note that -* occasionally a 64-bit register does not actualy support a full readq -* and must be read using two 32-bit reads. -* -* You have been warned. -*/ -#define I915_READ64 (reg__) __I915_REG_OP(read64, dev_priv, (reg__)) -#define I915_READ64_2x32 (lower_reg__, upper_reg__) \ - __I915_REG_OP(read64_2x32, dev_priv, (lower_reg__), (upper_reg__)) -#define POSTING_READ (reg__) __I915_REG_OP(posting_read, dev_priv, (reg__))#define POSTING_READ16 (reg__) __I915_REG_OP(posting_read16, dev_priv, (reg__))
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [CI 6/6] drm/i915: Remove I915_READ64 and I915_READ64_32x2
Quoted 23 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Now that all their users are gone we can remove the macros and accompanying duplicated comment.
Signed-off-by Tvrtko Ursulin <[email protected]>Suggested-by Jani Nikula <[email protected]>Reviewed-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/i915_drv.h | 18 ------------------ 1 file changed, 18 deletions(-)drivers/gpu/drm/i915/i915_drv.h +0
-3@@ -2851,24 +2851,6 @@ extern void intel_display_print_error_state(struct drm_i915_error_state_buf *e,#define I915_READ_NOTRACE (reg__) __I915_REG_OP(read_notrace, dev_priv, (reg__))#define I915_WRITE_NOTRACE (reg__, val__) __I915_REG_OP(write_notrace, dev_priv, (reg__), (val__)) -/* Be very careful with read/write 64-bit values. On 32-bit machines, they -* will be implemented using 2 32-bit writes in an arbitrary order with -* an arbitrary delay between them. This can cause the hardware to
drivers/gpu/drm/i915/i915_drv.h extern void intel_display_print_error_state(struct drm_i915_error_state_buf *e, · line 2866
Quoted 10 lines
drivers/gpu/drm/i915/i915_drv.h +0
-10-* act upon the intermediate value, possibly leading to corruption and -* machine death. For this reason we do not support I915_WRITE64, or -* dev_priv->uncore.funcs.mmio_writeq. -* -* When reading a 64-bit value as two 32-bit values, the delay may cause -* the two reads to mismatch, e.g. a timestamp overflowing. Also note that -* occasionally a 64-bit register does not actualy support a full readq -* and must be read using two 32-bit reads. -* -* You have been warned.
We are no longer warned?
Quoted 15 lines
drivers/gpu/drm/i915/i915_drv.h +0
-5-*/ -#define I915_READ64 (reg__) __I915_REG_OP(read64, dev_priv, (reg__)) -#define I915_READ64_2x32 (lower_reg__, upper_reg__) \ - __I915_REG_OP(read64_2x32, dev_priv, (lower_reg__), (upper_reg__)) -#define POSTING_READ (reg__) __I915_REG_OP(posting_read, dev_priv, (reg__))#define POSTING_READ16 (reg__) __I915_REG_OP(posting_read16, dev_priv, (reg__))Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [CI 6/6] drm/i915: Remove I915_READ64 and I915_READ64_32x2
Quoted 21 lines · Ville Syrjälä
Quoted 20 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Now that all their users are gone we can remove the macros and accompanying duplicated comment.
Signed-off-by Tvrtko Ursulin <[email protected]>Suggested-by Jani Nikula <[email protected]>Reviewed-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/i915_drv.h | 18 ------------------ 1 file changed, 18 deletions(-)drivers/gpu/drm/i915/i915_drv.h +0
-0@@ -2851,24 +2851,6 @@ extern void intel_display_print_error_state(struct drm_i915_error_state_buf *e,#define I915_READ_NOTRACE (reg__) __I915_REG_OP(read_notrace, dev_priv, (reg__))#define I915_WRITE_NOTRACE (reg__, val__) __I915_REG_OP(write_notrace, dev_priv, (reg__), (val__))
Quoted 15 lines
drivers/gpu/drm/i915/i915_drv.h extern void intel_display_print_error_state(struct drm_i915_error_state_buf *e, · line 2866
Quoted 13 lines
drivers/gpu/drm/i915/i915_drv.h +0
-13-/* Be very careful with read/write 64-bit values. On 32-bit machines, they -* will be implemented using 2 32-bit writes in an arbitrary order with -* an arbitrary delay between them. This can cause the hardware to -* act upon the intermediate value, possibly leading to corruption and -* machine death. For this reason we do not support I915_WRITE64, or -* dev_priv->uncore.funcs.mmio_writeq. -* -* When reading a 64-bit value as two 32-bit values, the delay may cause -* the two reads to mismatch, e.g. a timestamp overflowing. Also note that -* occasionally a 64-bit register does not actualy support a full readq -* and must be read using two 32-bit reads. -* -* You have been warned. We are no longer warned?
Clue is in the word duplicated in the commit message. ;) The exact same comment exists over in intel_uncore.h above 64-bit accessors and intel_uncore_read_2x32.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [CI,1/6] drm/i915: Eliminate unused mmio accessors
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: series starting with [CI,1/6] drm/i915: Eliminate unused mmio accessors
URL : https://patchwork.freedesktop.org/series/61837/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6225 -> Patchwork_13221
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/
Known issues
------------
Here are the changes found in Patchwork_13221 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/fi-icl-u3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/fi-icl-u3/igt@[email protected]
* igt@i915_selftest@live_contexts:
- fi-bdw-gvtdvm: [PASS][3] -> [DMESG-FAIL][4] ([fdo#110235])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/fi-bdw-gvtdvm/igt@i915_selftest@live_contexts.html
* igt@kms_chamelium@dp-crc-fast:
- fi-cml-u2: [PASS][5] -> [FAIL][6] ([fdo#110627])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/fi-cml-u2/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/fi-cml-u2/igt@[email protected]
* igt@prime_vgem@basic-fence-flip:
- fi-ilk-650: [PASS][7] -> [DMESG-WARN][8] ([fdo#106387])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/fi-ilk-650/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/fi-ilk-650/igt@[email protected]
#### Possible fixes ####
* igt@gem_render_linear_blits@basic:
- fi-icl-u3: [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/fi-icl-u3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/fi-icl-u3/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][11] ([fdo#109485]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/fi-kbl-7500u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/fi-kbl-7500u/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [DMESG-WARN][13] ([fdo#102614]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/fi-hsw-peppy/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/fi-hsw-peppy/igt@[email protected]
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
[fdo#110235]: https://bugs.freedesktop.org/show_bug.cgi?id=110235
[fdo#110627]: https://bugs.freedesktop.org/show_bug.cgi?id=110627
Participating hosts (54 -> 46)
------------------------------
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-guc fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_6225 -> Patchwork_13221
CI_DRM_6225: 39bb7459567aada2e706e4da4a650dc4f7c41abf @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5049: db51cbba5a8f4856d6f56a61aa51fda6e239fa44 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13221: b3503871099b78edee8540aef4424a3953c007f9 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b3503871099b drm/i915: Remove I915_READ64 and I915_READ64_32x2 a7f81beb69a9 drm/i915: Convert intel_read_wm_latency to uncore mmio accessors 703459e5963e drm/i915: Convert gem_record_fences to uncore mmio accessors d037c5131c56 drm/i915: Convert icl_get_stolen_reserved to uncore mmio accessors 09b3958cd6f7 drm/i915: Convert i915_reg_read_ioctl to use explicit mmio accessors 5e5709d97f13 drm/i915: Eliminate unused mmio accessors
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for series starting with [CI,1/6] drm/i915: Eliminate unused mmio accessors
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: series starting with [CI,1/6] drm/i915: Eliminate unused mmio accessors
URL : https://patchwork.freedesktop.org/series/61837/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6225_full -> Patchwork_13221_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_13221_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* {igt@gem_ctx_engines@independent}:
- shard-hsw: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-hsw1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-hsw8/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_13221_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@drm_read@invalid-buffer:
- shard-snb: [PASS][3] -> [SKIP][4] ([fdo#109271]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-snb7/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-snb2/igt@[email protected]
* igt@gem_ctx_engines@execute-one:
- shard-skl: [PASS][5] -> [DMESG-WARN][6] ([fdo#110869])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-skl4/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-skl4/igt@[email protected]
- shard-glk: [PASS][7] -> [DMESG-WARN][8] ([fdo#110869])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-glk5/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-glk1/igt@[email protected]
* igt@gem_tiled_swapping@non-threaded:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([fdo#108686])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-kbl4/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-kbl4/igt@[email protected]
* igt@i915_suspend@forcewake:
- shard-apl: [PASS][11] -> [DMESG-WARN][12] ([fdo#108566])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-apl8/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-apl5/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [PASS][13] -> [FAIL][14] ([fdo#104873])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-glk4/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-glk2/igt@[email protected]
* igt@kms_flip@2x-flip-vs-suspend-interruptible:
- shard-hsw: [PASS][15] -> [INCOMPLETE][16] ([fdo#103540])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-hsw6/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-hsw2/igt@[email protected]
* igt@kms_flip@2x-wf_vblank-ts-check:
- shard-hsw: [PASS][17] -> [SKIP][18] ([fdo#109271]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-hsw4/igt@kms_flip@2x-wf_vblank-ts-check.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-hsw1/igt@kms_flip@2x-wf_vblank-ts-check.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: [PASS][19] -> [FAIL][20] ([fdo#102887] / [fdo#105363])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-glk4/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-glk2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: [PASS][21] -> [FAIL][22] ([fdo#103167])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-apl2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-apl5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt:
- shard-iclb: [PASS][23] -> [FAIL][24] ([fdo#103167]) +6 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-shrfb-plflip-blt.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][25] -> [FAIL][26] ([fdo#103166])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-iclb5/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-iclb5/igt@[email protected]
* igt@kms_setmode@basic:
- shard-apl: [PASS][27] -> [FAIL][28] ([fdo#99912])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-apl4/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-apl7/igt@[email protected]
* igt@perf@polling:
- shard-skl: [PASS][29] -> [FAIL][30] ([fdo#110728])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-skl2/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-skl5/igt@[email protected]
#### Possible fixes ####
* igt@gem_eio@in-flight-suspend:
- shard-skl: [INCOMPLETE][31] ([fdo#104108]) -> [PASS][32] +2 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-skl4/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-skl1/igt@[email protected]
* {igt@gem_exec_balancer@smoke}:
- shard-iclb: [SKIP][33] ([fdo#110854]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-iclb6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-iclb1/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-kbl: [DMESG-WARN][35] ([fdo#108566]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-kbl6/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-kbl4/igt@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][37] ([fdo#105363]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-glk1/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-glk8/igt@[email protected]
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-hsw: [SKIP][39] ([fdo#109271]) -> [PASS][40] +33 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-hsw1/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-hsw8/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [FAIL][41] ([fdo#105363]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-skl9/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-skl1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-iclb: [FAIL][43] ([fdo#103167]) -> [PASS][44] +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-iclb6/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-iclb3/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [DMESG-WARN][45] ([fdo#108566]) -> [PASS][46] +5 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-apl7/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-apl2/igt@[email protected]
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][47] ([fdo#99912]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-kbl2/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-kbl6/igt@[email protected]
* igt@kms_sysfs_edid_timing:
- shard-iclb: [FAIL][49] ([fdo#100047]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-iclb3/igt@kms_sysfs_edid_timing.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-iclb8/igt@kms_sysfs_edid_timing.html
#### Warnings ####
* igt@gem_mmap_gtt@forked-big-copy-xy:
- shard-iclb: [TIMEOUT][51] ([fdo#109673]) -> [INCOMPLETE][52] ([fdo#107713] / [fdo#109100])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-iclb1/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-iclb7/igt@[email protected]
* igt@i915_pm_rpm@modeset-non-lpsp:
- shard-iclb: [SKIP][53] ([fdo#109308]) -> [SKIP][54] ([fdo#110892]) +3 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-iclb4/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/shard-iclb1/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109673]: https://bugs.freedesktop.org/show_bug.cgi?id=109673
[fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#110869]: https://bugs.freedesktop.org/show_bug.cgi?id=110869
[fdo#110892]: https://bugs.freedesktop.org/show_bug.cgi?id=110892
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_6225 -> Patchwork_13221
CI_DRM_6225: 39bb7459567aada2e706e4da4a650dc4f7c41abf @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5049: db51cbba5a8f4856d6f56a61aa51fda6e239fa44 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13221: b3503871099b78edee8540aef4424a3953c007f9 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13221/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx