drm/i915/hangcheck: Look at instdone for all engines
Subsystems (2)
RFC 1/1 drm/i915/hangcheck: Look at instdone for all engines
From: Tvrtko Ursulin <[email protected]>
It seems intel_engine_get_instdone is able to get instdone for all engines but intel_hangcheck.c/subunits_stuck decides to ignore it for non render.
We can just drop the check in subunits_stuck since the checks on unavailable fields will always return stuck, which when bitwise and with the potential unstuck instdone is harmless.
---
Would actually using the available data improve hang detection?
--- drivers/gpu/drm/i915/gt/intel_hangcheck.c | 3 --- 1 file changed, 3 deletions(-)
drivers/gpu/drm/i915/gt/intel_hangcheck.c +0 -3
@@ -57,9 +57,6 @@ static bool subunits_stuck(struct intel_engine_cs *engine)int slice;int subslice; -if (engine->id !=RCS0 ) -return true; -intel_engine_get_instdone (engine, &instdone);/* There might be unstable subunit states even when
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Tvrtko Ursulin (2019-06-10 14:01:10)
Quoted 9 lines
From: Tvrtko Ursulin <[email protected]>
It seems
intel_engine_get_instdoneis able to get instdone for all engines but intel_hangcheck.c/subunits_stuck decides to ignore it for non render.We can just drop the check in
subunits_stucksince the checks on unavailable fields will always return stuck, which when bitwise and with the potential unstuck instdone is harmless.
Quoted 5 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc Chris Wilson <[email protected]>Cc Mika Kuoppala <[email protected]>---
Would actually using the available data improve hang detection?
No, just prolong it :)
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 10 lines · Chris Wilson
Quoting Tvrtko Ursulin (2019-06-10 14:01:10)
Quoted 9 lines
From: Tvrtko Ursulin <[email protected]>
It seems
intel_engine_get_instdoneis able to get instdone for all engines but intel_hangcheck.c/subunits_stuck decides to ignore it for non render.We can just drop the check in
subunits_stucksince the checks on unavailable fields will always return stuck, which when bitwise and with the potential unstuck instdone is harmless.
Quoted 7 lines
Quoted 5 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc Chris Wilson <[email protected]>Cc Mika Kuoppala <[email protected]>---
Would actually using the available data improve hang detection?No, just prolong it :)
I was thinking activity on instdone would, but correctly so, no? If functional blocks have shown a change of status, then we try again until they too get stuck. Some improvement in false positives, but marginal I know given the hangcheck period.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Tvrtko Ursulin (2019-06-10 14:16:32)
Quoted 18 lines · Chris Wilson
Quoted 16 lines
Quoting Tvrtko Ursulin (2019-06-10 14:01:10)
Quoted 14 lines
From: Tvrtko Ursulin <[email protected]>
It seems
intel_engine_get_instdoneis able to get instdone for all engines but intel_hangcheck.c/subunits_stuck decides to ignore it for non render.We can just drop the check in
subunits_stucksince the checks on unavailable fields will always return stuck, which when bitwise and with the potential unstuck instdone is harmless.Signed-off-by Tvrtko Ursulin <[email protected]>Cc Chris Wilson <[email protected]>Cc Mika Kuoppala <[email protected]>---
Would actually using the available data improve hang detection?
Quoted 6 lines
Quoted 1 line
No, just prolong it :)
I was thinking activity on instdone would, but correctly so, no? If functional blocks have shown a change of status, then we try again until they too get stuck. Some improvement in false positives, but marginal I know given the hangcheck period.
It's a lot more fuzzy when you look at how we OR together the bits for the history. Not that you are wrong, just being an old curmudgeon. I'm not really sold on whether it makes any sense at the granularity of our inspection, currently sampling every ~1.5s.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/hangcheck: Look at instdone for all engines
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915/hangcheck: Look at instdone for all engines
URL : https://patchwork.freedesktop.org/series/61843/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6225 -> Patchwork_13223
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/
Known issues
------------
Here are the changes found in Patchwork_13223 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_reloc@basic-cpu-noreloc:
- fi-icl-dsi: [PASS][1] -> [DMESG-WARN][2] ([fdo#106107])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/fi-icl-dsi/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/fi-icl-dsi/igt@[email protected]
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [PASS][3] -> [INCOMPLETE][4] ([fdo#107718])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/fi-blb-e6850/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/fi-blb-e6850/igt@[email protected]
* igt@kms_busy@basic-flip-c:
- fi-icl-u3: [PASS][5] -> [DMESG-WARN][6] ([fdo#107724]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/fi-icl-u3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/fi-icl-u3/igt@[email protected]
#### Possible fixes ####
* igt@gem_render_linear_blits@basic:
- fi-icl-u3: [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/fi-icl-u3/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/fi-icl-u3/igt@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [DMESG-WARN][9] ([fdo#102614]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/fi-hsw-peppy/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/fi-hsw-peppy/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
Participating hosts (54 -> 47)
------------------------------
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_6225 -> Patchwork_13223
CI_DRM_6225: 39bb7459567aada2e706e4da4a650dc4f7c41abf @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5049: db51cbba5a8f4856d6f56a61aa51fda6e239fa44 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13223: 9f96a3a7fe4dd163a8524c35ff18f207f2a87ba0 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9f96a3a7fe4d drm/i915/hangcheck: Look at instdone for all engines
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/i915/hangcheck: Look at instdone for all engines
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915/hangcheck: Look at instdone for all engines
URL : https://patchwork.freedesktop.org/series/61843/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6225_full -> Patchwork_13223_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_13223_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@in-flight-suspend:
- shard-kbl: [PASS][1] -> [FAIL][2] ([fdo#110667])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-kbl4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-kbl3/igt@[email protected]
* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-glk: [PASS][3] -> [INCOMPLETE][4] ([fdo#103359] / [k.org#198133])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-glk4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-glk4/igt@[email protected]
* igt@i915_suspend@sysfs-reader:
- shard-apl: [PASS][5] -> [DMESG-WARN][6] ([fdo#108566])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-apl7/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-apl5/igt@[email protected]
* igt@kms_flip@2x-flip-vs-suspend-interruptible:
- shard-hsw: [PASS][7] -> [INCOMPLETE][8] ([fdo#103540])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-hsw6/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-hsw5/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][9] -> [FAIL][10] ([fdo#105363])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-skl2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-skl6/igt@[email protected]
* igt@kms_flip_tiling@flip-changes-tiling:
- shard-skl: [PASS][11] -> [FAIL][12] ([fdo#108303])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-skl8/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-skl7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render:
- shard-hsw: [PASS][13] -> [SKIP][14] ([fdo#109271]) +13 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-hsw6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-blt:
- shard-iclb: [PASS][15] -> [FAIL][16] ([fdo#103167]) +4 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-iclb3/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-iclb8/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][17] -> [FAIL][18] ([fdo#108145])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-skl8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-skl7/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [PASS][19] -> [FAIL][20] ([fdo#103166])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-iclb8/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-iclb1/igt@[email protected]
* igt@kms_setmode@basic:
- shard-apl: [PASS][21] -> [FAIL][22] ([fdo#99912])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-apl4/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-apl3/igt@[email protected]
#### Possible fixes ####
* {igt@gem_ctx_engines@execute-oneforall}:
- shard-snb: [DMESG-WARN][23] ([fdo#110869]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-snb4/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-snb1/igt@[email protected]
* {igt@gem_exec_balancer@smoke}:
- shard-iclb: [SKIP][25] ([fdo#110854]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-iclb6/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-iclb4/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-kbl: [DMESG-WARN][27] ([fdo#108566]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-kbl6/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-kbl6/igt@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][29] ([fdo#105363]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-glk1/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-glk6/igt@[email protected]
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-hsw: [SKIP][31] ([fdo#109271]) -> [PASS][32] +17 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-hsw1/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-hsw6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
- shard-iclb: [FAIL][33] ([fdo#103167]) -> [PASS][34] +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-iclb4/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-iclb4/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-apl: [DMESG-WARN][35] ([fdo#108566]) -> [PASS][36] +5 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-apl7/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-apl5/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-skl: [INCOMPLETE][37] ([fdo#104108]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-skl6/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-skl4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][39] ([fdo#108145] / [fdo#110403]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-skl6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-skl9/igt@[email protected]
* igt@kms_sysfs_edid_timing:
- shard-iclb: [FAIL][41] ([fdo#100047]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-iclb3/igt@kms_sysfs_edid_timing.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-iclb5/igt@kms_sysfs_edid_timing.html
#### Warnings ####
* igt@gem_eio@in-flight-suspend:
- shard-skl: [INCOMPLETE][43] ([fdo#104108]) -> [FAIL][44] ([fdo#105957])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-skl4/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-skl6/igt@[email protected]
* igt@i915_pm_rpm@modeset-non-lpsp:
- shard-iclb: [SKIP][45] ([fdo#109308]) -> [SKIP][46] ([fdo#110892]) +4 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6225/shard-iclb4/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/shard-iclb4/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105957]: https://bugs.freedesktop.org/show_bug.cgi?id=105957
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108303]: https://bugs.freedesktop.org/show_bug.cgi?id=108303
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110667]: https://bugs.freedesktop.org/show_bug.cgi?id=110667
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#110869]: https://bugs.freedesktop.org/show_bug.cgi?id=110869
[fdo#110892]: https://bugs.freedesktop.org/show_bug.cgi?id=110892
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_6225 -> Patchwork_13223
CI_DRM_6225: 39bb7459567aada2e706e4da4a650dc4f7c41abf @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5049: db51cbba5a8f4856d6f56a61aa51fda6e239fa44 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13223: 9f96a3a7fe4dd163a8524c35ff18f207f2a87ba0 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13223/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Tvrtko Ursulin (2019-06-10 14:01:10)
Quoted 9 lines
From: Tvrtko Ursulin <[email protected]>
It seems
intel_engine_get_instdoneis able to get instdone for all engines but intel_hangcheck.c/subunits_stuck decides to ignore it for non render.We can just drop the check in
subunits_stucksince the checks on unavailable fields will always return stuck, which when bitwise and with the potential unstuck instdone is harmless.
Quoted 5 lines
Signed-off-by Tvrtko Ursulin <[email protected]>Cc Chris Wilson <[email protected]>Cc Mika Kuoppala <[email protected]>---
Would actually using the available data improve hang detection?
I got hung up on this question, and didn't address the patch on its merits.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx