Skip to contentSkip to conversation

xfs-linux: copy-file-range-fixes updated to fe0da9c09b2d

ANNOUNCE Darrick J. Wong 2 participants 3 messages Jun 10, 2019 – Jun 11, 2019

Subsystems (5)
lore
Share & tools
lore
#0 lore raw

Hi folks,

The copy-file-range-fixes branch of the xfs-linux repository at:

git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git

has just been updated. This is a common branch from which everyone else can create their own copy-file-range fix branches for 5.3. When you send your pull request to Linus please let him know that the fixes stream out from here like some kind of hydra. :)

FWIW these patches are the fixes for the problems that have been reported in generic/553 and generic/554.

Patches often get missed, so please check if your outstanding patches were in this update. If they have not been in this update, please resubmit them to [email protected] so they can be picked up in the next update.

The new head of the copy-file-range-fixes branch is commit:

fe0da9c09b2d fuse: copy_file_range needs to strip setuid bits and update timestamps

New Commits:

Amir Goldstein (7):
[a31713517dac] vfs: introduce generic_file_rw_checks()
[646955cd5425] vfs: remove redundant checks from generic_remap_checks() [96e6e8f4a68d] vfs: add missing checks to copy_file_range [e38f7f53c352] vfs: introduce file_modified() helper
[8c3f406c097b] xfs: use file_modified() helper
[5dae222a5ff0] vfs: allow copy_file_range to copy across devices [fe0da9c09b2d] fuse: copy_file_range needs to strip setuid bits and update timestamps

Dave Chinner (2):

      [f16acc9d9b37] vfs: introduce generic_copy_file_range()
      [64bf5ff58dff] vfs: no fallback for ->copy_file_range

Code Diffstat:

 fs/ceph/file.c     |  23 ++++++++--
 fs/cifs/cifsfs.c   |   4 ++
 fs/fuse/file.c     |  29 +++++++++++--
 fs/inode.c         |  20 +++++++++
 fs/nfs/nfs4file.c  |  23 ++++++++--
 fs/read_write.c    | 124 +++++++++++++++++++++++++++++------------------------
 fs/xfs/xfs_file.c  |  15 +------
 include/linux/fs.h |   9 ++++
 mm/filemap.c       | 110 ++++++++++++++++++++++++++++++++++++++---------
 9 files changed, 257 insertions(+), 100 deletions(-)
#1 lore raw

+CC affected maintainers

Quoted 11 lines · Darrick J. Wong

Hi folks,

The copy-file-range-fixes branch of the xfs-linux repository at:

git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git

has just been updated. This is a common branch from which everyone else can create their own copy-file-range fix branches for 5.3. When you send your pull request to Linus please let him know that the fixes stream out from here like some kind of hydra. :)

Thanks Darrick!
Should we also request to include this branch in linux-next?

Attention nfs/cifs/fuse/ceph maintainers!
This branch includes changes to your filesystems.
At lease nfs/cifs/ceph have been tested with these changes and the new xfstests.

I think it would be preferred if you merge Darrick's branch into your 5.3 branch as soon as you have one ready to reduce chances of conflicts down the road.

I will be sending out 2 more patches to cifs/ceph, which depend on this branch directly to maintainers.

Thanks,
Amir.

#2 lore raw
Quoted 10 lines · Amir Goldstein

+CC affected maintainers

Quoted 7 lines · Darrick J. Wong

Hi folks,

The copy-file-range-fixes branch of the xfs-linux repository at:

git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git

Quoted 7 lines
Quoted 4 lines

has just been updated. This is a common branch from which everyone else can create their own copy-file-range fix branches for 5.3. When you send your pull request to Linus please let him know that the fixes stream out from here like some kind of hydra. :)

Thanks Darrick!
Should we also request to include this branch in linux-next?

Yeah, I was going to do that after 24h (i.e. it'll be in Wednesday's -next) to see if anyone had any last minute "ZOMG this patch has to be changed" screaming.

Quoted 11 lines

Attention nfs/cifs/fuse/ceph maintainers!
This branch includes changes to your filesystems.
At lease nfs/cifs/ceph have been tested with these changes and the new xfstests.

I think it would be preferred if you merge Darrick's branch into your 5.3 branch as soon as you have one ready to reduce chances of conflicts down the road.

I will be sending out 2 more patches to cifs/ceph, which depend on this branch directly to maintainers.

Noted.

--D

Quoted 2 lines

Thanks,
Amir.