drm/i915: Move intel_add_dsi_properties to intel_dsi
Subsystems (2)
PATCH 1/2 drm/i915: Move intel_add_dsi_properties to intel_dsi
From: Vandita Kulkarni <[email protected]>
Since intel_add_dsi_properties will be used by other platforms too move it out of platform specific file.
--- drivers/gpu/drm/i915/intel_dsi.c | 32 ++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_dsi.h | 3 +++ drivers/gpu/drm/i915/vlv_dsi.c | 42 +------------------------------- 3 files changed, 36 insertions(+), 41 deletions(-)
drivers/gpu/drm/i915/intel_dsi.c +32 -0
@@ -116,6 +116,12 @@ intel_dsi_get_panel_orientation(struct intel_connector *connector)struct drm_i915_private *dev_priv =to_i915 (connector->base.dev);enum drm_panel_orientation orientation; +if (IS_VALLEYVIEW (dev_priv) ||IS_CHERRYVIEW (dev_priv)) { + orientation =vlv_dsi_get_hw_panel_orientation (connector); +if (orientation !=DRM_MODE_PANEL_ORIENTATION_UNKNOWN ) +return orientation; + } + orientation = dev_priv->vbt.dsi.orientation;if (orientation !=DRM_MODE_PANEL_ORIENTATION_UNKNOWN )return orientation;
@@ -126,3 +132,29 @@ intel_dsi_get_panel_orientation(struct intel_connector *connector)return DRM_MODE_PANEL_ORIENTATION_NORMAL ; } + +void intel_dsi_add_properties (struct intel_connector *connector) +{ +struct drm_i915_private *dev_priv =to_i915 (connector->base.dev); + +if (connector->panel.fixed_mode) { +u32 allowed_scalers; + + allowed_scalers =BIT (DRM_MODE_SCALE_ASPECT ) | +BIT (DRM_MODE_SCALE_FULLSCREEN ); +if (!HAS_GMCH (dev_priv)) + allowed_scalers |=BIT (DRM_MODE_SCALE_CENTER ); + +drm_connector_attach_scaling_mode_property (&connector->base, + allowed_scalers); + + connector->base.state->scaling_mode =DRM_MODE_SCALE_ASPECT ; + + connector->base.display_info.panel_orientation = +intel_dsi_get_panel_orientation (connector); +drm_connector_init_panel_orientation_property ( + &connector->base, + connector->panel.fixed_mode->hdisplay, + connector->panel.fixed_mode->vdisplay); + } +}
drivers/gpu/drm/i915/intel_dsi.h +3 -0
@@ -162,6 +162,7 @@ int intel_dsi_bitrate(const struct intel_dsi *intel_dsi);int intel_dsi_tlpx_ns (const struct intel_dsi *intel_dsi);enum drm_panel_orientation intel_dsi_get_panel_orientation (struct intel_connector *connector); +void intel_dsi_add_properties (struct intel_connector *connector);/* vlv_dsi.c */ void vlv_dsi_wait_for_fifo_empty (struct intel_dsi *intel_dsi,enum port port);
@@ -173,6 +174,8 @@ struct intel_dsi_host *intel_dsi_host_init(struct intel_dsi *intel_dsi,const struct mipi_dsi_host_ops *funcs, enum port port);void vlv_dsi_init (struct drm_i915_private *dev_priv); +enum drm_panel_orientation +vlv_dsi_get_hw_panel_orientation (struct intel_connector *connector);/* vlv_dsi_pll.c */ int vlv_dsi_pll_compute(struct intel_encoder *encoder,
drivers/gpu/drm/i915/vlv_dsi.c +1 -41
54 lines not on this page · raw message
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/2 drm/i915: Add intel_dsi properties support for icl
Support dsi properties on icl
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110693
--- drivers/gpu/drm/i915/icl_dsi.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/icl_dsi.c +4 -0
@@ -1579,7 +1579,11 @@ void icl_dsi_init(struct drm_i915_private *dev_priv) goto err; } +icl_dphy_param_init (intel_dsi); + +intel_dsi_add_properties (intel_connector); +return ; err:
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [REBASED PATCH 2/2] drm/i915: Add intel_dsi properties support for icl
This is also by Vandita, I screwed up the authorship while rebasing the patches. I'll fix while applying.
BR,
Jani.
Quoted 25 lines · Jani Nikula
Support dsi properties on icl
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110693
Signed-off-by Vandita Kulkarni <[email protected]>Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/icl_dsi.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/gpu/drm/i915/icl_dsi.c +4
-0@@ -1579,7 +1579,11 @@ void icl_dsi_init(struct drm_i915_private *dev_priv) goto err; } +icl_dphy_param_init (intel_dsi); + +intel_dsi_add_properties (intel_connector); +return ; err:
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for series starting with [REBASED,1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [REBASED,1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi
URL : https://patchwork.freedesktop.org/series/61862/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip bfc796027b45 drm/i915: Move intel_add_dsi_properties to intel_dsi -:47: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #47: FILE: drivers/gpu/drm/i915/intel_dsi.c:149: + drm_connector_attach_scaling_mode_property(&connector->base, + allowed_scalers);
-:53: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #53: FILE: drivers/gpu/drm/i915/intel_dsi.c:155:
+ drm_connector_init_panel_orientation_property(
total: 0 errors, 0 warnings, 2 checks, 110 lines checked 6b35e67428fc drm/i915: Add intel_dsi properties support for icl -:20: CHECK:LINE_SPACING: Please don't use multiple blank lines #20: FILE: drivers/gpu/drm/i915/icl_dsi.c:1582:
+
total: 0 errors, 0 warnings, 1 checks, 11 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for series starting with [REBASED,1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [REBASED,1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi
URL : https://patchwork.freedesktop.org/series/61862/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6227 -> Patchwork_13228
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/
Known issues
------------
Here are the changes found in Patchwork_13228 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: [PASS][1] -> [INCOMPLETE][2] ([fdo#107718])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/fi-blb-e6850/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/fi-blb-e6850/igt@[email protected]
* igt@kms_addfb_basic@no-handle:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/fi-icl-u3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/fi-icl-u3/igt@[email protected]
#### Possible fixes ####
* igt@gem_basic@bad-close:
- fi-icl-u3: [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/fi-icl-u3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/fi-icl-u3/igt@[email protected]
- fi-icl-dsi: [INCOMPLETE][7] ([fdo#107713]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/fi-icl-dsi/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/fi-icl-dsi/igt@[email protected]
* igt@gem_ctx_switch@basic-default:
- {fi-icl-guc}: [INCOMPLETE][9] ([fdo#107713] / [fdo#108569]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/fi-icl-guc/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/fi-icl-guc/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
Participating hosts (52 -> 46)
------------------------------
Additional (1): fi-snb-2600
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-u2 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_6227 -> Patchwork_13228
CI_DRM_6227: fe62c0390420632afe2193a40097c9f03a0bf725 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5050: 4c072238c784e6acb00634a80c3c55fb8358058b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13228: 6b35e67428fcf2903600c5dea6143b98395e8c9b @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
6b35e67428fc drm/i915: Add intel_dsi properties support for icl bfc796027b45 drm/i915: Move intel_add_dsi_properties to intel_dsi
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 48 lines · Jani Nikula
From: Vandita Kulkarni <[email protected]>
Since
intel_add_dsi_propertieswill be used by other platforms too move it out of platform specific file.Signed-off-by Vandita Kulkarni <[email protected]>Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/intel_dsi.c | 32 ++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_dsi.h | 3 +++ drivers/gpu/drm/i915/vlv_dsi.c | 42 +------------------------------- 3 files changed, 36 insertions(+), 41 deletions(-)drivers/gpu/drm/i915/intel_dsi.c +20
-0@@ -116,6 +116,12 @@ intel_dsi_get_panel_orientation(struct intel_connector *connector)struct drm_i915_private *dev_priv =to_i915 (connector->base.dev);enum drm_panel_orientation orientation; +if (IS_VALLEYVIEW (dev_priv) ||IS_CHERRYVIEW (dev_priv)) { + orientation =vlv_dsi_get_hw_panel_orientation (connector); +if (orientation !=DRM_MODE_PANEL_ORIENTATION_UNKNOWN ) +return orientation; + } + orientation = dev_priv->vbt.dsi.orientation;if (orientation !=DRM_MODE_PANEL_ORIENTATION_UNKNOWN )return orientation;@@ -126,3 +132,29 @@ intel_dsi_get_panel_orientation(struct intel_connector *connector)return DRM_MODE_PANEL_ORIENTATION_NORMAL ; } + +void intel_dsi_add_properties (struct intel_connector *connector) +{ +struct drm_i915_private *dev_priv =to_i915 (connector->base.dev); + +if (connector->panel.fixed_mode) { +u32 allowed_scalers; + + allowed_scalers =BIT (DRM_MODE_SCALE_ASPECT ) | +BIT (DRM_MODE_SCALE_FULLSCREEN ); +if (!HAS_GMCH (dev_priv)) + allowed_scalers |=BIT (DRM_MODE_SCALE_CENTER ); + + drm_connector_attach_scaling_mode_property(&connector->base,
drivers/gpu/drm/i915/intel_dsi.c intel_dsi_get_panel_orientation(struct intel_connector *connector) · line 158
Quoted 10 lines
drivers/gpu/drm/i915/intel_dsi.c +10
-0+ allowed_scalers); + + connector->base.state->scaling_mode =DRM_MODE_SCALE_ASPECT ; + + connector->base.display_info.panel_orientation = +intel_dsi_get_panel_orientation (connector); +drm_connector_init_panel_orientation_property ( + &connector->base, + connector->panel.fixed_mode->hdisplay, + connector->panel.fixed_mode->vdisplay);
I think I'd rather just duplicate the required parts in the icl code. That way we don't have to have VLV/CHV specific stuff in the generic code.
Quoted 90 lines
drivers/gpu/drm/i915/intel_dsi.c +2
-0+ } +}drivers/gpu/drm/i915/intel_dsi.h +3
-0@@ -162,6 +162,7 @@ int intel_dsi_bitrate(const struct intel_dsi *intel_dsi);int intel_dsi_tlpx_ns (const struct intel_dsi *intel_dsi);enum drm_panel_orientation intel_dsi_get_panel_orientation (struct intel_connector *connector); +void intel_dsi_add_properties (struct intel_connector *connector);/* vlv_dsi.c */ void vlv_dsi_wait_for_fifo_empty (struct intel_dsi *intel_dsi,enum port port);@@ -173,6 +174,8 @@ struct intel_dsi_host *intel_dsi_host_init(struct intel_dsi *intel_dsi,const struct mipi_dsi_host_ops *funcs, enum port port);void vlv_dsi_init (struct drm_i915_private *dev_priv); +enum drm_panel_orientation +vlv_dsi_get_hw_panel_orientation (struct intel_connector *connector);/* vlv_dsi_pll.c */ int vlv_dsi_pll_compute(struct intel_encoder *encoder,drivers/gpu/drm/i915/vlv_dsi.c +1
-41@@ -1591,7 +1591,7 @@ static const struct drm_connector_funcs intel_dsi_connector_funcs = { .atomic_duplicate_state = intel_digital_connector_duplicate_state, }; -static enum drm_panel_orientation +enum drm_panel_orientation vlv_dsi_get_hw_panel_orientation (struct intel_connector *connector) {struct drm_i915_private *dev_priv =to_i915 (connector->base.dev);@@ -1629,46 +1629,6 @@ vlv_dsi_get_hw_panel_orientation(struct intel_connector *connector)return orientation; } -static enum drm_panel_orientation -vlv_dsi_get_panel_orientation (struct intel_connector *connector) -{ -struct drm_i915_private *dev_priv =to_i915 (connector->base.dev); -enum drm_panel_orientation orientation; - -if (IS_VALLEYVIEW (dev_priv) ||IS_CHERRYVIEW (dev_priv)) { - orientation =vlv_dsi_get_hw_panel_orientation (connector); -if (orientation !=DRM_MODE_PANEL_ORIENTATION_UNKNOWN ) -return orientation; - } - -return intel_dsi_get_panel_orientation (connector); -} - -static void intel_dsi_add_properties (struct intel_connector *connector) -{ -struct drm_i915_private *dev_priv =to_i915 (connector->base.dev); - -if (connector->panel.fixed_mode) { -u32 allowed_scalers; - - allowed_scalers =BIT (DRM_MODE_SCALE_ASPECT ) |BIT (DRM_MODE_SCALE_FULLSCREEN ); -if (!HAS_GMCH (dev_priv)) - allowed_scalers |=BIT (DRM_MODE_SCALE_CENTER ); - -drm_connector_attach_scaling_mode_property (&connector->base, - allowed_scalers); - - connector->base.state->scaling_mode =DRM_MODE_SCALE_ASPECT ; - - connector->base.display_info.panel_orientation = -vlv_dsi_get_panel_orientation (connector); -drm_connector_init_panel_orientation_property ( - &connector->base, - connector->panel.fixed_mode->hdisplay, - connector->panel.fixed_mode->vdisplay); - } -} -#define NS_KHZ_RATIO 1000000#define PREPARE_CNT_MAX 0x3FSignature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 68 lines
-----Original Message-----
From: Intel-gfx <[email protected]> On Behalf Of Ville Syrjälä
Sent: Tuesday, June 11, 2019 5:52 PM
To: Nikula, Jani <[email protected]>
Cc: [email protected]
Subject: Re: [Intel-gfx] [REBASED PATCH 1/2] drm/i915: Moveintel_add_dsi_propertiestointel_dsidrivers/gpu/drm/i915/intel_dsi.c intel_dsi_get_panel_orientation(struct
Quoted 19 lines · Jani Nikula
From: Vandita Kulkarni <[email protected]>
Since
intel_add_dsi_propertieswill be used by other platforms too move it out of platform specific file.Signed-off-by Vandita Kulkarni <[email protected]>Signed-off-by Jani Nikula <[email protected]>--- drivers/gpu/drm/i915/intel_dsi.c | 32 ++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_dsi.h | 3 +++ drivers/gpu/drm/i915/vlv_dsi.c | 42 +------------------------------- 3 files changed, 36 insertions(+), 41 deletions(-)drivers/gpu/drm/i915/intel_dsi.c +0
-0@@ -116,6 +116,12 @@ intel_dsi_get_panel_orientation(struct
intel_connector*connector)drivers/gpu/drm/i915/intel_dsi.c intel_dsi_get_panel_orientation(struct intel_connector *connector)
Quoted 6 lines
drivers/gpu/drm/i915/intel_dsi.c +3
-0struct drm_i915_private *dev_priv =to_i915 (connector->base.dev);enum drm_panel_orientation orientation; +if (IS_VALLEYVIEW (dev_priv) ||IS_CHERRYVIEW (dev_priv)) { + orientation =vlv_dsi_get_hw_panel_orientation (connector); + if (orientation !=
DRM_MODE_PANEL_ORIENTATION_UNKNOWN)Quoted 24 lines
drivers/gpu/drm/i915/intel_dsi.c +16
-0+return orientation; + } + orientation = dev_priv->vbt.dsi.orientation;if (orientation !=DRM_MODE_PANEL_ORIENTATION_UNKNOWN )return orientation;@@ -126,3 +132,29 @@ intel_dsi_get_panel_orientation(struct intel_connector *connector)return DRM_MODE_PANEL_ORIENTATION_NORMAL ; } + +void intel_dsi_add_properties (struct intel_connector *connector) { +struct drm_i915_private *dev_priv =to_i915 (connector->base.dev); + +if (connector->panel.fixed_mode) { +u32 allowed_scalers; + + allowed_scalers =BIT (DRM_MODE_SCALE_ASPECT ) | +BIT (DRM_MODE_SCALE_FULLSCREEN ); +if (!HAS_GMCH (dev_priv)) + allowed_scalers |=BIT (DRM_MODE_SCALE_CENTER ); + + drm_connector_attach_scaling_mode_property(&connector-Quoted 2 lines
base,
+allowed_scalers);drivers/gpu/drm/i915/intel_dsi.c
Quoted 2 lines
drivers/gpu/drm/i915/intel_dsi.c +2
-0+ + connector->base.state->scaling_mode =
DRM_MODE_SCALE_ASPECT;
Quoted 10 lines
drivers/gpu/drm/i915/intel_dsi.c intel_dsi_get_panel_orientation(struct intel_connector *connector) · line 158
Quoted 7 lines
drivers/gpu/drm/i915/intel_dsi.c +7
-0+ + connector->base.display_info.panel_orientation = +intel_dsi_get_panel_orientation (connector); +drm_connector_init_panel_orientation_property ( + &connector->base, + connector->panel.fixed_mode->hdisplay, + connector->panel.fixed_mode->vdisplay);I think I'd rather just duplicate the required parts in the icl code. That way we don't have to have VLV/CHV specific stuff in the generic code.
Okay, will make the change.
Thanks
Vandita
Quoted 97 lines
Quoted 16 lines
drivers/gpu/drm/i915/intel_dsi.c +2
-0+ } +}drivers/gpu/drm/i915/intel_dsi.h +1
-0@@ -162,6 +162,7 @@ int intel_dsi_bitrate(const struct intel_dsi *intel_dsi); int intel_dsi_tlpx_ns(const struct intel_dsi *intel_dsi);enum drm_panel_orientation intel_dsi_get_panel_orientation (struct intel_connector *connector); +void intel_dsi_add_properties (struct intel_connector *connector);/* vlv_dsi.c */ void vlv_dsi_wait_for_fifo_empty(struct intel_dsi *intel_dsi, enumQuoted 1 line
port port); @@ -173,6 +174,8 @@ struct
intel_dsi_host*intel_dsi_host_init(struct
intel_dsi*intel_dsi,Quoted 1 line
const struct
mipi_dsi_host_ops*funcs,
drivers/gpu/drm/i915/vlv_dsi.c static const struct drm_connector_funcs
Quoted 12 lines
drivers/gpu/drm/i915/intel_dsi.h +2
-0enum port port);void vlv_dsi_init (struct drm_i915_private *dev_priv); +enum drm_panel_orientation +vlv_dsi_get_hw_panel_orientation (struct intel_connector *connector);/* vlv_dsi_pll.c */ int vlv_dsi_pll_compute(struct intel_encoder *encoder, diff --git
a/drivers/gpu/drm/i915/vlv_dsi.cb/drivers/gpu/drm/i915/vlv_dsi.cindexe272d826210a..9f911623d685100644drivers/gpu/drm/i915/vlv_dsi.c +0
-0@@ -1591,7 +1591,7 @@ static const struct drm_connector_funcs
intel_dsi_connector_funcs= {drivers/gpu/drm/i915/vlv_dsi.c static const struct drm_connector_funcs intel_dsi_connector_funcs = { · line 1597
Quoted 8 lines
drivers/gpu/drm/i915/vlv_dsi.c +1
-1.atomic_duplicate_state = intel_digital_connector_duplicate_state, }; -static enum drm_panel_orientation +enum drm_panel_orientation vlv_dsi_get_hw_panel_orientation (struct intel_connector *connector) {struct drm_i915_private *dev_priv =to_i915 (connector->base.dev);@@
Quoted 1 line
-1629,46 +1629,6 @@ vlv_dsi_get_hw_panel_orientation(struct
intel_connector*connector)drivers/gpu/drm/i915/vlv_dsi.c vlv_dsi_get_hw_panel_orientation(struct intel_connector *connector)
Quoted 11 lines
drivers/gpu/drm/i915/vlv_dsi.c +0
-8return orientation; } -static enum drm_panel_orientation -vlv_dsi_get_panel_orientation(struct intel_connector *connector) -{ -struct drm_i915_private *dev_priv =to_i915 (connector->base.dev); -enum drm_panel_orientation orientation; - -if (IS_VALLEYVIEW (dev_priv) ||IS_CHERRYVIEW (dev_priv)) { - orientation =vlv_dsi_get_hw_panel_orientation (connector); - if (orientation !=
DRM_MODE_PANEL_ORIENTATION_UNKNOWN)Quoted 8 lines
drivers/gpu/drm/i915/vlv_dsi.c +0
-7-return orientation; - } - -return intel_dsi_get_panel_orientation (connector); -} - -static void intel_dsi_add_properties(struct intel_connector*connector) -{
drivers/gpu/drm/i915/vlv_dsi.c vlv_dsi_get_hw_panel_orientation(struct intel_connector *connector)
Quoted 6 lines
drivers/gpu/drm/i915/vlv_dsi.c +0
-6-struct drm_i915_private *dev_priv =to_i915 (connector->base.dev); - -if (connector->panel.fixed_mode) { -u32 allowed_scalers; - - allowed_scalers = BIT(DRM_MODE_SCALE_ASPECT) |
BIT(DRM_MODE_SCALE_FULLSCREEN);Quoted 6 lines
drivers/gpu/drm/i915/vlv_dsi.c +0
-4-if (!HAS_GMCH (dev_priv)) - allowed_scalers |=BIT (DRM_MODE_SCALE_CENTER ); - - drm_connector_attach_scaling_mode_property(&connector-base,
-allowed_scalers);drivers/gpu/drm/i915/vlv_dsi.c
Quoted 2 lines
drivers/gpu/drm/i915/vlv_dsi.c +0
-2- - connector->base.state->scaling_mode =
DRM_MODE_SCALE_ASPECT;Quoted 16 lines
drivers/gpu/drm/i915/vlv_dsi.c +0
-11- - connector->base.display_info.panel_orientation = -vlv_dsi_get_panel_orientation (connector); -drm_connector_init_panel_orientation_property ( - &connector->base, - connector->panel.fixed_mode->hdisplay, - connector->panel.fixed_mode->vdisplay); - } -} -#define NS_KHZ_RATIO 1000000#define PREPARE_CNT_MAX 0x3F --2.20.1
Quoted 12 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for series starting with [REBASED,1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [REBASED,1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi
URL : https://patchwork.freedesktop.org/series/61862/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6227_full -> Patchwork_13228_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_13228_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_13228_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_13228_full:
### IGT changes ###
#### Warnings ####
* igt@kms_hdmi_inject@inject-audio:
- shard-iclb: [DMESG-FAIL][1] ([fdo#109593]) -> [DMESG-FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-iclb1/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-iclb8/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_13228_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_engines@execute-one:
- shard-snb: [PASS][3] -> [DMESG-WARN][4] ([fdo#110869])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-snb4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-snb6/igt@[email protected]
- shard-glk: [PASS][5] -> [DMESG-WARN][6] ([fdo#110869])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-glk3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-glk9/igt@[email protected]
* igt@gem_ctx_isolation@bcs0-s3:
- shard-apl: [PASS][7] -> [DMESG-WARN][8] ([fdo#108566]) +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-apl2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-apl8/igt@[email protected]
* igt@gem_eio@in-flight-suspend:
- shard-glk: [PASS][9] -> [FAIL][10] ([fdo#110667])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-glk1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-glk4/igt@[email protected]
* igt@gem_exec_schedule@preempt-queue-bsd:
- shard-glk: [PASS][11] -> [INCOMPLETE][12] ([fdo#103359] / [k.org#198133])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-glk8/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-glk3/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-skl: [PASS][13] -> [INCOMPLETE][14] ([fdo#110741])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-skl2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-skl6/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][15] -> [FAIL][16] ([fdo#104873])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-glk4/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-glk8/igt@[email protected]
* igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset:
- shard-hsw: [PASS][17] -> [SKIP][18] ([fdo#109271]) +15 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-hsw4/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-hsw1/igt@[email protected]
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [PASS][19] -> [INCOMPLETE][20] ([fdo#109507])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-skl9/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-skl1/igt@[email protected]
- shard-snb: [PASS][21] -> [INCOMPLETE][22] ([fdo#105411])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-snb6/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-snb1/igt@[email protected]
* igt@kms_flip_tiling@flip-to-x-tiled:
- shard-iclb: [PASS][23] -> [FAIL][24] ([fdo#108134])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-iclb8/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-iclb1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-iclb: [PASS][25] -> [FAIL][26] ([fdo#103167]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-iclb4/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-iclb4/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-skl: [PASS][27] -> [INCOMPLETE][28] ([fdo#104108]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-skl6/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-skl2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][29] -> [FAIL][30] ([fdo#108145] / [fdo#110403])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-skl5/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-skl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][31] -> [FAIL][32] ([fdo#108145])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-skl1/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-skl6/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][33] -> [FAIL][34] ([fdo#103166])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-iclb8/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-iclb7/igt@[email protected]
* igt@kms_psr@suspend:
- shard-skl: [PASS][35] -> [INCOMPLETE][36] ([fdo#108972])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-skl6/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-skl1/igt@[email protected]
* igt@kms_setmode@basic:
- shard-kbl: [PASS][37] -> [FAIL][38] ([fdo#99912])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-kbl3/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-kbl7/igt@[email protected]
* igt@perf@blocking:
- shard-skl: [PASS][39] -> [FAIL][40] ([fdo#110728])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-skl7/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-skl4/igt@[email protected]
#### Possible fixes ####
* igt@gem_ctx_engines@execute-one:
- shard-skl: [DMESG-WARN][41] ([fdo#110869]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-skl4/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-skl2/igt@[email protected]
* {igt@gem_ctx_engines@independent}:
- shard-hsw: [DMESG-WARN][43] ([fdo#110789] / [fdo#110869]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-hsw8/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-hsw8/igt@[email protected]
* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][45] ([fdo#108566]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-apl1/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-apl5/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb8888-pwrite-ytiled:
- shard-skl: [FAIL][47] ([fdo#103184] / [fdo#103232] / [fdo#108222]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-skl9/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-skl8/igt@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][49] ([fdo#105363]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-glk7/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-glk2/igt@[email protected]
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-hsw: [SKIP][51] ([fdo#109271]) -> [PASS][52] +19 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-hsw1/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-hsw2/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [FAIL][53] ([fdo#105363]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-skl5/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-skl6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render:
- shard-skl: [FAIL][55] ([fdo#103167]) -> [PASS][56] +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-skl5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-skl6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: [FAIL][57] ([fdo#103167]) -> [PASS][58] +4 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][59] ([fdo#99912]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6227/shard-apl3/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/shard-apl6/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#108134]: https://bugs.freedesktop.org/show_bug.cgi?id=108134
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108222]: https://bugs.freedesktop.org/show_bug.cgi?id=108222
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108972]: https://bugs.freedesktop.org/show_bug.cgi?id=108972
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#109593]: https://bugs.freedesktop.org/show_bug.cgi?id=109593
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110667]: https://bugs.freedesktop.org/show_bug.cgi?id=110667
[fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
[fdo#110741]: https://bugs.freedesktop.org/show_bug.cgi?id=110741
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#110869]: https://bugs.freedesktop.org/show_bug.cgi?id=110869
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_6227 -> Patchwork_13228
CI_DRM_6227: fe62c0390420632afe2193a40097c9f03a0bf725 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5050: 4c072238c784e6acb00634a80c3c55fb8358058b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13228: 6b35e67428fcf2903600c5dea6143b98395e8c9b @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13228/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx