Skip to contentSkip to conversation

imx8mq_evk: Staticize when appropriate

PATCH New Fabio Estevam 3 participants 3 messages May 18, 2019 – Jun 11, 2019 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 imx8mq_evk: Staticize when appropriate

Staticize 'spl_dram_init' and 'i2c_pad_info1' to fix the following sparse warnings:

board/freescale/imx8mq_evk/spl.c:30:6: warning: symbol 'spl_dram_init' was not declared. Should it be static? board/freescale/imx8mq_evk/spl.c:41:22: warning: symbol 'i2c_pad_info1' was not declared. Should it be static?

---
 board/freescale/imx8mq_evk/spl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/freescale/imx8mq_evk/spl.c +2 -2
index e6cbc34b0d..3c0ff0bb1b 100644
@@ -27,7 +27,7 @@ DECLARE_GLOBAL_DATA_PTR;
 
 extern struct dram_timing_info dram_timing_b0;
 
-void spl_dram_init(void)
+static void spl_dram_init(void)
 {
 	/* ddr init */
 	if ((get_cpu_rev() & 0xfff) == CHIP_REV_2_1)
@@ -38,7 +38,7 @@ void spl_dram_init(void)
 
 #define I2C_PAD_CTRL	(PAD_CTL_DSE6 | PAD_CTL_HYS | PAD_CTL_PUE)
 #define PC MUX_PAD_CTRL(I2C_PAD_CTRL)
-struct i2c_pads_info i2c_pad_info1 = {
+static struct i2c_pads_info i2c_pad_info1 = {
 	.scl = {
 		.i2c_mode = IMX8MQ_PAD_I2C1_SCL__I2C1_SCL | PC,
 		.gpio_mode = IMX8MQ_PAD_I2C1_SCL__GPIO5_IO14 | PC,
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/1 imx8mq_evk: Staticize when appropriate

Quoted 34 lines

Subject: [PATCH] imx8mq_evk: Staticize when appropriate

Staticize 'spl_dram_init' and 'i2c_pad_info1' to fix the following sparse warnings:

board/freescale/imx8mq_evk/spl.c:30:6: warning: symbol 'spl_dram_init' was not declared. Should it be static? board/freescale/imx8mq_evk/spl.c:41:22: warning: symbol 'i2c_pad_info1' was not declared. Should it be static?

---
 board/freescale/imx8mq_evk/spl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/freescale/imx8mq_evk/spl.c +1 -1
index e6cbc34b0d..3c0ff0bb1b 100644
@@ -27,7 +27,7 @@ DECLARE_GLOBAL_DATA_PTR;
 
 extern struct dram_timing_info dram_timing_b0;
 
-void spl_dram_init(void)
+static void spl_dram_init(void)
 {
 	/* ddr init */
 	if ((get_cpu_rev() & 0xfff) == CHIP_REV_2_1) @@ -38,7 +38,7 @@ void

spl_dram_init(void)

#define I2C_PAD_CTRL (PAD_CTL_DSE6 | PAD_CTL_HYS |
PAD_CTL_PUE)
#define PC MUX_PAD_CTRL(I2C_PAD_CTRL)

board/freescale/imx8mq_evk/spl.c void spl_dram_init(void) · line 44

Quoted 5 lines
board/freescale/imx8mq_evk/spl.c +1 -1
-struct i2c_pads_info i2c_pad_info1 = {
+static struct i2c_pads_info i2c_pad_info1 = {
 	.scl = {
 		.i2c_mode = IMX8MQ_PAD_I2C1_SCL__I2C1_SCL | PC,
 		.gpio_mode = IMX8MQ_PAD_I2C1_SCL__GPIO5_IO14 | PC,
Quoted 2 lines

--
2.17.1

#2 lore raw

PATCH 1/1 imx8mq_evk: Staticize when appropriate

In reply to Fabio Estevam
Quoted 6 lines

Staticize 'spl_dram_init' and 'i2c_pad_info1' to fix the
following sparse warnings:
board/freescale/imx8mq_evk/spl.c:30:6: warning: symbol 'spl_dram_init' was not declared. Should it be static? board/freescale/imx8mq_evk/spl.c:41:22: warning: symbol 'i2c_pad_info1' was not declared. Should it be static?

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================