configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
PATCH 1/1 configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit is exceeded.
CONFIG_SPL_I2C_SUPPORT is not needed to move to main U-Boot. So let's disable it.
---
This solves only one of the problems with the boards in v2019.04. The next problem is that reading the environment from MMC fails.
The patch
[PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB
https://lists.denx.de/pipermail/u-boot/2019-February/358883.html
makes the problem visibe.
--- configs/tinker-rk3288_defconfig | 1 - 1 file changed, 1 deletion(-)
configs/tinker-rk3288_defconfig +0 -1
@@ -18,7 +18,6 @@ CONFIG_DEFAULT_FDT_FILE="rk3288-tinker.dtb" CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_STACK_R=y CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000 -CONFIG_SPL_I2C_SUPPORT=y CONFIG_CMD_GPIO=y CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y
Signature · 1 line
2.20.1
PATCH 1/1 configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
Quoted 8 lines · Heinrich Schuchardt
The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit is exceeded.
CONFIG_SPL_I2C_SUPPORTis not needed to move to main U-Boot. So let's disable it.Suggested-by David Wu <[email protected]>Signed-off-by Heinrich Schuchardt <[email protected]>
Hello Philipp,
the patch has been assigned to you in patchwork. Is there any reason not to merge it into U-Boot v2019.04?
Best regards
Heinrich
Quoted 25 lines
---
This solves only one of the problems with the boards in v2019.04. The next problem is that reading the environment from MMC fails.The patch
[PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB
https://lists.denx.de/pipermail/u-boot/2019-February/358883.html
makes the problem visibe.--- configs/tinker-rk3288_defconfig | 1 - 1 file changed, 1 deletion(-)configs/tinker-rk3288_defconfig +0
-1@@ -18,7 +18,6 @@ CONFIG_DEFAULT_FDT_FILE="rk3288-tinker.dtb" CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_STACK_R=y CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000 -CONFIG_SPL_I2C_SUPPORT=y CONFIG_CMD_GPIO=y CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y
PATCH 1/1 configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
In reply to Heinrich SchuchardtHi Philipp,
This config does not look like it will be used in SPL and can be deleted.
Quoted 33 lines · Heinrich Schuchardt
The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit is exceeded.
CONFIG_SPL_I2C_SUPPORTis not needed to move to main U-Boot. So let's disable it.Suggested-by David Wu <[email protected]>Signed-off-by Heinrich Schuchardt <[email protected]>---
This solves only one of the problems with the boards in v2019.04. The next problem is that reading the environment from MMC fails.The patch
[PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB
https://lists.denx.de/pipermail/u-boot/2019-February/358883.html
makes the problem visibe.--- configs/tinker-rk3288_defconfig | 1 - 1 file changed, 1 deletion(-)configs/tinker-rk3288_defconfig +0
-1@@ -18,7 +18,6 @@ CONFIG_DEFAULT_FDT_FILE="rk3288-tinker.dtb" CONFIG_DISPLAY_BOARDINFO_LATE=y CONFIG_SPL_STACK_R=y CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000 -CONFIG_SPL_I2C_SUPPORT=y CONFIG_CMD_GPIO=y CONFIG_CMD_GPT=y CONFIG_CMD_I2C=y
PATCH 1/1 configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
In reply to Heinrich SchuchardtQuoted 13 lines
The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit is exceeded.
CONFIG_SPL_I2C_SUPPORTis not needed to move to main U-Boot. So let's disable it.Suggested-by David Wu <[email protected]>Signed-off-by Heinrich Schuchardt <[email protected]>Reviewed-by David Wu <[email protected]>---
This solves only one of the problems with the boards in v2019.04. The next problem is that reading the environment from MMC fails.
Quoted 8 lines
The patch
[PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB
https://lists.denx.de/pipermail/u-boot/2019-February/358883.html
makes the problem visibe.--- configs/tinker-rk3288_defconfig | 1 - 1 file changed, 1 deletion(-)
PATCH 1/1 configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
Quoted 22 lines · Philipp Tomsich
Quoted 13 lines
The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit is exceeded.
CONFIG_SPL_I2C_SUPPORTis not needed to move to main U-Boot. So let's disable it.Suggested-by David Wu <[email protected]>Signed-off-by Heinrich Schuchardt <[email protected]>Reviewed-by David Wu <[email protected]>---
This solves only one of the problems with the boards in v2019.04. The next problem is that reading the environment from MMC fails.Quoted 8 lines
The patch
[PATCH v3 1/1] configs: rk3288: Tinker Board SPL file must fit into 32 KiB
https://lists.denx.de/pipermail/u-boot/2019-February/358883.html
makes the problem visibe.--- configs/tinker-rk3288_defconfig | 1 - 1 file changed, 1 deletion(-)
Quoted 1 line
Reviewed-by Philipp Tomsich <[email protected]>
Hello Tom,
could you, please, merge this patch that has been lingering since February to fix the build issue for the TinkerBoard:
https://lists.denx.de/pipermail/u-boot/2019-February/360367.html
https://patchwork.ozlabs.org/patch/1049112/
You will have to rebase the patch:
CONFIG_SPL_TEXT_BASE=0xff704000 <<<< change this line CONFIG_SPL_STACK_R=y CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x2000
-CONFIG_SPL_I2C_SUPPORT=y
CONFIG_CMD_GPIO=y
CONFIG_CMD_GPT=y
CONFIG_CMD_I2C=y
Best regards
Heinrich
PATCH 1/1 configs: tinker-rk3288 disable CONFIG_SPL_I2C_SUPPORT
In reply to Heinrich SchuchardtQuoted 10 lines · Heinrich Schuchardt
The SPL for the Tinker Board has to fit into 32 KiB. Currently this limit is exceeded.
CONFIG_SPL_I2C_SUPPORTis not needed to move to main U-Boot. So let's disable it.Suggested-by David Wu <[email protected]>Signed-off-by Heinrich Schuchardt <[email protected]>Reviewed-by David Wu <[email protected]>Reviewed-by Philipp Tomsich <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190611/3795a00b/attachment.sig>