Skip to contentSkip to conversation

drm/etnaviv: Use dev_info() instead of pr_info()

PATCH In review Fabio Estevam 2 participants 2 messages Jun 11, 2019 – Jun 27, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 drm/etnaviv: Use dev_info() instead of pr_info()

dev_info() is more appropriate for printing _info level messages inside drivers, so switch to dev_info().

---
Changes since v1:
- Adjust commit log to say "_info level" instead of "error"

 drivers/gpu/drm/etnaviv/etnaviv_buffer.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/gpu/drm/etnaviv/etnaviv_buffer.c +7 -7
index 160ce3c060a5..827b5e42dbe3 100644
@@ -414,18 +414,18 @@ void etnaviv_buffer_queue(struct etnaviv_gpu *gpu, u32 exec_state,
 			    buffer->user_size - 4);
 
 	if (drm_debug & DRM_UT_DRIVER)
-		pr_info("stream link to 0x%08x @ 0x%08x %p\n",
-			return_target, etnaviv_cmdbuf_get_va(cmdbuf),
-			cmdbuf->vaddr);
+		dev_info(gpu->dev, "stream link to 0x%08x @ 0x%08x %p\n",
+			 return_target, etnaviv_cmdbuf_get_va(cmdbuf),
+			 cmdbuf->vaddr);
 
 	if (drm_debug & DRM_UT_DRIVER) {
 		print_hex_dump(KERN_INFO, "cmd ", DUMP_PREFIX_OFFSET, 16, 4,
 			       cmdbuf->vaddr, cmdbuf->size, 0);
 
-		pr_info("link op: %p\n", buffer->vaddr + waitlink_offset);
-		pr_info("addr: 0x%08x\n", link_target);
-		pr_info("back: 0x%08x\n", return_target);
-		pr_info("event: %d\n", event);
+		dev_info(gpu->dev, "link op: %p\n", buffer->vaddr + waitlink_offset);
+		dev_info(gpu->dev, "addr: 0x%08x\n", link_target);
+		dev_info(gpu->dev, "back: 0x%08x\n", return_target);
+		dev_info(gpu->dev, "event: %d\n", event);
 	}
 
 	/*
Signature · 6 lines
2.17.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
maintainer
#1 lore raw

Am Dienstag, den 11.06.2019, 12:26 -0300 schrieb Fabio Estevam:

Quoted 2 lines

dev_info() is more appropriate for printing _info level messages inside drivers, so switch to dev_info().

This renders the output quite inconsistent between the hexdumps and the related messages you are changing here. I do not see this as an improvement.

Regards,
Lucas

Quoted 27 lines

---
Changes since v1:
- Adjust commit log to say "_info level" instead of "error"

 drivers/gpu/drm/etnaviv/etnaviv_buffer.c | 14 +++++++-------

 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/gpu/drm/etnaviv/etnaviv_buffer.c +0 -0
index 160ce3c060a5..827b5e42dbe3 100644
@@ -414,18 +414,18 @@ void etnaviv_buffer_queue(struct etnaviv_gpu *gpu, u32 exec_state,
 >  			    buffer->user_size - 4);

drivers/gpu/drm/etnaviv/etnaviv_buffer.c void etnaviv_buffer_queue(struct etnaviv_gpu *gpu, u32 exec_state, · line 419

Quoted 7 lines

  if (drm_debug & DRM_UT_DRIVER)

drivers/gpu/drm/etnaviv/etnaviv_buffer.c +3 -3
-		pr_info("stream link to 0x%08x @ 0x%08x %p\n",
-			return_target, etnaviv_cmdbuf_get_va(cmdbuf),
-			cmdbuf->vaddr);
+		dev_info(gpu->dev, "stream link to 0x%08x @ 0x%08x %p\n",
+			 return_target, etnaviv_cmdbuf_get_va(cmdbuf),
+			 cmdbuf->vaddr);

Quoted 3 lines

  if (drm_debug & DRM_UT_DRIVER) { print_hex_dump(KERN_INFO, "cmd ", DUMP_PREFIX_OFFSET, 16, 4, cmdbuf->vaddr, cmdbuf->size, 0);

Quoted 11 lines
Quoted 9 lines
drivers/gpu/drm/etnaviv/etnaviv_buffer.c +4 -4
-		pr_info("link op: %p\n", buffer->vaddr + waitlink_offset);
-		pr_info("addr: 0x%08x\n", link_target);
-		pr_info("back: 0x%08x\n", return_target);
-		pr_info("event: %d\n", event);
+		dev_info(gpu->dev, "link op: %p\n", buffer->vaddr + waitlink_offset);
+		dev_info(gpu->dev, "addr: 0x%08x\n", link_target);
+		dev_info(gpu->dev, "back: 0x%08x\n", return_target);
+		dev_info(gpu->dev, "event: %d\n", event);

  }

Quoted 1 line

  /*

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel