Btrfs progs release 5.1.1
David Sterba
maintainerHi,
btrfs-progs version 5.1.1 have been released.
Changes:
* convert and mkfs will try to use optimized crc32c
* fi show: accept a file-backed image
* fi show: fix possible crash when device is deleted in parallel
* build:
* support extra flags for python bindings
* separate LDFLAGS for libbtrfsutil
* other:
* space reservation fixes or debugging improvements
* V0 extent code removed
* more tests and cleanups
Tarballs: https://www.kernel.org/pub/linux/kernel/people/kdave/btrfs-progs/
Git: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git
Shortlog:
David Sterba (9):
btrfs-progs: tests: unmount testing mount point recursively
btrfs-progs: tests: add helper for common mkfs on TEST_DEV
btrfs-progs: switch to mkfs helper
btrfs-progs: tests: fix misc-tests/029 to run on NFS
btrfs-progs: tests: misc-tests/034: use sudo helper for module probing
btrfs-progs: test: cleanup misc-tests/034
btrfs-progs: fix gcc9 warning and potentially unaligned access to dev stats
btrfs-progs: update CHANGES for v5.1.1
Btrfs progs v5.1.1
Joshua Watt (1):
btrfs-progs: build: Pass CFLAGS and LDFLAGS to Python
Nikolay Borisov (2):
btrfs-progs: Correctly open filesystem on image file
btrfs-progs: tests: Test fs on image files is correctly recognised
Qu Wenruo (7):
btrfs-progs: convert: Workaround delayed ref bug by limiting the size of a transaction
btrfs-progs: Output extent tree leaf if we failed to find a backref
btrfs-progs: Enable crc32c optimization probe for convert and mkfs
btrfs-progs: Cleanup BTRFS_COMPAT_EXTENT_TREE_V0
btrfs-progs: check/lowmem: Reset path in repair mode to avoid incorrect item from being passed to lowmem check.
btrfs-progs: Avoid nested chunk allocation call
btrfs-progs: Do metadata preallocation for fs trees and csum tree
Sergei Trofimovich (1):
btrfs-progs: build: apply LDFLAGS to libbtrfsutil.so
Su Yue (1):
btrfs-progs: fix invalid memory write in get_fs_info()
Quoted 1 line · David Sterba
btrfs-progs version 5.1.1 have been released.
Still test suite is failing for me.
+ /usr/bin/make test
[TEST] fsck-tests.sh
[TEST/fsck] 001-bad-file-extent-bytenr
[TEST/fsck] 002-bad-transid
[TEST/fsck] 003-shift-offsets
[TEST/fsck] 004-no-dir-index
[TEST/fsck] 005-bad-item-offset
[TEST/fsck] 006-bad-root-items
[TEST/fsck] 007-bad-offset-snapshots
[TEST/fsck] 008-bad-dir-index-name
[TEST/fsck] 009-no-dir-item-or-index
[TEST/fsck] 010-no-rootdir-inode-item
[TEST/fsck] 011-no-inode-item
[TEST/fsck] 012-leaf-corruption
[TEST/fsck] 013-extent-tree-rebuild
[TEST/fsck] 014-no-extent-info
[TEST/fsck] 016-wrong-inode-nbytes
[TEST/fsck] 017-missing-all-file-extent
[TEST/fsck] 018-leaf-crossing-stripes
[TEST/fsck] 019-non-skinny-false-alert
[TEST/fsck] 020-extent-ref-cases
[TEST/fsck] 021-partially-dropped-snapshot-case
[TEST/fsck] 022-qgroup-rescan-halfway
[TEST/fsck] 023-qgroup-stack-overflow
[TEST/fsck] 024-clear-space-cache
[TEST/fsck] 025-file-extents
[TEST/fsck] 026-bad-dir-item-name
[TEST/fsck] 027-bad-extent-inline-ref-type
[TEST/fsck] 028-unaligned-super-dev-sizes
[TEST/fsck] 029-valid-orphan-item
[TEST/fsck] 030-reflinked-prealloc-extents
[TEST/fsck] 031-metadatadump-check-data-csum
[TEST/fsck] 032-corrupted-qgroup
[TEST/fsck] 033-lowmem-collission-dir-items
[TEST/fsck] 034-bad-inode-flags
[TEST/fsck] 035-inline-bad-ram-bytes
[TEST/fsck] 036-bad-dev-extents
[TEST/fsck] 036-rescan-not-kicked-in
[TEST/fsck] 037-freespacetree-repairfailed: root_helper umount /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.img test failed for case 037-freespacetree-repair
make: *** [Makefile:352: test-fsck] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.3DQ01g (%check)
In log line I found:
====== RUN CHECK root_helper mount -t btrfs -o loop /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.img /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//mnt ====== RUN CHECK root_helper fallocate -l 50m /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//mnt/file ====== RUN CHECK root_helper umount /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.img
umount: /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests/mnt:
target is busy.
failed: root_helper umount /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.img
After test suite fails I'm able to umount it manually.
[tkloczko@domek tests]$ sudo umount /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.img [tkloczko@domek tests]$
So looks like during umount still something is holding umount.
kloczek
Signature · 1 line
Tomasz Kłoczko | LinkedIn: http://lnkd.in/FXPWxH
Quoted 64 lines · Tomasz Kłoczko
Quoted 1 line · David Sterba
btrfs-progs version 5.1.1 have been released.
Still test suite is failing for me.
+
/usr/bin/maketest[TEST] fsck-tests.sh [TEST/fsck] 001-bad-file-extent-bytenr [TEST/fsck] 002-bad-transid [TEST/fsck] 003-shift-offsets [TEST/fsck] 004-no-dir-index [TEST/fsck] 005-bad-item-offset [TEST/fsck] 006-bad-root-items [TEST/fsck] 007-bad-offset-snapshots [TEST/fsck] 008-bad-dir-index-name [TEST/fsck] 009-no-dir-item-or-index [TEST/fsck] 010-no-rootdir-inode-item [TEST/fsck] 011-no-inode-item [TEST/fsck] 012-leaf-corruption [TEST/fsck] 013-extent-tree-rebuild [TEST/fsck] 014-no-extent-info [TEST/fsck] 016-wrong-inode-nbytes [TEST/fsck] 017-missing-all-file-extent [TEST/fsck] 018-leaf-crossing-stripes [TEST/fsck] 019-non-skinny-false-alert [TEST/fsck] 020-extent-ref-cases [TEST/fsck] 021-partially-dropped-snapshot-case [TEST/fsck] 022-qgroup-rescan-halfway [TEST/fsck] 023-qgroup-stack-overflow [TEST/fsck] 024-clear-space-cache [TEST/fsck] 025-file-extents [TEST/fsck] 026-bad-dir-item-name [TEST/fsck] 027-bad-extent-inline-ref-type [TEST/fsck] 028-unaligned-super-dev-sizes [TEST/fsck] 029-valid-orphan-item [TEST/fsck] 030-reflinked-prealloc-extents [TEST/fsck] 031-metadatadump-check-data-csum [TEST/fsck] 032-corrupted-qgroup [TEST/fsck] 033-lowmem-collission-dir-items [TEST/fsck] 034-bad-inode-flags [TEST/fsck] 035-inline-bad-ram-bytes [TEST/fsck] 036-bad-dev-extents [TEST/fsck] 036-rescan-not-kicked-in [TEST/fsck] 037-freespacetree-repairfailed:
root_helperumount/home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.imgtest failed for case 037-freespacetree-repair
make: *** [Makefile:352: test-fsck] Error 1
error: Bad exit status from/var/tmp/rpm-tmp.3DQ01g(%check)In log line I found:
====== RUN CHECK
root_helpermount -t btrfs -o loop/home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.img/home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//mnt====== RUN CHECKroot_helperfallocate -l 50m/home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//mnt/file====== RUN CHECKroot_helperumount/home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.img
umount:/home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests/mnt:
target is busy.
failed:root_helperumount/home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.img
Quoted 7 lines
After test suite fails I'm able to umount it manually.
[tkloczko@domek tests]$ sudo umount
/home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.img[tkloczko@domek tests]$So looks like during umount still something is holding umount.
Similar situation here, but if you're using DE or things like udisk, it's mostly such tools affecting the umount.
For me, inside a minimal VM, without all the GUI things listening on mounted locations, 037 will pass without problem.
Thanks,
Qu
Quoted 3 lines
kloczek
Quoted 28 lines · Qu Wenruo
Quoted 27 lines · Tomasz Kłoczko
[TEST/fsck] 037-freespacetree-repair
failed:root_helperumount/home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.imgtest failed for case 037-freespacetree-repair
make: *** [Makefile:352: test-fsck] Error 1
error: Bad exit status from/var/tmp/rpm-tmp.3DQ01g(%check)In log line I found:
====== RUN CHECK
root_helpermount -t btrfs -o loop/home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.img/home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//mnt====== RUN CHECKroot_helperfallocate -l 50m/home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//mnt/file====== RUN CHECKroot_helperumount/home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.img
umount:/home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests/mnt:
target is busy.
failed:root_helperumount/home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.imgAfter test suite fails I'm able to umount it manually.
[tkloczko@domek tests]$ sudo umount
/home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.img[tkloczko@domek tests]$
Quoted 7 lines
Quoted 1 line
So looks like during umount still something is holding umount.
Similar situation here, but if you're using DE or things like udisk, it's mostly such tools affecting the umount.
For me, inside a minimal VM, without all the GUI things listening on mounted locations, 037 will pass without problem.
I'm running the tests on my desktop with a DE and the test passes every time.
Tomas, can you please run the tests with the following diff:
tests/common +4 -2
@@ -512,7 +512,10 @@ run_check_umount_test_dev() if [ "$#" = 0 ]; then set -- "$TEST_DEV" fi - run_check $SUDO_HELPER umount "$@" + if ! run_mayfail $SUDO_HELPER umount "$@"; then + run_check $SUDO_HELPER lsof "$TEST_MNT" + _fail "umount on $TEST_MNT failed" + fi } ---
This should dump all potential holders of the mount path when the umount fails. I've tested here by cd'ing into the mount directory right after the test starts and get something like this in the results:
====== RUN CHECK root_helper fallocate -l 4k .../btrfs-progs/tests//mnt/file.2779 ====== RUN CHECK root_helper fallocate -l 4k .../btrfs-progs/tests//mnt/file.2319 ====== RUN MAYFAIL root_helper umount .../btrfs-progs/tests//test.img
umount: .../btrfs-progs/tests/mnt: target is busy.
failed (ignored, ret=32): root_helper umount .../btrfs-progs/tests//test.img ====== RUN CHECK root_helper lsof .../btrfs-progs/tests//mnt
bash 7777 dsterba cwd DIR 0,68 51840 256 .../btrfs-progs/tests//mnt
umount on .../btrfs-progs/tests//mnt failed
test failed for case 037-freespacetree-repair
As a workaround, a short delay, sync and repeated umount can be done in the umount helper so the test is more reliable, but first I'd like to know what's causing the problems.
On Wed, 12 Jun 2019 at 15:44, David Sterba <[email protected]> wrote:
[..]
Quoted 1 line
Tomas, can you please run the tests with the following diff:
[..]
Quoted 4 lines
This should dump all potential holders of the mount path when the umount fails. I've tested here by cd'ing into the mount directory right after the test starts and get something like this in the results:
Quoted 9 lines
====== RUN CHECK
root_helperfallocate -l 4k .../btrfs-progs/tests//mnt/file.2779 ====== RUN CHECKroot_helperfallocate -l 4k .../btrfs-progs/tests//mnt/file.2319 ====== RUN MAYFAILroot_helperumount .../btrfs-progs/tests//test.img
umount: .../btrfs-progs/tests/mnt: target is busy.
failed (ignored, ret=32):root_helperumount .../btrfs-progs/tests//test.img ====== RUN CHECKroot_helperlsof .../btrfs-progs/tests//mnt
bash 7777 dsterba cwd DIR 0,68 51840 256 .../btrfs-progs/tests//mnt
umount on .../btrfs-progs/tests//mnt failed
test failed for case 037-freespacetree-repair
[TEST/fsck] 037-freespacetree-repair
failed: root_helper lsof /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//mnt test failed for case 037-freespacetree-repair
make: *** [Makefile:352: test-fsck] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.gAtTfC (%check)
in test suite log I found only:
====== RUN CHECK root_helper mount -t btrfs -o loop /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.img /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//mnt ====== RUN CHECK root_helper fallocate -l 50m /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//mnt/file ====== RUN MAYFAIL root_helper umount /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.img
umount: /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests/mnt:
target is busy.
failed (ignored, ret=32): root_helper umount /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//test.img ====== RUN CHECK root_helper lsof /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//mnt
lsof: WARNING: can't stat() fuse.gvfsd-fuse file system /run/user/1000/gvfs
Output information may be incomplete.
failed: root_helper lsof /home/tkloczko/rpmbuild/BUILD/btrfs-progs-v5.1.1/tests//mnt test failed for case 037-freespacetree-repair
kloczek
Signature · 1 line
Tomasz Kłoczko | LinkedIn: http://lnkd.in/FXPWxH