hwmon: asus_atk0110: no need to check return value of debugfs_create functions
Subsystems (2)
PATCH 1/1 hwmon: asus_atk0110: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Luca Tettamanti <[email protected]>
Cc Jean Delvare <[email protected]>
Cc Guenter Roeck <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
--- drivers/hwmon/asus_atk0110.c | 23 +++-------------------- 1 file changed, 3 insertions(+), 20 deletions(-)
drivers/hwmon/asus_atk0110.c +3 -20
@@ -789,33 +789,16 @@ static const struct file_operations atk_debugfs_ggrp_fops = {static void atk_debugfs_init (struct atk_data *data) {struct dentry *d; -struct dentry *f; data->debugfs.id =0 ; d =debugfs_create_dir ("asus_atk0110" ,NULL ); -if (!d ||IS_ERR (d)) -return ; - f =debugfs_create_x32 ("id" ,0600 , d, &data->debugfs.id); -if (!f ||IS_ERR (f)) - goto cleanup; - - f =debugfs_create_file_unsafe ("gitm" ,0400 , d, data, - &atk_debugfs_gitm); -if (!f ||IS_ERR (f)) - goto cleanup; - - f =debugfs_create_file ("ggrp" ,0400 , d, data, - &atk_debugfs_ggrp_fops); -if (!f ||IS_ERR (f)) - goto cleanup; +debugfs_create_x32 ("id" ,0600 , d, &data->debugfs.id); +debugfs_create_file_unsafe ("gitm" ,0400 , d, data, &atk_debugfs_gitm); +debugfs_create_file ("ggrp" ,0400 , d, data, &atk_debugfs_ggrp_fops); data->debugfs.root = d; - -return ; -cleanup: -debugfs_remove_recursive (d); }static void atk_debugfs_cleanup (struct atk_data *data)
Signature · 1 line
2.22.0
Quoted 9 lines · Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this.
Cc Luca Tettamanti <[email protected]>Cc Jean Delvare <[email protected]>Cc Guenter Roeck <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>
Applied.
Thanks,
Guenter
Quoted 45 lines
--- drivers/hwmon/asus_atk0110.c | 23 +++-------------------- 1 file changed, 3 insertions(+), 20 deletions(-)drivers/hwmon/asus_atk0110.c +3
-20@@ -789,33 +789,16 @@ static const struct file_operations atk_debugfs_ggrp_fops = {static void atk_debugfs_init (struct atk_data *data) {struct dentry *d; -struct dentry *f; data->debugfs.id =0 ; d =debugfs_create_dir ("asus_atk0110" ,NULL ); -if (!d ||IS_ERR (d)) -return ; - f =debugfs_create_x32 ("id" ,0600 , d, &data->debugfs.id); -if (!f ||IS_ERR (f)) - goto cleanup; - - f =debugfs_create_file_unsafe ("gitm" ,0400 , d, data, - &atk_debugfs_gitm); -if (!f ||IS_ERR (f)) - goto cleanup; - - f =debugfs_create_file ("ggrp" ,0400 , d, data, - &atk_debugfs_ggrp_fops); -if (!f ||IS_ERR (f)) - goto cleanup; +debugfs_create_x32 ("id" ,0600 , d, &data->debugfs.id); +debugfs_create_file_unsafe ("gitm" ,0400 , d, data, &atk_debugfs_gitm); +debugfs_create_file ("ggrp" ,0400 , d, data, &atk_debugfs_ggrp_fops); data->debugfs.root = d; - -return ; -cleanup: -debugfs_remove_recursive (d); }static void atk_debugfs_cleanup (struct atk_data *data)